From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lina Iyer <ilina@codeaurora.org>
Subject: Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake
 requests to TCS
Date: Tue, 1 May 2018 11:35:07 -0600
Message-ID: <20180501173507.GC23157@codeaurora.org>
References: <20180425214111.GC243180@google.com>
 <20180427173943.GD6380@codeaurora.org>
 <20180427184017.GI243180@google.com>
 <20180427194559.GE6380@codeaurora.org>
 <20180427200605.GJ243180@google.com>
 <20180427213201.GA23157@codeaurora.org>
 <20180427215449.GA133494@google.com>
 <CAD=FV=Wan0G_GG29Q-atBbQS+_7nnbqTndE+yyi_G=scOdGMFA@mail.gmail.com>
 <20180501161010.GB23157@codeaurora.org>
 <CAD=FV=XAPLxFqMvWrvAbpki0AvN_TqKgzBYmZAuomVz-9ieK=Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <CAD=FV=XAPLxFqMvWrvAbpki0AvN_TqKgzBYmZAuomVz-9ieK=Q@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Doug Anderson <dianders@chromium.org>
Cc: Matthias Kaehlcke <mka@chromium.org>, Andy Gross <andy.gross@linaro.org>, David Brown <david.brown@linaro.org>, linux-arm-msm@vger.kernel.org, "open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>, Rajendra Nayak <rnayak@codeaurora.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, LKML <linux-kernel@vger.kernel.org>, Stephen Boyd <sboyd@kernel.org>, Evan Green <evgreen@chromium.org>
List-Id: linux-arm-msm@vger.kernel.org

On Tue, May 01 2018 at 10:42 -0600, Doug Anderson wrote:
>Hi,
>
>On Tue, May 1, 2018 at 9:10 AM, Lina Iyer <ilina@codeaurora.org> wrote:
>> Yes, this is incorrect in its current form. This is what it should be -
>>
>> static int find_match(const struct tcs_group *tcs, const struct tcs_cmd
>> *cmd,
>>                      int len)
>> {
>>        int i, j;
>>
>>        /* Check for already cached commands */
>>        for_each_set_bit(i, tcs->slots, MAX_TCS_SLOTS) {
>>                if (tcs->cmd_cache[i] != cmd[0].addr)
>>                        continue;
>>                for (j = 0; j < len; j++) {
>>                        WARN(tcs->cmd_cache[i + j] != cmd[j].addr,
>>                             "Message does not match previous sequence.\n");
>>                        return -EINVAL;
>>                }
>
>If len > 0, won't the above always return -EINVAL?
>
>
>>                if (j == len - 1)
>>                        return i;
>
>Care to explain how you could get here and the test "if (j == len -
>1)" could be false?  ;-P
>
True. Will fix it in the next spin correctly.

--Lina