From: Alex Elder <elder@linaro.org>
To: andy.gross@linaro.org
Cc: clew@codeaurora.org, aneela@codeaurora.org,
david.brown@linaro.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 00/12] soc: qcom: smem: some refactoring
Date: Tue, 1 May 2018 20:10:07 -0500 [thread overview]
Message-ID: <20180502011019.22812-1-elder@linaro.org> (raw)
This series contains a few general cleanups in the Qualcomm SMEM
code, reorganizing some things so memory partitions are treated
more consistently, and to avoid some duplication. A few patches
change existing behavior, as highlighted below. Each of these
changes has been tested and verified to function with available
hardware.
-Alex
Alex Elder (12):
soc: qcom: smem: rename variable in qcom_smem_get_global()
soc: qcom: smem: initialize region struct only when successful
These two are simple cleanups.
soc: qcom: smem: always ignore partitions with 0 offset or size
This patch makes partitions with a zero offset always be
ignored. Previously this condition was flagged as an error
in one place and ignored in another.
soc: qcom: smem: small refactor in qcom_smem_enumerate_partitions()
This just simplifies a little logic in one spot.
soc: qcom: smem: verify both host ids in partition header
This patch makes it so *both* IDs, not just one or the
other, must use the special value SMEM_GLOBAL_HOST to
signify the special global partition.
soc: qcom: smem: require order of host ids to match
A memory partition is described by an entry in a partition
table, which identifies two hosts permitted to access the
partition. A partition also embeds a header, which also
identifies the hosts. Previously the host ids could be
in any order; now the two host ids are required to be
listed in the same order in the partition table and header.
soc: qcom: smem: introduce qcom_smem_partition_header()
soc: qcom: smem: verify partition header size
soc: qcom: smem: verify partition offset_free_uncached
soc: qcom: smem: small change in global entry loop
soc: qcom: smem: verify partition host ids match
These patches together introduce a single function
to locate a partition header in memory, and to validate its
contents. The common function is used in two place and
removes some duplication. The patches build up the function
in steps to facilitate review.
soc: qcom: smem: a few last cleanups
This patch gathers a small set of trivial cleanups.
drivers/soc/qcom/smem.c | 173 +++++++++++++++++++++++-------------------------
1 file changed, 82 insertions(+), 91 deletions(-)
--
2.14.1
next reply other threads:[~2018-05-02 1:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 1:10 Alex Elder [this message]
2018-05-02 1:10 ` [PATCH 01/12] soc: qcom: smem: rename variable in qcom_smem_get_global() Alex Elder
2018-05-02 1:10 ` [PATCH 02/12] soc: qcom: smem: initialize region struct only when successful Alex Elder
2018-05-02 1:10 ` [PATCH 03/12] soc: qcom: smem: always ignore partitions with 0 offset or size Alex Elder
2018-05-02 1:10 ` [PATCH 04/12] soc: qcom: smem: small refactor in qcom_smem_enumerate_partitions() Alex Elder
2018-05-02 1:10 ` [PATCH 05/12] soc: qcom: smem: verify both host ids in partition header Alex Elder
2018-05-02 1:10 ` [PATCH 06/12] soc: qcom: smem: require order of host ids to match Alex Elder
2018-05-02 1:10 ` [PATCH 07/12] soc: qcom: smem: introduce qcom_smem_partition_header() Alex Elder
2018-05-02 1:10 ` [PATCH 08/12] soc: qcom: smem: verify partition header size Alex Elder
2018-05-02 1:10 ` [PATCH 09/12] soc: qcom: smem: verify partition offset_free_uncached Alex Elder
2018-05-02 1:10 ` [PATCH 10/12] soc: qcom: smem: small change in global entry loop Alex Elder
2018-05-02 1:10 ` [PATCH 11/12] soc: qcom: smem: verify partition host ids match Alex Elder
2018-05-02 1:10 ` [PATCH 12/12] soc: qcom: smem: a few last cleanups Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502011019.22812-1-elder@linaro.org \
--to=elder@linaro.org \
--cc=andy.gross@linaro.org \
--cc=aneela@codeaurora.org \
--cc=clew@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox