From: Christoph Hellwig <hch@lst.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: zajec5@gmail.com, linux-pci@vger.kernel.org,
jarkko.sakkinen@linux.intel.com, david.brown@linaro.org,
frowand.list@gmail.com, hch@lst.de, m.szyprowski@samsung.com,
vinod.koul@intel.com, bharat.bhushan@nxp.com,
rafael.j.wysocki@intel.com, linux@armlinux.org.uk,
andy.gross@linaro.org, msuchanek@suse.de,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-arm-msm@vger.kernel.org, johan@kernel.org,
robh+dt@kernel.org, dri-devel@lists.freedesktop.org,
Nipun Gupta <nipun.gupta@nxp.com>,
bhelgaas@google.com, dan.j.williams@intel.com,
linux-soc@vger.kernel.org, gregkh@linuxfoundation.org,
dmitry.torokhov@gmail.com, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, leoyang.li@nxp.com,
iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
robin.murphy@arm.com
Subject: Re: [PATCH v4 1/2] dma-mapping: move dma configuration to bus infrastructure
Date: Thu, 3 May 2018 14:21:47 +0200 [thread overview]
Message-ID: <20180503122147.GB18590@lst.de> (raw)
In-Reply-To: <20180430104124.GE2476@ulmo>
On Mon, Apr 30, 2018 at 12:41:24PM +0200, Thierry Reding wrote:
> On Sat, Apr 28, 2018 at 08:21:58AM +0530, Nipun Gupta wrote:
> [...]
> > diff --git a/drivers/gpu/host1x/bus.c b/drivers/gpu/host1x/bus.c
> > index 88a3558..a9ec99d 100644
> > --- a/drivers/gpu/host1x/bus.c
> > +++ b/drivers/gpu/host1x/bus.c
> > @@ -314,6 +314,13 @@ static int host1x_device_match(struct device *dev, struct device_driver *drv)
> > return strcmp(dev_name(dev), drv->name) == 0;
> > }
> >
> > +static int host1x_dma_configure(struct device *dev)
> > +{
> > + if (dev->of_node)
> > + return of_dma_configure(dev, dev->of_node);
>
> The conditional here is somewhat pointless since the of_node should
> always be set. If it weren't it should be considered a bug and this
> function welcome to crash to make that very obvious.
Agreed. Please remove the check for the resend.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-05-03 12:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1520868292-2479-1-git-send-email-nipun.gupta@nxp.com>
[not found] ` <1520868292-2479-1-git-send-email-nipun.gupta-3arQi8VN3Tc@public.gmane.org>
2018-03-21 6:55 ` [PATCH v2 1/2] dma-mapping: move dma configuration to bus infrastructure Nipun Gupta
[not found] ` <1521615323-4752-1-git-send-email-nipun.gupta-3arQi8VN3Tc@public.gmane.org>
2018-03-21 6:55 ` [PATCH v2 2/2] drivers: remove force dma flag from buses Nipun Gupta
[not found] ` <1521615323-4752-2-git-send-email-nipun.gupta-3arQi8VN3Tc@public.gmane.org>
2018-03-21 9:35 ` Greg KH
[not found] ` <20180321093525.GT14085-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2018-03-21 16:28 ` Nipun Gupta
[not found] ` <HE1PR0401MB2425644F72A063ED42B79D5FE6AA0-B0v07Ae2taqTjcJO+iVGAo3W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2018-03-21 17:49 ` Greg KH
2018-03-22 8:19 ` Christoph Hellwig
[not found] ` <20180322081926.GC29444-jcswGhMUV9g@public.gmane.org>
2018-03-22 15:13 ` Nipun Gupta
2018-03-23 16:09 ` kbuild test robot
2018-03-23 17:41 ` kbuild test robot
2018-03-21 7:19 ` [PATCH v2 1/2] dma-mapping: move dma configuration to bus infrastructure Bharat Bhushan
[not found] ` <AM5PR0401MB254503027680DE6A23355D909AAA0-oQ3wXcTHOqrg6d/1FbYcvI3W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2018-03-21 7:29 ` Nipun Gupta
2018-03-22 8:17 ` hch-jcswGhMUV9g
2018-03-21 9:29 ` Greg KH
[not found] ` <20180321092954.GS14085-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2018-03-21 16:13 ` Nipun Gupta
2018-03-22 8:15 ` Christoph Hellwig
[not found] ` <20180322081530.GA29444-jcswGhMUV9g@public.gmane.org>
2018-03-22 15:05 ` Nipun Gupta
2018-03-24 9:25 ` kbuild test robot
2018-03-30 7:54 ` [PATCH v3 " Nipun Gupta
2018-04-10 19:20 ` Bjorn Helgaas
[not found] ` <20180410192041.GA54986-1RhO1Y9PlrlHTL0Zs8A6p5iNqAH0jzoTYJqu5kTmcBRl57MIdRCFDg@public.gmane.org>
2018-04-23 12:56 ` Christoph Hellwig
[not found] ` <1522396485-10248-1-git-send-email-nipun.gupta-3arQi8VN3Tc@public.gmane.org>
2018-03-30 7:54 ` [PATCH v3 2/2] drivers: remove force dma flag from buses Nipun Gupta
[not found] ` <1522396485-10248-2-git-send-email-nipun.gupta-3arQi8VN3Tc@public.gmane.org>
2018-04-09 20:27 ` Rob Herring
2018-04-10 19:21 ` Bjorn Helgaas
2018-04-23 12:56 ` [PATCH v3 1/2] dma-mapping: move dma configuration to bus infrastructure Christoph Hellwig
[not found] ` <20180423125638.GB8824-jcswGhMUV9g@public.gmane.org>
2018-04-27 17:10 ` Nipun Gupta
2018-04-28 2:51 ` [PATCH v4 " Nipun Gupta
[not found] ` <1524883919-29484-1-git-send-email-nipun.gupta-3arQi8VN3Tc@public.gmane.org>
2018-04-28 2:51 ` [PATCH v4 2/2] drivers: remove force dma flag from buses Nipun Gupta
2018-05-01 12:34 ` Rob Herring
2018-05-03 16:36 ` Vinod Koul
2018-04-30 10:41 ` [PATCH v4 1/2] dma-mapping: move dma configuration to bus infrastructure Thierry Reding
2018-05-03 12:21 ` Christoph Hellwig [this message]
2018-05-03 12:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503122147.GB18590@lst.de \
--to=hch@lst.de \
--cc=andy.gross@linaro.org \
--cc=bharat.bhushan@nxp.com \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=johan@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=msuchanek@suse.de \
--cc=nipun.gupta@nxp.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
--cc=vinod.koul@intel.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).