From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH v2 02/14] mtd: rawnand: denali: use helper function for ecc setup Date: Mon, 21 May 2018 16:30:14 +0200 Message-ID: <20180521163014.355318d6@xps13> References: <1525350041-22995-1-git-send-email-absahu@codeaurora.org> <1525350041-22995-3-git-send-email-absahu@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <1525350041-22995-3-git-send-email-absahu@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Abhishek Sahu Cc: Boris Brezillon , David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Andy Gross , Archit Taneja , Masahiro Yamada List-Id: linux-arm-msm@vger.kernel.org Hi Abhishek, On Thu, 3 May 2018 17:50:29 +0530, Abhishek Sahu wrote: > Now, the NAND base layer has helper function for ecc > parameters setup which does the same thing. Even if this message has a meaning in the series, I would prefer something more generic like: "Use the NAND core helper function xxx() to tune the ECC parameters instead of the function locally defined." With this change: Acked-by: Miquel Raynal Thanks, Miquèl