From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH v2 10/14] mtd: rawnand: qcom: fix return value for raw page read Date: Tue, 22 May 2018 14:04:16 +0200 Message-ID: <20180522140416.252fb398@xps13> References: <1525350041-22995-1-git-send-email-absahu@codeaurora.org> <1525350041-22995-11-git-send-email-absahu@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <1525350041-22995-11-git-send-email-absahu@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Abhishek Sahu Cc: Boris Brezillon , David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Andy Gross , Archit Taneja List-Id: linux-arm-msm@vger.kernel.org Hi Abhishek, On Thu, 3 May 2018 17:50:37 +0530, Abhishek Sahu wrote: > Currently zero is being returned for all raw page read so > fix the same. What about "Fix value returned by ->read_page_raw() to be the actual operation status, instead of always 0."? > > Signed-off-by: Abhishek Sahu > --- > * Changes from v1: > > NEW CHANGE > > drivers/mtd/nand/raw/qcom_nandc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c > index f85d8ab..17b7f3af 100644 > --- a/drivers/mtd/nand/raw/qcom_nandc.c > +++ b/drivers/mtd/nand/raw/qcom_nandc.c > @@ -1900,7 +1900,7 @@ static int qcom_nandc_read_page_raw(struct mtd_info *mtd, > > free_descs(nandc); > > - return 0; > + return ret; > } > > /* implements ecc->read_oob() */ Thanks, Miquèl -- Miquel Raynal, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com