linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Abhishek Sahu <absahu@codeaurora.org>
Cc: Boris Brezillon <boris.brezillon@bootlin.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, Andy Gross <andy.gross@linaro.org>,
	Archit Taneja <architt@codeaurora.org>
Subject: Re: [PATCH v3 13/16] mtd: rawnand: qcom: minor code reorganization for bad block check
Date: Sat, 26 May 2018 10:58:38 +0200	[thread overview]
Message-ID: <20180526104900.139dd19b@xps13> (raw)
In-Reply-To: <1527250904-21988-14-git-send-email-absahu@codeaurora.org>

Hi Abhishek,


> @@ -2141,12 +2127,10 @@ static int qcom_nandc_block_bad(struct mtd_info *mtd, loff_t ofs)
>  		goto err;
>  	}
>  
> -	bbpos = mtd->writesize - host->cw_size * (ecc->steps - 1);
> -
> -	bad = nandc->data_buffer[bbpos] != 0xff;
> +	bad = bbm_bytes_buf[0] != 0xff;

BTW, as there are host->bbm_size bytes that can inform on the block
state, don't we need to check all of them?

>  
>  	if (chip->options & NAND_BUSWIDTH_16)
> -		bad = bad || (nandc->data_buffer[bbpos + 1] != 0xff);
> +		bad = bad || (bbm_bytes_buf[1] != 0xff);
>  err:
>  	return bad;
>  }

Thanks,
Miquèl

  parent reply	other threads:[~2018-05-26  8:58 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-25 12:21 [PATCH v3 00/16] Update for QCOM NAND driver Abhishek Sahu
2018-05-25 12:21 ` [PATCH v3 01/16] mtd: rawnand: helper function for setting up ECC configuration Abhishek Sahu
2018-05-26  8:42   ` Miquel Raynal
2018-05-28  5:46     ` Abhishek Sahu
2018-06-07 12:37       ` Miquel Raynal
2018-06-11  9:16         ` Abhishek Sahu
2018-06-18 10:04           ` Miquel Raynal
2018-05-29 19:30     ` Boris Brezillon
2018-05-30  0:28       ` Masahiro Yamada
2018-05-30  6:21         ` Abhishek Sahu
2018-05-30  7:38           ` Masahiro Yamada
2018-05-30  8:53             ` Abhishek Sahu
2018-05-25 12:21 ` [PATCH v3 02/16] mtd: rawnand: denali: use helper function for ecc setup Abhishek Sahu
2018-05-27  9:26   ` Masahiro Yamada
2018-05-25 12:21 ` [PATCH v3 03/16] dt-bindings: qcom_nandc: make nand-ecc-strength optional Abhishek Sahu
2018-05-26  8:42   ` Miquel Raynal
2018-05-28  5:53     ` Abhishek Sahu
2018-05-25 12:21 ` [PATCH v3 04/16] dt-bindings: qcom_nandc: remove nand-ecc-step-size Abhishek Sahu
2018-05-25 12:21 ` [PATCH v3 05/16] mtd: rawnand: qcom: remove dt property nand-ecc-step-size Abhishek Sahu
2018-05-26  8:42   ` Miquel Raynal
2018-05-28  5:55     ` Abhishek Sahu
2018-05-25 12:21 ` [PATCH v3 06/16] mtd: rawnand: qcom: use the ecc strength from device parameter Abhishek Sahu
2018-05-26  8:43   ` Miquel Raynal
2018-05-28  6:01     ` Abhishek Sahu
2018-05-25 12:21 ` [PATCH v3 07/16] mtd: rawnand: qcom: wait for desc completion in all BAM channels Abhishek Sahu
2018-05-26  8:43   ` Miquel Raynal
2018-05-25 12:21 ` [PATCH v3 08/16] mtd: rawnand: qcom: erased page detection for uncorrectable errors only Abhishek Sahu
2018-05-25 12:21 ` [PATCH v3 09/16] mtd: rawnand: qcom: fix null pointer access for erased page detection Abhishek Sahu
2018-05-25 12:21 ` [PATCH v3 10/16] mtd: rawnand: qcom: parse read errors for read oob also Abhishek Sahu
2018-05-25 12:21 ` [PATCH v3 11/16] mtd: rawnand: qcom: modify write_oob to remove read codeword part Abhishek Sahu
2018-05-25 12:21 ` [PATCH v3 12/16] mtd: rawnand: qcom: fix return value for raw page read Abhishek Sahu
2018-05-26  8:43   ` Miquel Raynal
2018-05-25 12:21 ` [PATCH v3 13/16] mtd: rawnand: qcom: minor code reorganization for bad block check Abhishek Sahu
2018-05-26  8:46   ` Miquel Raynal
2018-05-28  6:12     ` Abhishek Sahu
2018-05-28  7:03       ` Miquel Raynal
2018-05-28 10:10         ` Abhishek Sahu
2018-06-07 12:53           ` Miquel Raynal
2018-06-11 13:22             ` Abhishek Sahu
2018-06-18 11:35               ` Miquel Raynal
2018-06-20  7:04                 ` Abhishek Sahu
2018-05-26  8:58   ` Miquel Raynal [this message]
2018-05-28  6:16     ` Abhishek Sahu
2018-05-28  7:09       ` Miquel Raynal
2018-05-25 12:21 ` [PATCH v3 14/16] mtd: rawnand: qcom: check for operation errors in case of raw read Abhishek Sahu
2018-05-26  8:58   ` Miquel Raynal
2018-05-25 12:21 ` [PATCH v3 15/16] mtd: rawnand: qcom: helper function for " Abhishek Sahu
2018-05-27 13:53   ` Miquel Raynal
2018-05-28  7:34     ` Abhishek Sahu
2018-06-07 12:43       ` Miquel Raynal
2018-06-11  9:19         ` Abhishek Sahu
2018-05-25 12:21 ` [PATCH v3 16/16] mtd: rawnand: qcom: erased page bitflips detection Abhishek Sahu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180526104900.139dd19b@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=absahu@codeaurora.org \
    --cc=andy.gross@linaro.org \
    --cc=architt@codeaurora.org \
    --cc=boris.brezillon@bootlin.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=dwmw2@infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).