Re: [PATCH 1/3] drm/msm: Add a helper function to parse clock names

[kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1811 bytes --]

Hi Jordan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robclark/msm-next]
[also build test WARNING on v4.17 next-20180604]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jordan-Crouse/Add-support-for-Adreno-a6xx/20180605-070248
base:   git://people.freedesktop.org/~robclark/linux msm-next
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

   drivers/gpu//drm/msm/msm_gpu.c: In function 'enable_clk':
>> drivers/gpu//drm/msm/msm_gpu.c:158:2: warning: ignoring return value of 'clk_bulk_prepare_enable', declared with attribute warn_unused_result [-Wunused-result]
     clk_bulk_prepare_enable(gpu->nr_clocks, gpu->grp_clks);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/clk_bulk_prepare_enable +158 drivers/gpu//drm/msm/msm_gpu.c

   148	
   149	static int enable_clk(struct msm_gpu *gpu)
   150	{
   151		if (gpu->core_clk && gpu->fast_rate)
   152			clk_set_rate(gpu->core_clk, gpu->fast_rate);
   153	
   154		/* Set the RBBM timer rate to 19.2Mhz */
   155		if (gpu->rbbmtimer_clk)
   156			clk_set_rate(gpu->rbbmtimer_clk, 19200000);
   157	
 > 158		clk_bulk_prepare_enable(gpu->nr_clocks, gpu->grp_clks);
   159	
   160		return 0;
   161	}
   162	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65220 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno