From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Subject: Re: Do Qualcomm drivers use DMA buffers for request_firmware_into_buf()? Date: Thu, 7 Jun 2018 00:55:22 +0200 Message-ID: <20180606225522.GL4511@wotan.suse.de> References: <20180424234219.GX14440@wotan.suse.de> <1524632409.3371.48.camel@linux.vnet.ibm.com> <20180425175557.GY14440@wotan.suse.de> <20180508153805.GC27853@wotan.suse.de> <20180601192346.GQ4511@wotan.suse.de> <20180606203257.GH4511@wotan.suse.de> <20180606222929.GK4511@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Ard Biesheuvel Cc: Dmitry Torokhov , Matt Fleming , Will Deacon , Michal Hocko , David Howells , David Brown , Peter Jones , "Luis R. Rodriguez" , "H . Peter Anvin" , "open list:ANDROID DRIVERS" , Nicolas Broeking , Jonathan Corbet , the arch/x86 maintainers , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Ingo Molnar , Kalle Valo , Andy Gross , Darren Hart , Mimi Zohar , platform-driver-x86@vger.kernel.org, Arend Van Spriel , Todd Kjos , Kees Cook List-Id: linux-arm-msm@vger.kernel.org On Thu, Jun 07, 2018 at 12:41:12AM +0200, Ard Biesheuvel wrote: > On 7 June 2018 at 00:29, Luis R. Rodriguez wrote: > > Given no one is providing a clear answer, and we cannot easily describe the > > buffer at run time we'll just move forward with READING_FIRMWARE_DMA_COHERENT. > > I seriously wonder whether the QCOM code cannot switch to the > streaming API instead. That is generally preferred anyway (for > performance, although that should not matter for loading firmware) but > also removes this single wart for which we have to invent new flags > and new security code plus the associated validation overhead. Given 1 month and no response I don't think we can count on that at this point. Luis -- Do not panic