From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jordan Crouse Subject: Re: [PATCH] drm/msm/adreno: Remove VLA usage Date: Fri, 29 Jun 2018 15:20:47 -0600 Message-ID: <20180629212047.GH24526@jcrouse-lnx.qualcomm.com> References: <20180629184818.GA37439@beast> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180629184818.GA37439@beast> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Kees Cook Cc: David Airlie , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Rob Clark , freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gRnJpLCBKdW4gMjksIDIwMTggYXQgMTE6NDg6MThBTSAtMDcwMCwgS2VlcyBDb29rIHdyb3Rl Ogo+IEluIHRoZSBxdWVzdCB0byByZW1vdmUgYWxsIHN0YWNrIFZMQSB1c2FnZSBmcm9tIHRoZSBr ZXJuZWxbMV0sIHRoaXMKPiBzd2l0Y2hlcyB0byB1c2luZyBhIGthc3ByaW50ZigpZWQgYnVmZmVy LiBSZXR1cm4gcGF0aHMgYXJlIHVwZGF0ZWQKPiB0byBmcmVlIHRoZSBhbGxvY2F0aW9uLgo+IAo+ IFsxXSBodHRwczovL2xrbWwua2VybmVsLm9yZy9yL0NBKzU1YUZ6Q0ctek5tWndYNEEyRlFwYWRh ZkxmRXpLNkNDPXFQWHlkQWFjVTFScVpXQUBtYWlsLmdtYWlsLmNvbQoKVGhhbmtzIGZvciBkb2lu ZyB0aGlzLgoKQWNrZWQtYnk6IEpvcmRhbiBDcm91c2UgPGpjcm91c2VAY29kZWF1cm9yYS5vcmc+ Cgo+IFNpZ25lZC1vZmYtYnk6IEtlZXMgQ29vayA8a2Vlc2Nvb2tAY2hyb21pdW0ub3JnPgo+IC0t LQo+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL2FkcmVuby9hNXh4X2dwdS5jICAgfCAgNyArKysrKy0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vYWRyZW5vL2FkcmVub19ncHUuYyB8IDI4ICsrKysrKysr KysrKysrKysrLS0tLS0tLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAx MSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9hZHJl bm8vYTV4eF9ncHUuYyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vYWRyZW5vL2E1eHhfZ3B1LmMKPiBp bmRleCBkMzk0MDBlNWJjNDIuLmY1Zjc2ZjgxNTFmOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vbXNtL2FkcmVuby9hNXh4X2dwdS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9h ZHJlbm8vYTV4eF9ncHUuYwo+IEBAIC0xMSw2ICsxMSw3IEBACj4gICAqCj4gICAqLwo+ICAKPiAr I2luY2x1ZGUgPGxpbnV4L2tlcm5lbC5oPgo+ICAjaW5jbHVkZSA8bGludXgvdHlwZXMuaD4KPiAg I2luY2x1ZGUgPGxpbnV4L2NwdW1hc2suaD4KPiAgI2luY2x1ZGUgPGxpbnV4L3Fjb21fc2NtLmg+ Cj4gQEAgLTE5LDYgKzIwLDcgQEAKPiAgI2luY2x1ZGUgPGxpbnV4L3NvYy9xY29tL21kdF9sb2Fk ZXIuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L3BtX29wcC5oPgo+ICAjaW5jbHVkZSA8bGludXgvbnZt ZW0tY29uc3VtZXIuaD4KPiArI2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4KPiAgI2luY2x1ZGUgIm1z bV9nZW0uaCIKPiAgI2luY2x1ZGUgIm1zbV9tbXUuaCIKPiAgI2luY2x1ZGUgImE1eHhfZ3B1Lmgi Cj4gQEAgLTkxLDEyICs5MywxMyBAQCBzdGF0aWMgaW50IHphcF9zaGFkZXJfbG9hZF9tZHQoc3Ry dWN0IG1zbV9ncHUgKmdwdSwgY29uc3QgY2hhciAqZnduYW1lKQo+ICAJCXJldCA9IHFjb21fbWR0 X2xvYWQoZGV2LCBmdywgZnduYW1lLCBHUFVfUEFTX0lELAo+ICAJCQkJbWVtX3JlZ2lvbiwgbWVt X3BoeXMsIG1lbV9zaXplLCBOVUxMKTsKPiAgCX0gZWxzZSB7Cj4gLQkJY2hhciBuZXduYW1lW3N0 cmxlbigicWNvbS8iKSArIHN0cmxlbihmd25hbWUpICsgMV07Cj4gKwkJY2hhciAqbmV3bmFtZTsK PiAgCj4gLQkJc3ByaW50ZihuZXduYW1lLCAicWNvbS8lcyIsIGZ3bmFtZSk7Cj4gKwkJbmV3bmFt ZSA9IGthc3ByaW50ZihHRlBfS0VSTkVMLCAicWNvbS8lcyIsIGZ3bmFtZSk7Cj4gIAo+ICAJCXJl dCA9IHFjb21fbWR0X2xvYWQoZGV2LCBmdywgbmV3bmFtZSwgR1BVX1BBU19JRCwKPiAgCQkJCW1l bV9yZWdpb24sIG1lbV9waHlzLCBtZW1fc2l6ZSwgTlVMTCk7Cj4gKwkJa2ZyZWUobmV3bmFtZSk7 Cj4gIAl9Cj4gIAlpZiAocmV0KQo+ICAJCWdvdG8gb3V0Owo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vbXNtL2FkcmVuby9hZHJlbm9fZ3B1LmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Fk cmVuby9hZHJlbm9fZ3B1LmMKPiBpbmRleCBiY2JmOWYyYTI5ZjkuLmJmYWFmZGZjN2ViMiAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2FkcmVuby9hZHJlbm9fZ3B1LmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vbXNtL2FkcmVuby9hZHJlbm9fZ3B1LmMKPiBAQCAtMTcsNyArMTcs OSBAQAo+ICAgKiB0aGlzIHByb2dyYW0uICBJZiBub3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3Jn L2xpY2Vuc2VzLz4uCj4gICAqLwo+ICAKPiArI2luY2x1ZGUgPGxpbnV4L2tlcm5lbC5oPgo+ICAj aW5jbHVkZSA8bGludXgvcG1fb3BwLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9zbGFiLmg+Cj4gICNp bmNsdWRlICJhZHJlbm9fZ3B1LmgiCj4gICNpbmNsdWRlICJtc21fZ2VtLmgiCj4gICNpbmNsdWRl ICJtc21fbW11LmgiCj4gQEAgLTcwLDEwICs3MiwxMiBAQCBhZHJlbm9fcmVxdWVzdF9mdyhzdHJ1 Y3QgYWRyZW5vX2dwdSAqYWRyZW5vX2dwdSwgY29uc3QgY2hhciAqZnduYW1lKQo+ICB7Cj4gIAlz dHJ1Y3QgZHJtX2RldmljZSAqZHJtID0gYWRyZW5vX2dwdS0+YmFzZS5kZXY7Cj4gIAljb25zdCBz dHJ1Y3QgZmlybXdhcmUgKmZ3ID0gTlVMTDsKPiAtCWNoYXIgbmV3bmFtZVtzdHJsZW4oInFjb20v IikgKyBzdHJsZW4oZnduYW1lKSArIDFdOwo+ICsJY2hhciAqbmV3bmFtZTsKPiAgCWludCByZXQ7 Cj4gIAo+IC0Jc3ByaW50ZihuZXduYW1lLCAicWNvbS8lcyIsIGZ3bmFtZSk7Cj4gKwluZXduYW1l ID0ga2FzcHJpbnRmKEdGUF9LRVJORUwsICJxY29tLyVzIiwgZnduYW1lKTsKPiArCWlmICghbmV3 bmFtZSkKPiArCQlyZXR1cm4gRVJSX1BUUigtRU5PTUVNKTsKPiAgCj4gIAkvKgo+ICAJICogVHJ5 IGZpcnN0IHRvIGxvYWQgZnJvbSBxY29tLyRmd2ZpbGUgdXNpbmcgYSBkaXJlY3QgbG9hZCAodG8g YXZvaWQKPiBAQCAtODcsMTEgKzkxLDEyIEBAIGFkcmVub19yZXF1ZXN0X2Z3KHN0cnVjdCBhZHJl bm9fZ3B1ICphZHJlbm9fZ3B1LCBjb25zdCBjaGFyICpmd25hbWUpCj4gIAkJCWRldl9pbmZvKGRy bS0+ZGV2LCAibG9hZGVkICVzIGZyb20gbmV3IGxvY2F0aW9uXG4iLAo+ICAJCQkJbmV3bmFtZSk7 Cj4gIAkJCWFkcmVub19ncHUtPmZ3bG9jID0gRldfTE9DQVRJT05fTkVXOwo+IC0JCQlyZXR1cm4g Znc7Cj4gKwkJCWdvdG8gb3V0Owo+ICAJCX0gZWxzZSBpZiAoYWRyZW5vX2dwdS0+Zndsb2MgIT0g RldfTE9DQVRJT05fVU5LTk9XTikgewo+ICAJCQlkZXZfZXJyKGRybS0+ZGV2LCAiZmFpbGVkIHRv IGxvYWQgJXM6ICVkXG4iLAo+ICAJCQkJbmV3bmFtZSwgcmV0KTsKPiAtCQkJcmV0dXJuIEVSUl9Q VFIocmV0KTsKPiArCQkJZncgPSBFUlJfUFRSKHJldCk7Cj4gKwkJCWdvdG8gb3V0Owo+ICAJCX0K PiAgCX0KPiAgCj4gQEAgLTEwNiwxMSArMTExLDEyIEBAIGFkcmVub19yZXF1ZXN0X2Z3KHN0cnVj dCBhZHJlbm9fZ3B1ICphZHJlbm9fZ3B1LCBjb25zdCBjaGFyICpmd25hbWUpCj4gIAkJCWRldl9p bmZvKGRybS0+ZGV2LCAibG9hZGVkICVzIGZyb20gbGVnYWN5IGxvY2F0aW9uXG4iLAo+ICAJCQkJ bmV3bmFtZSk7Cj4gIAkJCWFkcmVub19ncHUtPmZ3bG9jID0gRldfTE9DQVRJT05fTEVHQUNZOwo+ IC0JCQlyZXR1cm4gZnc7Cj4gKwkJCWdvdG8gb3V0Owo+ICAJCX0gZWxzZSBpZiAoYWRyZW5vX2dw dS0+Zndsb2MgIT0gRldfTE9DQVRJT05fVU5LTk9XTikgewo+ICAJCQlkZXZfZXJyKGRybS0+ZGV2 LCAiZmFpbGVkIHRvIGxvYWQgJXM6ICVkXG4iLAo+ICAJCQkJZnduYW1lLCByZXQpOwo+IC0JCQly ZXR1cm4gRVJSX1BUUihyZXQpOwo+ICsJCQlmdyA9IEVSUl9QVFIocmV0KTsKPiArCQkJZ290byBv dXQ7Cj4gIAkJfQo+ICAJfQo+ICAKPiBAQCAtMTI2LDE2ICsxMzIsMjAgQEAgYWRyZW5vX3JlcXVl c3RfZncoc3RydWN0IGFkcmVub19ncHUgKmFkcmVub19ncHUsIGNvbnN0IGNoYXIgKmZ3bmFtZSkK PiAgCQkJZGV2X2luZm8oZHJtLT5kZXYsICJsb2FkZWQgJXMgd2l0aCBoZWxwZXJcbiIsCj4gIAkJ CQluZXduYW1lKTsKPiAgCQkJYWRyZW5vX2dwdS0+Zndsb2MgPSBGV19MT0NBVElPTl9IRUxQRVI7 Cj4gLQkJCXJldHVybiBmdzsKPiArCQkJZ290byBvdXQ7Cj4gIAkJfSBlbHNlIGlmIChhZHJlbm9f Z3B1LT5md2xvYyAhPSBGV19MT0NBVElPTl9VTktOT1dOKSB7Cj4gIAkJCWRldl9lcnIoZHJtLT5k ZXYsICJmYWlsZWQgdG8gbG9hZCAlczogJWRcbiIsCj4gIAkJCQluZXduYW1lLCByZXQpOwo+IC0J CQlyZXR1cm4gRVJSX1BUUihyZXQpOwo+ICsJCQlmdyA9IEVSUl9QVFIocmV0KTsKPiArCQkJZ290 byBvdXQ7Cj4gIAkJfQo+ICAJfQo+ICAKPiAgCWRldl9lcnIoZHJtLT5kZXYsICJmYWlsZWQgdG8g bG9hZCAlc1xuIiwgZnduYW1lKTsKPiAtCXJldHVybiBFUlJfUFRSKC1FTk9FTlQpOwo+ICsJZncg PSBFUlJfUFRSKC1FTk9FTlQpOwo+ICtvdXQ6Cj4gKwlrZnJlZShuZXduYW1lKTsKPiArCXJldHVy biBmdzsKPiAgfQo+ICAKPiAgc3RhdGljIGludCBhZHJlbm9fbG9hZF9mdyhzdHJ1Y3QgYWRyZW5v X2dwdSAqYWRyZW5vX2dwdSkKPiAtLSAKPiAyLjE3LjEKPiAKPiAKPiAtLSAKPiBLZWVzIENvb2sK PiBQaXhlbCBTZWN1cml0eQoKLS0gClRoZSBRdWFsY29tbSBJbm5vdmF0aW9uIENlbnRlciwgSW5j LiBpcyBhIG1lbWJlciBvZiBDb2RlIEF1cm9yYSBGb3J1bSwKYSBMaW51eCBGb3VuZGF0aW9uIENv bGxhYm9yYXRpdmUgUHJvamVjdApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpGcmVlZHJlbm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9m cmVlZHJlbm8K