Re: [DPU PATCH 3/3] arm64: dts: qcom: sdm845: Add dpu to sdm845 dts file

[Jordan Crouse <jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>]

On Tue, Jul 03, 2018 at 03:48:12PM -0400, Sean Paul wrote:
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 182 +++++++++++++++++++++++++++
>  1 file changed, 182 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index cdaabeb3c995..537269636b43 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -221,6 +221,188 @@
>  			#interrupt-cells = <2>;
>  		};
>  
> +		mdss: mdss@ae00000 {
> +			compatible = "qcom,dpu-mdss";
> +			reg = <0xae00000 0x1000>;
> +			reg-names = "mdss_phys";
> +
> +			power-domains = <&clock_dispcc 0>;
> +
> +			clocks = <&gcc GCC_DISP_AHB_CLK>,
> +				 <&gcc GCC_DISP_AXI_CLK>,
> +				 <&clock_dispcc DISP_CC_MDSS_MDP_CLK>;
> +			clock-names = "iface_clk", "bus_clk", "core_clk";

Rob and others have pointed out correctly that the suffix (_clk/_irq/_reg)
is not necessary nor desirable for resource names. We've been slowly trying to
turn the tide downstream but a bunch of the sdm845 code will need fixing.

<snip>

Jordan
-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno