From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: [PATCH 14/21] drm/msm: Use labels for unwinding in the error path Date: Mon, 9 Jul 2018 13:31:50 -0400 Message-ID: <20180709173200.238457-15-seanpaul@chromium.org> References: <20180709173200.238457-1-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180709173200.238457-1-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, chandanu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, ryadav-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, skolluku-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, nganji-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, hoegsberg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, dovizu-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org RnJvbTogSmV5a3VtYXIgU2Fua2FyYW4gPGpzYW5rYUBjb2RlYXVyb3JhLm9yZz4KClRoaXMgc2lt cGxpZmllcyBjbGVhbnVwLCB0byBtYWtlIHN1cmUgbm90aGluZyBkcm9wcyBvdXQgaW4gY2FzZSBv ZgplcnJvci4KClNpZ25lZC1vZmYtYnk6IEpleWt1bWFyIFNhbmthcmFuIDxqc2Fua2FAY29kZWF1 cm9yYS5vcmc+CltzZWFucGF1bCBzcGxpdCBvdXQgb2YgZHB1IG1lZ2FwYXRjaCBhbmQgcmVuYW1l ZCBsYWJlbHNdClNpZ25lZC1vZmYtYnk6IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3Jn PgotLS0KIGRyaXZlcnMvZ3B1L2RybS9tc20vbXNtX2Rydi5jIHwgNDQgKysrKysrKysrKysrKysr KystLS0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAy MiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9kcnYu YyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vbXNtX2Rydi5jCmluZGV4IDY3ODE2NTQzYTBkNy4uOGJk OWZlODMxOTY4IDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9kcnYuYworKysg Yi9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9kcnYuYwpAQCAtMzcyLDE5ICszNzIsMTYgQEAgc3Rh dGljIGludCBtc21fZHJtX2luaXQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2RyaXZl ciAqZHJ2KQogCiAJcHJpdiA9IGt6YWxsb2Moc2l6ZW9mKCpwcml2KSwgR0ZQX0tFUk5FTCk7CiAJ aWYgKCFwcml2KSB7Ci0JCWRybV9kZXZfdW5yZWYoZGRldik7Ci0JCXJldHVybiAtRU5PTUVNOwor CQlyZXQgPSAtRU5PTUVNOworCQlnb3RvIGVycl91bnJlZl9kcm1fZGV2OwogCX0KIAogCWRkZXYt PmRldl9wcml2YXRlID0gcHJpdjsKIAlwcml2LT5kZXYgPSBkZGV2OwogCiAJcmV0ID0gbWRwNV9t ZHNzX2luaXQoZGRldik7Ci0JaWYgKHJldCkgewotCQlrZnJlZShwcml2KTsKLQkJZHJtX2Rldl91 bnJlZihkZGV2KTsKLQkJcmV0dXJuIHJldDsKLQl9CisJaWYgKHJldCkKKwkJZ290byBlcnJfZnJl ZV9wcml2OwogCiAJbWRzcyA9IHByaXYtPm1kc3M7CiAKQEAgLTM5OSwxNyArMzk2LDEyIEBAIHN0 YXRpYyBpbnQgbXNtX2RybV9pbml0KHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRybV9kcml2 ZXIgKmRydikKIAogCS8qIEJpbmQgYWxsIG91ciBzdWItY29tcG9uZW50czogKi8KIAlyZXQgPSBj b21wb25lbnRfYmluZF9hbGwoZGV2LCBkZGV2KTsKLQlpZiAocmV0KSB7Ci0JCWlmIChtZHNzICYm IG1kc3MtPmZ1bmNzKQotCQkJbWRzcy0+ZnVuY3MtPmRlc3Ryb3koZGRldik7Ci0JCWtmcmVlKHBy aXYpOwotCQlkcm1fZGV2X3VucmVmKGRkZXYpOwotCQlyZXR1cm4gcmV0OwotCX0KKwlpZiAocmV0 KQorCQlnb3RvIGVycl9kZXN0cm95X21kc3M7CiAKIAlyZXQgPSBtc21faW5pdF92cmFtKGRkZXYp OwogCWlmIChyZXQpCi0JCWdvdG8gZmFpbDsKKwkJZ290byBlcnJfbXNtX3VuaW5pdDsKIAogCW1z bV9nZW1fc2hyaW5rZXJfaW5pdChkZGV2KTsKIApAQCAtNDM1LDcgKzQyNyw3IEBAIHN0YXRpYyBp bnQgbXNtX2RybV9pbml0KHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRybV9kcml2ZXIgKmRy dikKIAkJICovCiAJCWRldl9lcnIoZGV2LCAiZmFpbGVkIHRvIGxvYWQga21zXG4iKTsKIAkJcmV0 ID0gUFRSX0VSUihrbXMpOwotCQlnb3RvIGZhaWw7CisJCWdvdG8gZXJyX21zbV91bmluaXQ7CiAJ fQogCiAJLyogRW5hYmxlIG5vcm1hbGl6YXRpb24gb2YgcGxhbmUgenBvcyAqLwpAQCAtNDQ1LDcg KzQzNyw3IEBAIHN0YXRpYyBpbnQgbXNtX2RybV9pbml0KHN0cnVjdCBkZXZpY2UgKmRldiwgc3Ry dWN0IGRybV9kcml2ZXIgKmRydikKIAkJcmV0ID0ga21zLT5mdW5jcy0+aHdfaW5pdChrbXMpOwog CQlpZiAocmV0KSB7CiAJCQlkZXZfZXJyKGRldiwgImttcyBodyBpbml0IGZhaWxlZDogJWRcbiIs IHJldCk7Ci0JCQlnb3RvIGZhaWw7CisJCQlnb3RvIGVycl9tc21fdW5pbml0OwogCQl9CiAJfQog CkBAIC00NTUsNyArNDQ3LDcgQEAgc3RhdGljIGludCBtc21fZHJtX2luaXQoc3RydWN0IGRldmlj ZSAqZGV2LCBzdHJ1Y3QgZHJtX2RyaXZlciAqZHJ2KQogCXJldCA9IGRybV92YmxhbmtfaW5pdChk ZGV2LCBwcml2LT5udW1fY3J0Y3MpOwogCWlmIChyZXQgPCAwKSB7CiAJCWRldl9lcnIoZGV2LCAi ZmFpbGVkIHRvIGluaXRpYWxpemUgdmJsYW5rXG4iKTsKLQkJZ290byBmYWlsOworCQlnb3RvIGVy cl9tc21fdW5pbml0OwogCX0KIAogCWlmIChrbXMpIHsKQEAgLTQ2NCwxMyArNDU2LDEzIEBAIHN0 YXRpYyBpbnQgbXNtX2RybV9pbml0KHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRybV9kcml2 ZXIgKmRydikKIAkJcG1fcnVudGltZV9wdXRfc3luYyhkZXYpOwogCQlpZiAocmV0IDwgMCkgewog CQkJZGV2X2VycihkZXYsICJmYWlsZWQgdG8gaW5zdGFsbCBJUlEgaGFuZGxlclxuIik7Ci0JCQln b3RvIGZhaWw7CisJCQlnb3RvIGVycl9tc21fdW5pbml0OwogCQl9CiAJfQogCiAJcmV0ID0gZHJt X2Rldl9yZWdpc3RlcihkZGV2LCAwKTsKIAlpZiAocmV0KQotCQlnb3RvIGZhaWw7CisJCWdvdG8g ZXJyX21zbV91bmluaXQ7CiAKIAlkcm1fbW9kZV9jb25maWdfcmVzZXQoZGRldik7CiAKQEAgLTQ4 MSwxNSArNDczLDIzIEBAIHN0YXRpYyBpbnQgbXNtX2RybV9pbml0KHN0cnVjdCBkZXZpY2UgKmRl diwgc3RydWN0IGRybV9kcml2ZXIgKmRydikKIAogCXJldCA9IG1zbV9kZWJ1Z2ZzX2xhdGVfaW5p dChkZGV2KTsKIAlpZiAocmV0KQotCQlnb3RvIGZhaWw7CisJCWdvdG8gZXJyX21zbV91bmluaXQ7 CiAKIAlkcm1fa21zX2hlbHBlcl9wb2xsX2luaXQoZGRldik7CiAKIAlyZXR1cm4gMDsKIAotZmFp bDoKK2Vycl9tc21fdW5pbml0OgogCW1zbV9kcm1fdW5pbml0KGRldik7CiAJcmV0dXJuIHJldDsK K2Vycl9kZXN0cm95X21kc3M6CisJaWYgKG1kc3MgJiYgbWRzcy0+ZnVuY3MpCisJCW1kc3MtPmZ1 bmNzLT5kZXN0cm95KGRkZXYpOworZXJyX2ZyZWVfcHJpdjoKKwlrZnJlZShwcml2KTsKK2Vycl91 bnJlZl9kcm1fZGV2OgorCWRybV9kZXZfdW5yZWYoZGRldik7CisJcmV0dXJuIHJldDsKIH0KIAog LyoKLS0gClNlYW4gUGF1bCwgU29mdHdhcmUgRW5naW5lZXIsIEdvb2dsZSAvIENocm9taXVtIE9T CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpGcmVlZHJl bm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJlbm8K