* [PATCH] regulator: qcom-rpmh: Add stylistic breaks in the default cases
@ 2018-08-10 20:05 Douglas Anderson
2018-08-10 22:36 ` David Collins
0 siblings, 1 reply; 2+ messages in thread
From: Douglas Anderson @ 2018-08-10 20:05 UTC (permalink / raw)
To: broonie
Cc: linux-arm-msm, collinsd, Douglas Anderson, Liam Girdwood,
linux-kernel
No functional change here but it can make the code more readable to
have breaks in the "default" case even though it's the last case.
Let's add them.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/regulator/qcom-rpmh-regulator.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c
index 9f27daebd8c8..b8434e521d72 100644
--- a/drivers/regulator/qcom-rpmh-regulator.c
+++ b/drivers/regulator/qcom-rpmh-regulator.c
@@ -504,6 +504,7 @@ static unsigned int rpmh_regulator_pmic4_ldo_of_map_mode(unsigned int rpmh_mode)
break;
default:
mode = REGULATOR_MODE_INVALID;
+ break;
}
return mode;
@@ -537,6 +538,7 @@ rpmh_regulator_pmic4_smps_of_map_mode(unsigned int rpmh_mode)
break;
default:
mode = REGULATOR_MODE_INVALID;
+ break;
}
return mode;
@@ -566,6 +568,7 @@ static unsigned int rpmh_regulator_pmic4_bob_of_map_mode(unsigned int rpmh_mode)
break;
default:
mode = REGULATOR_MODE_INVALID;
+ break;
}
return mode;
--
2.18.0.597.ga71716f1ad-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: qcom-rpmh: Add stylistic breaks in the default cases
2018-08-10 20:05 [PATCH] regulator: qcom-rpmh: Add stylistic breaks in the default cases Douglas Anderson
@ 2018-08-10 22:36 ` David Collins
0 siblings, 0 replies; 2+ messages in thread
From: David Collins @ 2018-08-10 22:36 UTC (permalink / raw)
To: Douglas Anderson, broonie; +Cc: linux-arm-msm, Liam Girdwood, linux-kernel
On 08/10/2018 01:05 PM, Douglas Anderson wrote:
> No functional change here but it can make the code more readable to
> have breaks in the "default" case even though it's the last case.
> Let's add them.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> drivers/regulator/qcom-rpmh-regulator.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c
> index 9f27daebd8c8..b8434e521d72 100644
> --- a/drivers/regulator/qcom-rpmh-regulator.c
> +++ b/drivers/regulator/qcom-rpmh-regulator.c
> @@ -504,6 +504,7 @@ static unsigned int rpmh_regulator_pmic4_ldo_of_map_mode(unsigned int rpmh_mode)
> break;
> default:
> mode = REGULATOR_MODE_INVALID;
> + break;
> }
>
> return mode;
> @@ -537,6 +538,7 @@ rpmh_regulator_pmic4_smps_of_map_mode(unsigned int rpmh_mode)
> break;
> default:
> mode = REGULATOR_MODE_INVALID;
> + break;
> }
>
> return mode;
> @@ -566,6 +568,7 @@ static unsigned int rpmh_regulator_pmic4_bob_of_map_mode(unsigned int rpmh_mode)
> break;
> default:
> mode = REGULATOR_MODE_INVALID;
> + break;
> }
>
> return mode;
Reviewed-by: David Collins <collinsd@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-10 22:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-10 20:05 [PATCH] regulator: qcom-rpmh: Add stylistic breaks in the default cases Douglas Anderson
2018-08-10 22:36 ` David Collins
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).