From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v3 04/13] drm/msm/dpu: program master-slave encoders explicitly Date: Tue, 14 Aug 2018 15:19:11 -0400 Message-ID: <20180814191911.GD164269@art_vandelay> References: <1533697956-29686-1-git-send-email-jsanka@codeaurora.org> <1533697956-29686-5-git-send-email-jsanka@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1533697956-29686-5-git-send-email-jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Jeykumar Sankaran Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, hoegsberg-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gVHVlLCBBdWcgMDcsIDIwMTggYXQgMDg6MTI6MzFQTSAtMDcwMCwgSmV5a3VtYXIgU2Fua2Fy YW4gd3JvdGU6Cj4gSWRlbnRpZnkgc2xhdmUtbWFzdGVyIGVuY29kZXJzIGFuZCBwcm9ncmFtIHRo ZW0gZXhwbGljaXRseS4KCllvdSd2ZSBnb3QgdGhlIHdoYXQsIGJ1dCBjb3VsZCB5b3UgcGxlYXNl IGV4cGxhaW4gdGhlIHdoeT8KCj4gCj4gY2hhbmdlcyBpbiB2MjoKPiAJLSBub25lCj4gY2hhbmdl cyBpbiB2MzoKPiAJLSBub25lCj4gCj4gQ2hhbmdlLUlkOiBJMGViZmFkYTA1YmQ3Zjg0MzdmODQy YWQ4NjA0OTBhNjc4YWE4ZjRjZAo+IFNpZ25lZC1vZmYtYnk6IEpleWt1bWFyIFNhbmthcmFuIDxq c2Fua2FAY29kZWF1cm9yYS5vcmc+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9k cHUxL2RwdV9lbmNvZGVyLmMgfCAzOSArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLQo+ICAx IGZpbGUgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9lbmNvZGVyLmMgYi9k cml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5jb2Rlci5jCj4gaW5kZXggMWI0ZGUz NC4uYTBjZWQ3OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9k cHVfZW5jb2Rlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2Vu Y29kZXIuYwo+IEBAIC0xODQsNiArMTg0LDcgQEAgc3RydWN0IGRwdV9lbmNvZGVyX3ZpcnQgewo+ ICAJdW5zaWduZWQgaW50IG51bV9waHlzX2VuY3M7Cj4gIAlzdHJ1Y3QgZHB1X2VuY29kZXJfcGh5 cyAqcGh5c19lbmNzW01BWF9QSFlTX0VOQ09ERVJTX1BFUl9WSVJUVUFMXTsKPiAgCXN0cnVjdCBk cHVfZW5jb2Rlcl9waHlzICpjdXJfbWFzdGVyOwo+ICsJc3RydWN0IGRwdV9lbmNvZGVyX3BoeXMg KmN1cl9zbGF2ZTsKCllvdSBvbmx5IHVzZSB0aGlzIGluIG9uZSBmdW5jdGlvbiwgd2h5IG5vdCBq dXN0IG1ha2UgaXQgYSBsb2NhbD8KCj4gIAlzdHJ1Y3QgZHB1X2h3X3Bpbmdwb25nICpod19wcFtN QVhfQ0hBTk5FTFNfUEVSX0VOQ107Cj4gIAo+ICAJYm9vbCBpbnRmc19zd2FwcGVkOwo+IEBAIC0x MTUzLDYgKzExNTQsNyBAQCB2b2lkIGRwdV9lbmNvZGVyX3ZpcnRfcmVzdG9yZShzdHJ1Y3QgZHJt X2VuY29kZXIgKmRybV9lbmMpCj4gIHN0YXRpYyB2b2lkIGRwdV9lbmNvZGVyX3ZpcnRfZW5hYmxl KHN0cnVjdCBkcm1fZW5jb2RlciAqZHJtX2VuYykKPiAgewo+ICAJc3RydWN0IGRwdV9lbmNvZGVy X3ZpcnQgKmRwdV9lbmMgPSBOVUxMOwo+ICsJc3RydWN0IGRwdV9lbmNvZGVyX3BoeXMgKnBoeXMg ID0gTlVMTDsKPiAgCWludCBpLCByZXQgPSAwOwo+ICAJc3RydWN0IGRybV9kaXNwbGF5X21vZGUg KmN1cl9tb2RlID0gTlVMTDsKPiAgCj4gQEAgLTExNjAsNiArMTE2Miw3IEBAIHN0YXRpYyB2b2lk IGRwdV9lbmNvZGVyX3ZpcnRfZW5hYmxlKHN0cnVjdCBkcm1fZW5jb2RlciAqZHJtX2VuYykKPiAg CQlEUFVfRVJST1IoImludmFsaWQgZW5jb2RlclxuIik7Cj4gIAkJcmV0dXJuOwo+ICAJfQo+ICsK PiAgCWRwdV9lbmMgPSB0b19kcHVfZW5jb2Rlcl92aXJ0KGRybV9lbmMpOwo+ICAJY3VyX21vZGUg PSAmZHB1X2VuYy0+YmFzZS5jcnRjLT5zdGF0ZS0+YWRqdXN0ZWRfbW9kZTsKPiAgCj4gQEAgLTEx NjcsMjEgKzExNzAsMzYgQEAgc3RhdGljIHZvaWQgZHB1X2VuY29kZXJfdmlydF9lbmFibGUoc3Ry dWN0IGRybV9lbmNvZGVyICpkcm1fZW5jKQo+ICAJCQkgICAgIGN1cl9tb2RlLT52ZGlzcGxheSk7 Cj4gIAo+ICAJZHB1X2VuYy0+Y3VyX21hc3RlciA9IE5VTEw7Cj4gKwlkcHVfZW5jLT5jdXJfc2xh dmUgPSBOVUxMOwoKVGhlcmUncyBubyBiZW5lZml0IHRvIHNldHRpbmcgdGhpcyBOVUxMLiBjdXJf bWFzdGVyIGlzIHNldCB0byBOVUxMIHNvIGl0IGNhbiBiZQpjaGVja2VkIGFmdGVyIHRoZSBsb29w LiBTaW5jZSB5b3UncmUgbm90IGNoZWNraW5nIHRoaXMsIGl0J3Mgbm90IG5lY2Vzc2FyeS4KCkkg c3VwcG9zZSB5b3UgbWlnaHQgYWxzbyB3YW50IHRvIGNsZWFyIHRoaXMgb24gZGlzYWJsZSBsaWtl IG1hc3Rlci4KCj4gIAlmb3IgKGkgPSAwOyBpIDwgZHB1X2VuYy0+bnVtX3BoeXNfZW5jczsgaSsr KSB7Cj4gLQkJc3RydWN0IGRwdV9lbmNvZGVyX3BoeXMgKnBoeXMgPSBkcHVfZW5jLT5waHlzX2Vu Y3NbaV07Cj4gKwkJcGh5cyA9IGRwdV9lbmMtPnBoeXNfZW5jc1tpXTsKPiArCj4gKwkJaWYgKCFw aHlzIHx8ICFwaHlzLT5vcHMuaXNfbWFzdGVyKQoKSSBkb24ndCB0aGluayBpdCdzIHBvc3NpYmxl IGZvciBwaHlzIHRvIGJlIE5VTEwsIGlzIGl0PwoKPiArCQkJY29udGludWU7Cj4gIAo+IC0JCWlm IChwaHlzICYmIHBoeXMtPm9wcy5pc19tYXN0ZXIgJiYgcGh5cy0+b3BzLmlzX21hc3RlcihwaHlz KSkgewo+IC0JCQlEUFVfREVCVUdfRU5DKGRwdV9lbmMsICJtYXN0ZXIgaXMgbm93IGlkeCAlZFxu IiwgaSk7Cj4gKwkJaWYgKHBoeXMtPm9wcy5pc19tYXN0ZXIocGh5cykpIHsKPiArCQkJRFBVX0RF QlVHX0VOQyhkcHVfZW5jLCAibWFzdGVyIGlzIGF0IGlkeCAlZFxuIiwgaSk7Cj4gIAkJCWRwdV9l bmMtPmN1cl9tYXN0ZXIgPSBwaHlzOwo+IC0JCQlicmVhazsKPiArCQl9IGVsc2Ugewo+ICsJCQlE UFVfREVCVUdfRU5DKGRwdV9lbmMsICJzbGF2ZSBpcyBhdCBpZHggJWRcbiIsIGkpOwo+ICsJCQlk cHVfZW5jLT5jdXJfc2xhdmUgPSBwaHlzOwo+ICAJCX0KCllvdSdyZSBtYWtpbmcgYW4gYXNzdW1w dGlvbiBoZXJlIHRoYXQgdGhlcmUgY2FuIG9ubHkgYmUgb25lIG1hc3RlciBhbmQgdGhlcmUgY2Fu Cm9ubHkgYmUgb25lIHNsYXZlLgoKSXQgc2VlbXMgbGlrZSB5b3UgY291bGQgYXZvaWQgYWxsIG9m IHRoaXMgd29yayBpZiB5b3UganVzdCBkaWQgdGhlIGFzc2lnbm1lbnQgaW4KZHB1X2VuY29kZXJf dmlydF9hZGRfcGh5c19lbmNzKCkuCgo+ICAJfQo+ICAKPiAgCWlmICghZHB1X2VuYy0+Y3VyX21h c3Rlcikgewo+IC0JCURQVV9FUlJPUigidmlydCBlbmNvZGVyIGhhcyBubyBtYXN0ZXIhIG51bV9w aHlzICVkXG4iLCBpKTsKPiArCQlEUFVfRVJST1IoInZpcnQgZW5jb2RlciBoYXMgbm8gbWFzdGVy IGlkZW50aWZpZWRcbiIpOwo+ICAJCXJldHVybjsKPiAgCX0KPiAgCj4gKwkvKiBhbHdheXMgZW5h YmxlIHNsYXZlIGVuY29kZXIgYmVmb3JlIG1hc3RlciAqLwo+ICsJcGh5cyA9IGRwdV9lbmMtPmN1 cl9zbGF2ZTsKPiArCWlmIChwaHlzICYmIHBoeXMtPm9wcy5lbmFibGUpCj4gKwkJcGh5cy0+b3Bz LmVuYWJsZShwaHlzKTsKPiArCj4gKwlwaHlzID0gZHB1X2VuYy0+Y3VyX21hc3RlcjsKPiArCWlm IChwaHlzICYmIHBoeXMtPm9wcy5lbmFibGUpCj4gKwkJcGh5cy0+b3BzLmVuYWJsZShwaHlzKTsK PiArCj4gIAlyZXQgPSBkcHVfZW5jb2Rlcl9yZXNvdXJjZV9jb250cm9sKGRybV9lbmMsIERQVV9F TkNfUkNfRVZFTlRfS0lDS09GRik7Cj4gIAlpZiAocmV0KSB7Cj4gIAkJRFBVX0VSUk9SX0VOQyhk cHVfZW5jLCAiZHB1IHJlc291cmNlIGNvbnRyb2wgZmFpbGVkOiAlZFxuIiwKPiBAQCAtMTE5MCwy NSArMTIwOCwxNiBAQCBzdGF0aWMgdm9pZCBkcHVfZW5jb2Rlcl92aXJ0X2VuYWJsZShzdHJ1Y3Qg ZHJtX2VuY29kZXIgKmRybV9lbmMpCj4gIAl9Cj4gIAo+ICAJZm9yIChpID0gMDsgaSA8IGRwdV9l bmMtPm51bV9waHlzX2VuY3M7IGkrKykgewo+IC0JCXN0cnVjdCBkcHVfZW5jb2Rlcl9waHlzICpw aHlzID0gZHB1X2VuYy0+cGh5c19lbmNzW2ldOwo+IC0KPiArCQlwaHlzID0gZHB1X2VuYy0+cGh5 c19lbmNzW2ldOwo+ICAJCWlmICghcGh5cykKPiAgCQkJY29udGludWU7Cj4gIAo+IC0JCWlmIChw aHlzICE9IGRwdV9lbmMtPmN1cl9tYXN0ZXIpIHsKPiAtCQkJaWYgKHBoeXMtPm9wcy5lbmFibGUp Cj4gLQkJCQlwaHlzLT5vcHMuZW5hYmxlKHBoeXMpOwo+IC0JCX0KPiAtCj4gIAkJaWYgKGRwdV9l bmMtPm1pc3JfZW5hYmxlICYmIChkcHVfZW5jLT5kaXNwX2luZm8uY2FwYWJpbGl0aWVzICYKPiAg CQkgICAgIE1TTV9ESVNQTEFZX0NBUF9WSURfTU9ERSkgJiYgcGh5cy0+b3BzLnNldHVwX21pc3Ip Cj4gIAkJCXBoeXMtPm9wcy5zZXR1cF9taXNyKHBoeXMsIHRydWUsCj4gIAkJCQkJCWRwdV9lbmMt Pm1pc3JfZnJhbWVfY291bnQpOwo+ICAJfQo+ICAKPiAtCWlmIChkcHVfZW5jLT5jdXJfbWFzdGVy LT5vcHMuZW5hYmxlKQo+IC0JCWRwdV9lbmMtPmN1cl9tYXN0ZXItPm9wcy5lbmFibGUoZHB1X2Vu Yy0+Y3VyX21hc3Rlcik7Cj4gLQoKVGhlcmUncyBhIGNoYW5nZSBpbiBmdW5jdGlvbmFsaXR5IGhl cmUuIFByZXZpb3VzbHkgeW91IGNvdWxkIGNhbGwgc2V0dXBfbWlzcgpmb3Igc2xhdmVzIGFmdGVy IHRoZXkgYXJlIGVuYWJsZWQsIGJ1dCBiZWZvcmUgbWFzdGVyIGlzIGVuYWJsZWQuIE5vdyB5b3Un cmUKY2FsbGluZyBpdCBhZnRlciBhbGwgYXJlIGVuYWJsZWQuCgpJJ20gZ3Vlc3NpbmcgaXQgZG9l c24ndCBtYXR0ZXIgc2luY2UgaXQgd2FzIHByZXZpb3VzbHkgY2FsbGVkIG9uIG1hc3RlciBiZWZv cmUKaXQgd2FzIGVuYWJsZWQsIGJ1dCBJIGZpZ3VyZSBJJ2QgcG9pbnQgdGhpcyBvdXQuCgpTZWFu Cgo+ICAJX2RwdV9lbmNvZGVyX3ZpcnRfZW5hYmxlX2hlbHBlcihkcm1fZW5jKTsKPiAgfQo+ICAK PiAtLSAKPiBUaGUgUXVhbGNvbW0gSW5ub3ZhdGlvbiBDZW50ZXIsIEluYy4gaXMgYSBtZW1iZXIg b2YgdGhlIENvZGUgQXVyb3JhIEZvcnVtLAo+IGEgTGludXggRm91bmRhdGlvbiBDb2xsYWJvcmF0 aXZlIFByb2plY3QKPiAKCi0tIApTZWFuIFBhdWwsIFNvZnR3YXJlIEVuZ2luZWVyLCBHb29nbGUg LyBDaHJvbWl1bSBPUwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpGcmVlZHJlbm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJl bm8K