From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v3 07/13] drm/msm/dpu: avoid querying for hw intf before assignment Date: Tue, 14 Aug 2018 15:37:13 -0400 Message-ID: <20180814193713.GG164269@art_vandelay> References: <1533697956-29686-1-git-send-email-jsanka@codeaurora.org> <1533697956-29686-8-git-send-email-jsanka@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1533697956-29686-8-git-send-email-jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Jeykumar Sankaran Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, hoegsberg-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gVHVlLCBBdWcgMDcsIDIwMTggYXQgMDg6MTI6MzRQTSAtMDcwMCwgSmV5a3VtYXIgU2Fua2Fy YW4gd3JvdGU6Cj4gaHcgaW50ZiBibG9ja3MgYXJlIG5lZWRlZCBvbmx5IGR1cmluZyBlbmNvZGVy IGVuYWJsZSB0byBwcm9ncmFtCj4gdGltaW5nIGVuZ2luZXMoZm9yIHZpZGVvIHBhbmVscykuIGVu Y29kZXItPmVuYWJsZSBpcyB0cmlnZ2VyZWQKPiBvbmx5IGFmdGVyIGF0b21pY19tb2Rlc2V0IGF0 IHdoaWNoIHBvaW50IHdlIGFzc2lnbiB0aGUKPiByZXNvdXJjZXMgZm9yIHRoZSBkaXNwbGF5IHBp cGVsaW5lLiBUaGlzIHBhdGNoIGRlZmVycyB0aGUKPiBod19pbnRmIGxvb2stdXAgdW50aWwgZW5j b2RlciBlbmFibGUuCgpJJ20gc3VyZSB0aGVyZSdzIGEgZ29vZCByZWFzb24gZm9yIHRoaXMsIGJ1 dCB5b3UgaGF2ZW4ndCBzdGF0ZWQgaXQuIEFzIGEgY2FzdWFsCnJlYWRlciBvZiB0aGUgcGF0Y2gs IEknZCBiZSBpbmNsaW5lZCB0byBwcmVmZXIgZG9pbmcgd29yayBvbmx5IG9uY2UgYXQgaW5pdCB2 cwpldmVyeXRpbWUgd2UgZW5hYmxlLgoKPiAKPiBjaGFuZ2VzIGluIHYyOgo+IAktIG5vbmUKPiBj aGFuZ2VzIGluIHYzOgo+IAktIG5vbmUKPiAKPiBDaGFuZ2UtSWQ6IEliMGEyMjUzNDMxNDY4MTUx MzU1ZTUwY2JhZDdiOTFlMmI3N2I2ZTU0Cj4gU2lnbmVkLW9mZi1ieTogSmV5a3VtYXIgU2Fua2Fy YW4gPGpzYW5rYUBjb2RlYXVyb3JhLm9yZz4KPiAtLS0KPiAgLi4uL2dwdS9kcm0vbXNtL2Rpc3Av ZHB1MS9kcHVfZW5jb2Rlcl9waHlzX3ZpZC5jICAgfCA1MyArKysrKysrLS0tLS0tLS0tLS0tLS0t Cj4gIDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAzNyBkZWxldGlvbnMoLSkKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2VuY29kZXJf cGh5c192aWQuYyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9lbmNvZGVyX3Bo eXNfdmlkLmMKPiBpbmRleCBjMDIyMWNjLi5hMGIzNzQ0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9lbmNvZGVyX3BoeXNfdmlkLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5jb2Rlcl9waHlzX3ZpZC5jCj4gQEAgLTQ2 Miw3ICs0NjIsNyBAQCBzdGF0aWMgdm9pZCBkcHVfZW5jb2Rlcl9waHlzX3ZpZF9lbmFibGUoc3Ry dWN0IGRwdV9lbmNvZGVyX3BoeXMgKnBoeXNfZW5jKQo+ICB7Cj4gIAlzdHJ1Y3QgbXNtX2RybV9w cml2YXRlICpwcml2Owo+ICAJc3RydWN0IGRwdV9lbmNvZGVyX3BoeXNfdmlkICp2aWRfZW5jOwo+ IC0Jc3RydWN0IGRwdV9od19pbnRmICppbnRmOwo+ICsJc3RydWN0IGRwdV9ybV9od19pdGVyIGl0 ZXI7Cj4gIAlzdHJ1Y3QgZHB1X2h3X2N0bCAqY3RsOwo+ICAJdTMyIGZsdXNoX21hc2sgPSAwOwo+ ICAKPiBAQCAtNDc0LDExICs0NzQsMjAgQEAgc3RhdGljIHZvaWQgZHB1X2VuY29kZXJfcGh5c192 aWRfZW5hYmxlKHN0cnVjdCBkcHVfZW5jb2Rlcl9waHlzICpwaHlzX2VuYykKPiAgCXByaXYgPSBw aHlzX2VuYy0+cGFyZW50LT5kZXYtPmRldl9wcml2YXRlOwo+ICAKPiAgCXZpZF9lbmMgPSB0b19k cHVfZW5jb2Rlcl9waHlzX3ZpZChwaHlzX2VuYyk7Cj4gLQlpbnRmID0gdmlkX2VuYy0+aHdfaW50 ZjsKPiAgCWN0bCA9IHBoeXNfZW5jLT5od19jdGw7Cj4gLQlpZiAoIXZpZF9lbmMtPmh3X2ludGYg fHwgIXBoeXNfZW5jLT5od19jdGwpIHsKPiAtCQlEUFVfRVJST1IoImludmFsaWQgaHdfaW50ZiAl ZCBod19jdGwgJWRcbiIsCj4gLQkJCQl2aWRfZW5jLT5od19pbnRmICE9IDAsIHBoeXNfZW5jLT5o d19jdGwgIT0gMCk7Cj4gKwo+ICsJZHB1X3JtX2luaXRfaHdfaXRlcigmaXRlciwgcGh5c19lbmMt PnBhcmVudC0+YmFzZS5pZCwgRFBVX0hXX0JMS19JTlRGKTsKPiArCXdoaWxlIChkcHVfcm1fZ2V0 X2h3KCZwaHlzX2VuYy0+ZHB1X2ttcy0+cm0sICZpdGVyKSkgewo+ICsJCXN0cnVjdCBkcHVfaHdf aW50ZiAqaHdfaW50ZiA9IChzdHJ1Y3QgZHB1X2h3X2ludGYgKilpdGVyLmh3Owo+ICsKPiArCQlp ZiAoaHdfaW50Zi0+aWR4ID09IHBoeXNfZW5jLT5pbnRmX2lkeCkgewo+ICsJCQl2aWRfZW5jLT5o d19pbnRmID0gaHdfaW50ZjsKPiArCQkJYnJlYWs7Cj4gKwkJfQo+ICsJfQo+ICsKPiArCWlmICgh dmlkX2VuYy0+aHdfaW50Zikgewo+ICsJCURQVV9FUlJPUigiaHdfaW50ZiBub3QgYXNzaWduZWRc biIpOwo+ICAJCXJldHVybjsKPiAgCX0KPiAgCj4gQEAgLTUwMCw3ICs1MDksNyBAQCBzdGF0aWMg dm9pZCBkcHVfZW5jb2Rlcl9waHlzX3ZpZF9lbmFibGUoc3RydWN0IGRwdV9lbmNvZGVyX3BoeXMg KnBoeXNfZW5jKQo+ICAJCSFkcHVfZW5jb2Rlcl9waHlzX3ZpZF9pc19tYXN0ZXIocGh5c19lbmMp KQo+ICAJCWdvdG8gc2tpcF9mbHVzaDsKPiAgCj4gLQljdGwtPm9wcy5nZXRfYml0bWFza19pbnRm KGN0bCwgJmZsdXNoX21hc2ssIGludGYtPmlkeCk7Cj4gKwljdGwtPm9wcy5nZXRfYml0bWFza19p bnRmKGN0bCwgJmZsdXNoX21hc2ssIHZpZF9lbmMtPmh3X2ludGYtPmlkeCk7Cj4gIAljdGwtPm9w cy51cGRhdGVfcGVuZGluZ19mbHVzaChjdGwsIGZsdXNoX21hc2spOwo+ICAKPiAgc2tpcF9mbHVz aDoKPiBAQCAtNTMxLDIyICs1NDAsMTMgQEAgc3RhdGljIHZvaWQgZHB1X2VuY29kZXJfcGh5c192 aWRfZ2V0X2h3X3Jlc291cmNlcygKPiAgCQlzdHJ1Y3QgZHB1X2VuY29kZXJfaHdfcmVzb3VyY2Vz ICpod19yZXMsCj4gIAkJc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGUpCj4g IHsKPiAtCXN0cnVjdCBkcHVfZW5jb2Rlcl9waHlzX3ZpZCAqdmlkX2VuYzsKPiAtCj4gIAlpZiAo IXBoeXNfZW5jIHx8ICFod19yZXMpIHsKPiAgCQlEUFVfRVJST1IoImludmFsaWQgYXJnKHMpLCBl bmMgJWQgaHdfcmVzICVkIGNvbm5fc3RhdGUgJWRcbiIsCj4gIAkJCQlwaHlzX2VuYyAhPSAwLCBo d19yZXMgIT0gMCwgY29ubl9zdGF0ZSAhPSAwKTsKPiAgCQlyZXR1cm47Cj4gIAl9Cj4gIAo+IC0J dmlkX2VuYyA9IHRvX2RwdV9lbmNvZGVyX3BoeXNfdmlkKHBoeXNfZW5jKTsKPiAtCWlmICghdmlk X2VuYy0+aHdfaW50Zikgewo+IC0JCURQVV9FUlJPUigiaW52YWxpZCBhcmcocyksIGh3X2ludGZc biIpOwo+IC0JCXJldHVybjsKPiAtCX0KPiAtCj4gLQlEUFVfREVCVUdfVklERU5DKHZpZF9lbmMs ICJcbiIpOwo+IC0JaHdfcmVzLT5pbnRmc1t2aWRfZW5jLT5od19pbnRmLT5pZHggLSBJTlRGXzBd ID0gSU5URl9NT0RFX1ZJREVPOwo+ICsJaHdfcmVzLT5pbnRmc1twaHlzX2VuYy0+aW50Zl9pZHgg LSBJTlRGXzBdID0gSU5URl9NT0RFX1ZJREVPOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50IF9kcHVf ZW5jb2Rlcl9waHlzX3ZpZF93YWl0X2Zvcl92YmxhbmsoCj4gQEAgLTgwOSw3ICs4MDksNiBAQCBz dHJ1Y3QgZHB1X2VuY29kZXJfcGh5cyAqZHB1X2VuY29kZXJfcGh5c192aWRfaW5pdCgKPiAgewo+ ICAJc3RydWN0IGRwdV9lbmNvZGVyX3BoeXMgKnBoeXNfZW5jID0gTlVMTDsKPiAgCXN0cnVjdCBk cHVfZW5jb2Rlcl9waHlzX3ZpZCAqdmlkX2VuYyA9IE5VTEw7Cj4gLQlzdHJ1Y3QgZHB1X3JtX2h3 X2l0ZXIgaXRlcjsKPiAgCXN0cnVjdCBkcHVfZW5jb2Rlcl9pcnEgKmlycTsKPiAgCWludCBpLCBy ZXQgPSAwOwo+ICAKPiBAQCAtODI5LDI2ICs4MjgsNiBAQCBzdHJ1Y3QgZHB1X2VuY29kZXJfcGh5 cyAqZHB1X2VuY29kZXJfcGh5c192aWRfaW5pdCgKPiAgCXBoeXNfZW5jLT5od19tZHB0b3AgPSBw LT5kcHVfa21zLT5od19tZHA7Cj4gIAlwaHlzX2VuYy0+aW50Zl9pZHggPSBwLT5pbnRmX2lkeDsK PiAgCj4gLQkvKioKPiAtCSAqIGh3X2ludGYgcmVzb3VyY2UgcGVybWFuZW50bHkgYXNzaWduZWQg dG8gdGhpcyBlbmNvZGVyCj4gLQkgKiBPdGhlciByZXNvdXJjZXMgYWxsb2NhdGVkIGF0IGF0b21p YyBjb21taXQgdGltZSBieSB1c2UgY2FzZQo+IC0JICovCj4gLQlkcHVfcm1faW5pdF9od19pdGVy KCZpdGVyLCAwLCBEUFVfSFdfQkxLX0lOVEYpOwo+IC0Jd2hpbGUgKGRwdV9ybV9nZXRfaHcoJnAt PmRwdV9rbXMtPnJtLCAmaXRlcikpIHsKPiAtCQlzdHJ1Y3QgZHB1X2h3X2ludGYgKmh3X2ludGYg PSAoc3RydWN0IGRwdV9od19pbnRmICopaXRlci5odzsKPiAtCj4gLQkJaWYgKGh3X2ludGYtPmlk eCA9PSBwLT5pbnRmX2lkeCkgewo+IC0JCQl2aWRfZW5jLT5od19pbnRmID0gaHdfaW50ZjsKPiAt CQkJYnJlYWs7Cj4gLQkJfQo+IC0JfQo+IC0KPiAtCWlmICghdmlkX2VuYy0+aHdfaW50Zikgewo+ IC0JCXJldCA9IC1FSU5WQUw7Cj4gLQkJRFBVX0VSUk9SKCJmYWlsZWQgdG8gZ2V0IGh3X2ludGZc biIpOwo+IC0JCWdvdG8gZmFpbDsKPiAtCX0KPiAtCj4gIAlEUFVfREVCVUdfVklERU5DKHZpZF9l bmMsICJcbiIpOwo+ICAKPiAgCWRwdV9lbmNvZGVyX3BoeXNfdmlkX2luaXRfb3BzKCZwaHlzX2Vu Yy0+b3BzKTsKPiAtLSAKPiBUaGUgUXVhbGNvbW0gSW5ub3ZhdGlvbiBDZW50ZXIsIEluYy4gaXMg YSBtZW1iZXIgb2YgdGhlIENvZGUgQXVyb3JhIEZvcnVtLAo+IGEgTGludXggRm91bmRhdGlvbiBD b2xsYWJvcmF0aXZlIFByb2plY3QKPiAKCi0tIApTZWFuIFBhdWwsIFNvZnR3YXJlIEVuZ2luZWVy LCBHb29nbGUgLyBDaHJvbWl1bSBPUwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpGcmVlZHJlbm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9mcmVlZHJlbm8K