* [PATCH] drm: Convert to using %pOFn instead of device_node.name [not found] ` <20180828015252.28511-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> @ 2018-08-28 1:52 ` Rob Herring 2018-08-28 12:54 ` Maarten Lankhorst 2018-08-28 15:04 ` Rob Clark 0 siblings, 2 replies; 4+ messages in thread From: Rob Herring @ 2018-08-28 1:52 UTC (permalink / raw) To: linux-kernel-u79uwXL29TY76Z2rM5mHXA Cc: freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, David Airlie, Gustavo Padovan, Maarten Lankhorst, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Rob Clark, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA, Sean Paul In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Cc: Gustavo Padovan <gustavo@padovan.org> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Sean Paul <sean@poorly.run> Cc: David Airlie <airlied@linux.ie> Cc: Rob Clark <robdclark@gmail.com> Cc: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/gpu/drm/drm_modes.c | 4 ++-- drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index 02db9ac82d7a..24a750436559 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c @@ -716,8 +716,8 @@ int of_get_drm_display_mode(struct device_node *np, if (bus_flags) drm_bus_flags_from_videomode(&vm, bus_flags); - pr_debug("%pOF: got %dx%d display mode from %s\n", - np, vm.hactive, vm.vactive, np->name); + pr_debug("%pOF: got %dx%d display mode\n", + np, vm.hactive, vm.vactive); drm_mode_debug_printmodeline(dmode); return 0; diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c index c79659ca5706..23670907a29d 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c @@ -579,7 +579,7 @@ static int msm_hdmi_bind(struct device *dev, struct device *master, void *data) hdmi_cfg = (struct hdmi_platform_config *) of_device_get_match_data(dev); if (!hdmi_cfg) { - dev_err(dev, "unknown hdmi_cfg: %s\n", of_node->name); + dev_err(dev, "unknown hdmi_cfg: %pOFn\n", of_node); return -ENXIO; } -- 2.17.1 _______________________________________________ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: Convert to using %pOFn instead of device_node.name 2018-08-28 1:52 ` [PATCH] drm: Convert to using %pOFn instead of device_node.name Rob Herring @ 2018-08-28 12:54 ` Maarten Lankhorst [not found] ` <597b1b06-e1fb-dcf1-67f4-d6685fd38cad-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> 2018-08-28 15:04 ` Rob Clark 1 sibling, 1 reply; 4+ messages in thread From: Maarten Lankhorst @ 2018-08-28 12:54 UTC (permalink / raw) To: Rob Herring, linux-kernel Cc: freedreno, David Airlie, dri-devel, linux-arm-msm, Sean Paul Op 28-08-18 om 03:52 schreef Rob Herring: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Gustavo Padovan <gustavo@padovan.org> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Sean Paul <sean@poorly.run> > Cc: David Airlie <airlied@linux.ie> > Cc: Rob Clark <robdclark@gmail.com> > Cc: dri-devel@lists.freedesktop.org > Cc: linux-arm-msm@vger.kernel.org > Cc: freedreno@lists.freedesktop.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/gpu/drm/drm_modes.c | 4 ++-- > drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > index 02db9ac82d7a..24a750436559 100644 > --- a/drivers/gpu/drm/drm_modes.c > +++ b/drivers/gpu/drm/drm_modes.c > @@ -716,8 +716,8 @@ int of_get_drm_display_mode(struct device_node *np, > if (bus_flags) > drm_bus_flags_from_videomode(&vm, bus_flags); > > - pr_debug("%pOF: got %dx%d display mode from %s\n", > - np, vm.hactive, vm.vactive, np->name); > + pr_debug("%pOF: got %dx%d display mode\n", > + np, vm.hactive, vm.vactive); Aren't you removing it here instead of converting? ~Maarten > drm_mode_debug_printmodeline(dmode); > > return 0; > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c > index c79659ca5706..23670907a29d 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c > @@ -579,7 +579,7 @@ static int msm_hdmi_bind(struct device *dev, struct device *master, void *data) > hdmi_cfg = (struct hdmi_platform_config *) > of_device_get_match_data(dev); > if (!hdmi_cfg) { > - dev_err(dev, "unknown hdmi_cfg: %s\n", of_node->name); > + dev_err(dev, "unknown hdmi_cfg: %pOFn\n", of_node); > return -ENXIO; > } > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <597b1b06-e1fb-dcf1-67f4-d6685fd38cad-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>]
* Re: [PATCH] drm: Convert to using %pOFn instead of device_node.name [not found] ` <597b1b06-e1fb-dcf1-67f4-d6685fd38cad-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> @ 2018-08-28 15:04 ` Rob Herring 0 siblings, 0 replies; 4+ messages in thread From: Rob Herring @ 2018-08-28 15:04 UTC (permalink / raw) To: Maarten Lankhorst Cc: freedreno, David Airlie, Gustavo Padovan, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel, Rob Clark, linux-arm-msm, Sean Paul On Tue, Aug 28, 2018 at 7:54 AM Maarten Lankhorst <maarten.lankhorst@linux.intel.com> wrote: > > Op 28-08-18 om 03:52 schreef Rob Herring: > > In preparation to remove the node name pointer from struct device_node, > > convert printf users to use the %pOFn format specifier. > > > > Cc: Gustavo Padovan <gustavo@padovan.org> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Cc: Sean Paul <sean@poorly.run> > > Cc: David Airlie <airlied@linux.ie> > > Cc: Rob Clark <robdclark@gmail.com> > > Cc: dri-devel@lists.freedesktop.org > > Cc: linux-arm-msm@vger.kernel.org > > Cc: freedreno@lists.freedesktop.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > drivers/gpu/drm/drm_modes.c | 4 ++-- > > drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > > index 02db9ac82d7a..24a750436559 100644 > > --- a/drivers/gpu/drm/drm_modes.c > > +++ b/drivers/gpu/drm/drm_modes.c > > @@ -716,8 +716,8 @@ int of_get_drm_display_mode(struct device_node *np, > > if (bus_flags) > > drm_bus_flags_from_videomode(&vm, bus_flags); > > > > - pr_debug("%pOF: got %dx%d display mode from %s\n", > > - np, vm.hactive, vm.vactive, np->name); > > + pr_debug("%pOF: got %dx%d display mode\n", > > + np, vm.hactive, vm.vactive); > Aren't you removing it here instead of converting? Well, yes. The full path and name are already printed so the node name alone was pretty redundant. Rob _______________________________________________ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: Convert to using %pOFn instead of device_node.name 2018-08-28 1:52 ` [PATCH] drm: Convert to using %pOFn instead of device_node.name Rob Herring 2018-08-28 12:54 ` Maarten Lankhorst @ 2018-08-28 15:04 ` Rob Clark 1 sibling, 0 replies; 4+ messages in thread From: Rob Clark @ 2018-08-28 15:04 UTC (permalink / raw) To: Rob Herring Cc: Linux Kernel Mailing List, Gustavo Padovan, Maarten Lankhorst, sean, David Airlie, dri-devel, linux-arm-msm, freedreno On Mon, Aug 27, 2018 at 9:53 PM Rob Herring <robh@kernel.org> wrote: > > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Gustavo Padovan <gustavo@padovan.org> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Sean Paul <sean@poorly.run> > Cc: David Airlie <airlied@linux.ie> > Cc: Rob Clark <robdclark@gmail.com> > Cc: dri-devel@lists.freedesktop.org > Cc: linux-arm-msm@vger.kernel.org > Cc: freedreno@lists.freedesktop.org > Signed-off-by: Rob Herring <robh@kernel.org> for msm part, Acked-by: Rob Clark <robdclark@gmail.com> (for drm_modes part, I guess there is no harm removing the redundant name) BR, -R > --- > drivers/gpu/drm/drm_modes.c | 4 ++-- > drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > index 02db9ac82d7a..24a750436559 100644 > --- a/drivers/gpu/drm/drm_modes.c > +++ b/drivers/gpu/drm/drm_modes.c > @@ -716,8 +716,8 @@ int of_get_drm_display_mode(struct device_node *np, > if (bus_flags) > drm_bus_flags_from_videomode(&vm, bus_flags); > > - pr_debug("%pOF: got %dx%d display mode from %s\n", > - np, vm.hactive, vm.vactive, np->name); > + pr_debug("%pOF: got %dx%d display mode\n", > + np, vm.hactive, vm.vactive); > drm_mode_debug_printmodeline(dmode); > > return 0; > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c > index c79659ca5706..23670907a29d 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c > @@ -579,7 +579,7 @@ static int msm_hdmi_bind(struct device *dev, struct device *master, void *data) > hdmi_cfg = (struct hdmi_platform_config *) > of_device_get_match_data(dev); > if (!hdmi_cfg) { > - dev_err(dev, "unknown hdmi_cfg: %s\n", of_node->name); > + dev_err(dev, "unknown hdmi_cfg: %pOFn\n", of_node); > return -ENXIO; > } > > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-28 15:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180828015252.28511-1-robh@kernel.org>
[not found] ` <20180828015252.28511-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-08-28 1:52 ` [PATCH] drm: Convert to using %pOFn instead of device_node.name Rob Herring
2018-08-28 12:54 ` Maarten Lankhorst
[not found] ` <597b1b06-e1fb-dcf1-67f4-d6685fd38cad-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-08-28 15:04 ` Rob Herring
2018-08-28 15:04 ` Rob Clark
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).