From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH 08/14] drm/msm/dpu: avoid querying for hw intf before assignment Date: Thu, 30 Aug 2018 12:39:40 -0400 Message-ID: <20180830163940.GK188300@art_vandelay> References: <1535503203-22054-1-git-send-email-jsanka@codeaurora.org> <1535503203-22054-9-git-send-email-jsanka@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1535503203-22054-9-git-send-email-jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Jeykumar Sankaran Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, hoegsberg-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gVHVlLCBBdWcgMjgsIDIwMTggYXQgMDU6Mzk6NTdQTSAtMDcwMCwgSmV5a3VtYXIgU2Fua2Fy YW4gd3JvdGU6Cj4gUmVzb3VyY2UgbWFuYWdlciBhc3NpZ25zIGh3X2ludGYgYmxvY2tzIGZvciB0 aGUgZW5jb2RlciBvbmx5IG9uCj4gbW9kZXNldC4gSWYgcXVlcmllZCBmb3IgaHdfaW50ZiBvYmpl Y3RzIGR1cmluZyBpbml0LCBpdCB3aWxsIGJlCj4gTlVMTC4gU2luY2UgaHdfaW50ZiBvYmplY3Rz IGFyZSBuZWVkZWQgb25seSBkdXJpbmcgZW5jb2RlciBlbmFibGUsCgpzL2R1cmluZy9hZnRlci8g aXQgbG9va3MgbGlrZSB5b3UgbmVlZCBpdCBvbiBkaXNhYmxlIGFzIHdlbGwuCgo+IGRlZmVyIHRo ZSBxdWVyeSB0byBlbmNvZGVyIGVuYWJsZSB3aGljaCB3aWxsIGJlIHRyaWdnZXJlZCBhZnRlcgo+ IG1vZGVzZXQuCj4gCgpNaXNzaW5nIGNoYW5nZWxvZyBhZ2Fpbi4KCldpdGggdGhhdCwKClJldmll d2VkLWJ5OiBTZWFuIFBhdWwgPHNlYW5wYXVsQGNocm9taXVtLm9yZz4KCgo+IFNpZ25lZC1vZmYt Ynk6IEpleWt1bWFyIFNhbmthcmFuIDxqc2Fua2FAY29kZWF1cm9yYS5vcmc+Cj4gLS0tCj4gIC4u Li9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2VuY29kZXJfcGh5c192aWQuYyAgIHwgNTMgKysr KysrKy0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwg MzcgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlz cC9kcHUxL2RwdV9lbmNvZGVyX3BoeXNfdmlkLmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3Av ZHB1MS9kcHVfZW5jb2Rlcl9waHlzX3ZpZC5jCj4gaW5kZXggY2EwOTYzYy4uNmRlMTNmNCAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5jb2Rlcl9waHlz X3ZpZC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2VuY29kZXJf cGh5c192aWQuYwo+IEBAIC00NjIsNyArNDYyLDcgQEAgc3RhdGljIHZvaWQgZHB1X2VuY29kZXJf cGh5c192aWRfZW5hYmxlKHN0cnVjdCBkcHVfZW5jb2Rlcl9waHlzICpwaHlzX2VuYykKPiAgewo+ ICAJc3RydWN0IG1zbV9kcm1fcHJpdmF0ZSAqcHJpdjsKPiAgCXN0cnVjdCBkcHVfZW5jb2Rlcl9w aHlzX3ZpZCAqdmlkX2VuYzsKPiAtCXN0cnVjdCBkcHVfaHdfaW50ZiAqaW50ZjsKPiArCXN0cnVj dCBkcHVfcm1faHdfaXRlciBpdGVyOwo+ICAJc3RydWN0IGRwdV9od19jdGwgKmN0bDsKPiAgCXUz MiBmbHVzaF9tYXNrID0gMDsKPiAgCj4gQEAgLTQ3NCwxMSArNDc0LDIwIEBAIHN0YXRpYyB2b2lk IGRwdV9lbmNvZGVyX3BoeXNfdmlkX2VuYWJsZShzdHJ1Y3QgZHB1X2VuY29kZXJfcGh5cyAqcGh5 c19lbmMpCj4gIAlwcml2ID0gcGh5c19lbmMtPnBhcmVudC0+ZGV2LT5kZXZfcHJpdmF0ZTsKPiAg Cj4gIAl2aWRfZW5jID0gdG9fZHB1X2VuY29kZXJfcGh5c192aWQocGh5c19lbmMpOwo+IC0JaW50 ZiA9IHZpZF9lbmMtPmh3X2ludGY7Cj4gIAljdGwgPSBwaHlzX2VuYy0+aHdfY3RsOwo+IC0JaWYg KCF2aWRfZW5jLT5od19pbnRmIHx8ICFwaHlzX2VuYy0+aHdfY3RsKSB7Cj4gLQkJRFBVX0VSUk9S KCJpbnZhbGlkIGh3X2ludGYgJWQgaHdfY3RsICVkXG4iLAo+IC0JCQkJdmlkX2VuYy0+aHdfaW50 ZiAhPSAwLCBwaHlzX2VuYy0+aHdfY3RsICE9IDApOwo+ICsKPiArCWRwdV9ybV9pbml0X2h3X2l0 ZXIoJml0ZXIsIHBoeXNfZW5jLT5wYXJlbnQtPmJhc2UuaWQsIERQVV9IV19CTEtfSU5URik7Cj4g Kwl3aGlsZSAoZHB1X3JtX2dldF9odygmcGh5c19lbmMtPmRwdV9rbXMtPnJtLCAmaXRlcikpIHsK PiArCQlzdHJ1Y3QgZHB1X2h3X2ludGYgKmh3X2ludGYgPSAoc3RydWN0IGRwdV9od19pbnRmICop aXRlci5odzsKPiArCj4gKwkJaWYgKGh3X2ludGYtPmlkeCA9PSBwaHlzX2VuYy0+aW50Zl9pZHgp IHsKPiArCQkJdmlkX2VuYy0+aHdfaW50ZiA9IGh3X2ludGY7Cj4gKwkJCWJyZWFrOwo+ICsJCX0K PiArCX0KPiArCj4gKwlpZiAoIXZpZF9lbmMtPmh3X2ludGYpIHsKPiArCQlEUFVfRVJST1IoImh3 X2ludGYgbm90IGFzc2lnbmVkXG4iKTsKPiAgCQlyZXR1cm47Cj4gIAl9Cj4gIAo+IEBAIC01MDAs NyArNTA5LDcgQEAgc3RhdGljIHZvaWQgZHB1X2VuY29kZXJfcGh5c192aWRfZW5hYmxlKHN0cnVj dCBkcHVfZW5jb2Rlcl9waHlzICpwaHlzX2VuYykKPiAgCQkhZHB1X2VuY29kZXJfcGh5c192aWRf aXNfbWFzdGVyKHBoeXNfZW5jKSkKPiAgCQlnb3RvIHNraXBfZmx1c2g7Cj4gIAo+IC0JY3RsLT5v cHMuZ2V0X2JpdG1hc2tfaW50ZihjdGwsICZmbHVzaF9tYXNrLCBpbnRmLT5pZHgpOwo+ICsJY3Rs LT5vcHMuZ2V0X2JpdG1hc2tfaW50ZihjdGwsICZmbHVzaF9tYXNrLCB2aWRfZW5jLT5od19pbnRm LT5pZHgpOwo+ICAJY3RsLT5vcHMudXBkYXRlX3BlbmRpbmdfZmx1c2goY3RsLCBmbHVzaF9tYXNr KTsKPiAgCj4gIHNraXBfZmx1c2g6Cj4gQEAgLTUzMSwyMiArNTQwLDEzIEBAIHN0YXRpYyB2b2lk IGRwdV9lbmNvZGVyX3BoeXNfdmlkX2dldF9od19yZXNvdXJjZXMoCj4gIAkJc3RydWN0IGRwdV9l bmNvZGVyX2h3X3Jlc291cmNlcyAqaHdfcmVzLAo+ICAJCXN0cnVjdCBkcm1fY29ubmVjdG9yX3N0 YXRlICpjb25uX3N0YXRlKQo+ICB7Cj4gLQlzdHJ1Y3QgZHB1X2VuY29kZXJfcGh5c192aWQgKnZp ZF9lbmM7Cj4gLQo+ICAJaWYgKCFwaHlzX2VuYyB8fCAhaHdfcmVzKSB7Cj4gIAkJRFBVX0VSUk9S KCJpbnZhbGlkIGFyZyhzKSwgZW5jICVkIGh3X3JlcyAlZCBjb25uX3N0YXRlICVkXG4iLAo+ICAJ CQkJcGh5c19lbmMgIT0gMCwgaHdfcmVzICE9IDAsIGNvbm5fc3RhdGUgIT0gMCk7Cj4gIAkJcmV0 dXJuOwo+ICAJfQo+ICAKPiAtCXZpZF9lbmMgPSB0b19kcHVfZW5jb2Rlcl9waHlzX3ZpZChwaHlz X2VuYyk7Cj4gLQlpZiAoIXZpZF9lbmMtPmh3X2ludGYpIHsKPiAtCQlEUFVfRVJST1IoImludmFs aWQgYXJnKHMpLCBod19pbnRmXG4iKTsKPiAtCQlyZXR1cm47Cj4gLQl9Cj4gLQo+IC0JRFBVX0RF QlVHX1ZJREVOQyh2aWRfZW5jLCAiXG4iKTsKPiAtCWh3X3Jlcy0+aW50ZnNbdmlkX2VuYy0+aHdf aW50Zi0+aWR4IC0gSU5URl8wXSA9IElOVEZfTU9ERV9WSURFTzsKPiArCWh3X3Jlcy0+aW50ZnNb cGh5c19lbmMtPmludGZfaWR4IC0gSU5URl8wXSA9IElOVEZfTU9ERV9WSURFTzsKPiAgfQo+ICAK PiAgc3RhdGljIGludCBfZHB1X2VuY29kZXJfcGh5c192aWRfd2FpdF9mb3JfdmJsYW5rKAo+IEBA IC03ODEsNyArNzgxLDYgQEAgc3RydWN0IGRwdV9lbmNvZGVyX3BoeXMgKmRwdV9lbmNvZGVyX3Bo eXNfdmlkX2luaXQoCj4gIHsKPiAgCXN0cnVjdCBkcHVfZW5jb2Rlcl9waHlzICpwaHlzX2VuYyA9 IE5VTEw7Cj4gIAlzdHJ1Y3QgZHB1X2VuY29kZXJfcGh5c192aWQgKnZpZF9lbmMgPSBOVUxMOwo+ IC0Jc3RydWN0IGRwdV9ybV9od19pdGVyIGl0ZXI7Cj4gIAlzdHJ1Y3QgZHB1X2VuY29kZXJfaXJx ICppcnE7Cj4gIAlpbnQgaSwgcmV0ID0gMDsKPiAgCj4gQEAgLTgwMSwyNiArODAwLDYgQEAgc3Ry dWN0IGRwdV9lbmNvZGVyX3BoeXMgKmRwdV9lbmNvZGVyX3BoeXNfdmlkX2luaXQoCj4gIAlwaHlz X2VuYy0+aHdfbWRwdG9wID0gcC0+ZHB1X2ttcy0+aHdfbWRwOwo+ICAJcGh5c19lbmMtPmludGZf aWR4ID0gcC0+aW50Zl9pZHg7Cj4gIAo+IC0JLyoqCj4gLQkgKiBod19pbnRmIHJlc291cmNlIHBl cm1hbmVudGx5IGFzc2lnbmVkIHRvIHRoaXMgZW5jb2Rlcgo+IC0JICogT3RoZXIgcmVzb3VyY2Vz IGFsbG9jYXRlZCBhdCBhdG9taWMgY29tbWl0IHRpbWUgYnkgdXNlIGNhc2UKPiAtCSAqLwo+IC0J ZHB1X3JtX2luaXRfaHdfaXRlcigmaXRlciwgMCwgRFBVX0hXX0JMS19JTlRGKTsKPiAtCXdoaWxl IChkcHVfcm1fZ2V0X2h3KCZwLT5kcHVfa21zLT5ybSwgJml0ZXIpKSB7Cj4gLQkJc3RydWN0IGRw dV9od19pbnRmICpod19pbnRmID0gKHN0cnVjdCBkcHVfaHdfaW50ZiAqKWl0ZXIuaHc7Cj4gLQo+ IC0JCWlmIChod19pbnRmLT5pZHggPT0gcC0+aW50Zl9pZHgpIHsKPiAtCQkJdmlkX2VuYy0+aHdf aW50ZiA9IGh3X2ludGY7Cj4gLQkJCWJyZWFrOwo+IC0JCX0KPiAtCX0KPiAtCj4gLQlpZiAoIXZp ZF9lbmMtPmh3X2ludGYpIHsKPiAtCQlyZXQgPSAtRUlOVkFMOwo+IC0JCURQVV9FUlJPUigiZmFp bGVkIHRvIGdldCBod19pbnRmXG4iKTsKPiAtCQlnb3RvIGZhaWw7Cj4gLQl9Cj4gLQo+ICAJRFBV X0RFQlVHX1ZJREVOQyh2aWRfZW5jLCAiXG4iKTsKPiAgCj4gIAlkcHVfZW5jb2Rlcl9waHlzX3Zp ZF9pbml0X29wcygmcGh5c19lbmMtPm9wcyk7Cj4gLS0gCj4gVGhlIFF1YWxjb21tIElubm92YXRp b24gQ2VudGVyLCBJbmMuIGlzIGEgbWVtYmVyIG9mIHRoZSBDb2RlIEF1cm9yYSBGb3J1bSwKPiBh IExpbnV4IEZvdW5kYXRpb24gQ29sbGFib3JhdGl2ZSBQcm9qZWN0Cj4gCgotLSAKU2VhbiBQYXVs LCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hyb21pdW0gT1MKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KRnJlZWRyZW5vIG1haWxpbmcgbGlzdApG cmVlZHJlbm9AbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZnJlZWRyZW5vCg==