From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Niklas Cassel <niklas.cassel@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 7/9] soc: qcom: wcnss_ctrl: Avoid string overflow
Date: Mon, 3 Sep 2018 12:22:02 -0700 [thread overview]
Message-ID: <20180903192202.GB3456@tuxbook-pro> (raw)
In-Reply-To: <20180829075724.9095-8-niklas.cassel@linaro.org>
On Wed 29 Aug 00:57 PDT 2018, Niklas Cassel wrote:
> 'chinfo.name' is used as a NUL-terminated string, but using strncpy() with
> the length equal to the buffer size may result in lack of the termination:
>
> drivers//soc/qcom/wcnss_ctrl.c: In function 'qcom_wcnss_open_channel':
> drivers//soc/qcom/wcnss_ctrl.c:284:2: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation]
> strncpy(chinfo.name, name, sizeof(chinfo.name));
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> This changes it to use the safer strscpy() instead.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/soc/qcom/wcnss_ctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/wcnss_ctrl.c b/drivers/soc/qcom/wcnss_ctrl.c
> index df3ccb30bc2d..373400dd816d 100644
> --- a/drivers/soc/qcom/wcnss_ctrl.c
> +++ b/drivers/soc/qcom/wcnss_ctrl.c
> @@ -281,7 +281,7 @@ struct rpmsg_endpoint *qcom_wcnss_open_channel(void *wcnss, const char *name, rp
> struct rpmsg_channel_info chinfo;
> struct wcnss_ctrl *_wcnss = wcnss;
>
> - strncpy(chinfo.name, name, sizeof(chinfo.name));
> + strscpy(chinfo.name, name, sizeof(chinfo.name));
> chinfo.src = RPMSG_ADDR_ANY;
> chinfo.dst = RPMSG_ADDR_ANY;
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2018-09-03 19:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 7:57 [PATCH v6 0/9] soc: qcom: Allow COMPILE_TEST of qcom SoC Kconfigs Niklas Cassel
2018-08-29 7:57 ` [PATCH v6 1/9] soc: qcom: smem: Add missing include of sizes.h Niklas Cassel
2018-08-29 7:57 ` [PATCH v6 2/9] soc: qcom: llcc-slice: " Niklas Cassel
2018-08-29 7:57 ` [PATCH v6 3/9] soc: qcom: smp2p: Add select IRQ_DOMAIN Niklas Cassel
2018-08-29 7:57 ` [PATCH v6 4/9] soc: qcom: smsm: " Niklas Cassel
2018-08-29 7:57 ` [PATCH v6 5/9] soc: qcom: Remove bogus depends on OF from QCOM_SMD_RPM Niklas Cassel
2018-08-29 7:57 ` [PATCH v6 6/9] soc: qcom: Remove depends on OF from QCOM_RPMH Niklas Cassel
2018-09-03 19:24 ` Bjorn Andersson
2018-08-29 7:57 ` [PATCH v6 7/9] soc: qcom: wcnss_ctrl: Avoid string overflow Niklas Cassel
2018-09-03 19:22 ` Bjorn Andersson [this message]
2018-08-29 7:57 ` [PATCH v6 8/9] soc: qcom: apr: " Niklas Cassel
2018-09-03 19:24 ` Bjorn Andersson
2018-08-29 7:57 ` [PATCH v6 9/9] soc: qcom: Allow COMPILE_TEST of qcom SoC Kconfigs Niklas Cassel
2018-09-03 19:25 ` Bjorn Andersson
2018-09-13 21:38 ` [PATCH v6 0/9] " Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180903192202.GB3456@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).