linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthias Kaehlcke <mka@chromium.org>
To: Doug Anderson <dianders@chromium.org>
Cc: kbuild test robot <lkp@intel.com>,
	kbuild-all@01.org, Andy Gross <andy.gross@linaro.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Girish Mahadevan <girishm@codeaurora.org>,
	Dilip Kota <dkota@codeaurora.org>,
	Evan Green <evgreen@chromium.org>,
	Stephen Boyd <swboyd@chromium.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
	David Brown <david.brown@linaro.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] soc: qcom: geni: Don't ignore clk_round_rate() errors in geni_se_clk_tbl_get()
Date: Thu, 6 Sep 2018 15:40:32 -0700	[thread overview]
Message-ID: <20180906224032.GF22824@google.com> (raw)
In-Reply-To: <CAD=FV=W=qcLijE3bUm7SO+cwWzno8SeiYM9zQz+vkipbpafNmg@mail.gmail.com>

On Thu, Sep 06, 2018 at 03:39:04PM -0700, Doug Anderson wrote:
> Hi
> 
> On Thu, Sep 6, 2018 at 3:35 PM, kbuild test robot <lkp@intel.com> wrote:
> > Hi Douglas,
> >
> > Thank you for the patch! Perhaps something to improve:
> >
> > [auto build test WARNING on agross/for-next]
> > [also build test WARNING on v4.19-rc2 next-20180906]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> >
> > url:    https://github.com/0day-ci/linux/commits/Douglas-Anderson/soc-qcom-geni-Don-t-ignore-clk_round_rate-errors-in-geni_se_clk_tbl_get/20180907-045155
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git for-next
> > config: i386-allmodconfig (attached as .config)
> > compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> > reproduce:
> >         # save the attached .config to linux build tree
> >         make ARCH=i386
> >
> > Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
> > http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
> >
> > All warnings (new ones prefixed by >>):
> >
> >    drivers/soc/qcom/qcom-geni-se.c: In function 'geni_se_clk_tbl_get':
> >>> drivers/soc/qcom/qcom-geni-se.c:531:39: warning: 'freq' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >       freq = clk_round_rate(se->clk, freq + 1);
> >                                      ~~~~~^~~
> 
> Oh crud.  Yeah.  ...so v1 was right after all.  :(

Sorry about the misguided suggestion :/

      reply	other threads:[~2018-09-06 22:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-06 16:32 [PATCH v2 1/2] soc: qcom: geni: Don't ignore clk_round_rate() errors in geni_se_clk_tbl_get() Douglas Anderson
2018-09-06 16:32 ` [PATCH v2 2/2] soc: qcom: geni: geni_se_clk_freq_match() should always accept multiples Douglas Anderson
2018-09-06 22:35 ` [PATCH v2 1/2] soc: qcom: geni: Don't ignore clk_round_rate() errors in geni_se_clk_tbl_get() kbuild test robot
2018-09-06 22:39   ` Doug Anderson
2018-09-06 22:40     ` Matthias Kaehlcke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180906224032.GF22824@google.com \
    --to=mka@chromium.org \
    --cc=andy.gross@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=dianders@chromium.org \
    --cc=dkota@codeaurora.org \
    --cc=evgreen@chromium.org \
    --cc=girishm@codeaurora.org \
    --cc=kbuild-all@01.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).