From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: frowand.list@gmail.com
Cc: Andy Gross <andy.gross@linaro.org>,
Arun Kumar Neelakantam <aneela@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] ARM: qcom_defconfig: Enable MAILBOX
Date: Fri, 7 Sep 2018 09:51:19 -0700 [thread overview]
Message-ID: <20180907165119.GD3286@tuxbook-pro> (raw)
In-Reply-To: <1536295488-12296-1-git-send-email-frowand.list@gmail.com>
On Thu 06 Sep 21:44 PDT 2018, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> Problem:
> ab460a2e72da ("rpmsg: qcom_smd: Access APCS through mailbox framework"
> added a "depends on MAILBOX") to RPMSG_QCOM_SMD, thus RPMSG_QCOM_SMD
> becomes unset since MAILBOX was not enabled in qcom_defconfig and is
> not otherwise selected for the dragonboard. When the resulting
> kernel is booted the mmc device which contains the root file system
> is not available.
>
> Fix:
> add CONFIG_MAILBOX to qcom_defconfig
>
> Fixes: ab460a2e72da ("rpmsg: qcom_smd: Access APCS through mailbox framework"
> added a "depends on MAILBOX")
>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> Bjorn suggested that multi_v7_defconfig might need this same fix
> but I don't have a target to test on so I have not included that
> change in this patch
>
multi_v7_defconfig should boot on 8974 as well, but I would not be a
surprise if there are other things missing there.
Regards,
Bjorn
> Tested on Qualcomm APQ8074 Dragonboard
>
> arch/arm/configs/qcom_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig
> index 6aa7046fb91f..bd6440f23493 100644
> --- a/arch/arm/configs/qcom_defconfig
> +++ b/arch/arm/configs/qcom_defconfig
> @@ -207,6 +207,7 @@ CONFIG_MSM_MMCC_8974=y
> CONFIG_MSM_IOMMU=y
> CONFIG_HWSPINLOCK=y
> CONFIG_HWSPINLOCK_QCOM=y
> +CONFIG_MAILBOX=y
> CONFIG_REMOTEPROC=y
> CONFIG_QCOM_ADSP_PIL=y
> CONFIG_QCOM_Q6V5_PIL=y
> --
> Frank Rowand <frank.rowand@sony.com>
>
prev parent reply other threads:[~2018-09-07 16:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 4:44 [PATCH] ARM: qcom_defconfig: Enable MAILBOX frowand.list
2018-09-07 16:51 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907165119.GD3286@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=aneela@codeaurora.org \
--cc=frowand.list@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).