From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH 2/7] drm/msm: dpu: Move atomic_check_plane_state() call to atomic_check Date: Wed, 12 Sep 2018 09:39:33 -0400 Message-ID: <20180912133933.GK188300@art_vandelay> References: <20180911201550.210810-1-sean@poorly.run> <20180911201550.210810-2-sean@poorly.run> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Jeykumar Sankaran Cc: Sean Paul , abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Rob Clark , Sean Paul , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gVHVlLCBTZXAgMTEsIDIwMTggYXQgMDM6NDQ6NDhQTSAtMDcwMCwgSmV5a3VtYXIgU2Fua2Fy YW4gd3JvdGU6Cj4gT24gMjAxOC0wOS0xMSAxMzoxNSwgU2VhbiBQYXVsIHdyb3RlOgo+ID4gRnJv bTogU2VhbiBQYXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+Cj4gPiAKPiA+IHNyYy9kc3QgcmVj dHMgYXJlIGNoZWNrZWQgaW4gYm90aCBhdG9taWNfY2hlY2sgYW5kIGF0b21pY191cGRhdGUsIHdp dGgKPiA+IHRoZSBtb3JlIGNvbXByZWhlbnNpdmUgY2hlY2sgb2NjdXJyaW5nIGluIGF0b21pY191 cGRhdGUsIHdoaWNoIGlzCj4gPiBiYWNrd2FyZHMuIFNvIGNvbnNvbG9kYXRlIHRoZSBjaGVja3Mg aW4gYXRvbWljX2NoZWNrLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBTZWFuIFBhdWwgPHNlYW5w YXVsQGNocm9taXVtLm9yZz4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9k cHUxL2RwdV9wbGFuZS5jIHwgNTYgKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KPiA+ICAxIGZpbGUg Y2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgNDAgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfcGxhbmUuYwo+ID4gYi9k cml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfcGxhbmUuYwo+ID4gaW5kZXggMGY0Mjhm NjZiOTUxLi44NTM5MDJhYzRmYjkgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNt L2Rpc3AvZHB1MS9kcHVfcGxhbmUuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNw L2RwdTEvZHB1X3BsYW5lLmMKPiA+IEBAIC0xMDc5LDEzICsxMDc5LDI2IEBAIHN0YXRpYyBib29s IGRwdV9wbGFuZV92YWxpZGF0ZV9zcmMoc3RydWN0Cj4gPiBkcm1fcmVjdAo+ID4gKnNyYywKPiA+ ICBzdGF0aWMgaW50IGRwdV9wbGFuZV9zc3BwX2F0b21pY19jaGVjayhzdHJ1Y3QgZHJtX3BsYW5l ICpwbGFuZSwKPiA+ICAJCXN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnN0YXRlKQo+ID4gIHsKPiA+ IC0JaW50IHJldCA9IDA7Cj4gPiArCWludCByZXQgPSAwLCBtaW5fc2NhbGU7Cj4gPiAgCXN0cnVj dCBkcHVfcGxhbmUgKnBkcHUgPSB0b19kcHVfcGxhbmUocGxhbmUpOwo+ID4gKwljb25zdCBzdHJ1 Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGUgPSBOVUxMOwo+ID4gIAljb25zdCBzdHJ1Y3Qg ZHB1X2Zvcm1hdCAqZm10Owo+ID4gIAlzdHJ1Y3QgZHJtX3JlY3Qgc3JjLCBkc3QsIGZiX3JlY3Qg PSB7IDAgfTsKPiA+IC0JdWludDMyX3QgbWF4X3Vwc2NhbGUgPSAxLCBtYXhfZG93bnNjYWxlID0g MTsKPiA+ICAJdWludDMyX3QgbWluX3NyY19zaXplLCBtYXhfbGluZXdpZHRoOwo+ID4gLQlpbnQg aHNjYWxlID0gMSwgdnNjYWxlID0gMTsKPiA+ICsKPiA+ICsJaWYgKHN0YXRlLT5jcnRjKQo+ID4g KwkJY3J0Y19zdGF0ZSA9IHN0YXRlLT5jcnRjLT5zdGF0ZTsKPiBJc24ndCB0aGUgY3J0Y19zdGF0 ZSByZXRyaWV2ZWQgaGVyZSB0aGUgb2xkIGNydGMgc3RhdGU/IFNpbmNlIHRoZSBwbGFuZQo+IGNo ZWNrIGlzIGNhbGxlZCBiZWZvcmUgc3dhcCwgdGhlIENSVEMgc3RhdGUKPiBmb3IgdGhpcyBjb21t aXQgc2hvdWxkIGJlIHJldHJpZXZlZCBmcm9tIGdsb2JhbCBhdG9taWMgc3RhdGUgc3RhdGUtPnN0 YXRlCj4gdXNpbmcgZHJtX2F0b21pY19nZXRfZXhpc3RpbmdfY3J0Y19zdGF0ZS4KClllcCwgbmlj ZSBjYXRjaC4gSSdsbCBzZW5kIGEgdjIgdXNpbmcgZHJtX2F0b21pY19nZXRfbmV3X2NydGNfc3Rh dGUuCgpTZWFuCgo+IAo+IEpleWt1bWFyIFMuCj4gPiArCj4gPiArCW1pbl9zY2FsZSA9IEZSQUNf MTZfMTYoMSwgcGRwdS0+cGlwZV9zYmxrLT5tYXhkd25zY2FsZSk7Cj4gPiArCXJldCA9IGRybV9h dG9taWNfaGVscGVyX2NoZWNrX3BsYW5lX3N0YXRlKHN0YXRlLCBjcnRjX3N0YXRlLAo+ID4gbWlu X3NjYWxlLAo+ID4gKwkJCQkJICBwZHB1LT5waXBlX3NibGstPm1heHVwc2NhbGUgPDwKPiA+IDE2 LAo+ID4gKwkJCQkJICB0cnVlLCB0cnVlKTsKPiA+ICsJaWYgKHJldCkgewo+ID4gKwkJRFBVX0VS Uk9SX1BMQU5FKHBkcHUsICJDaGVjayBwbGFuZSBzdGF0ZSBmYWlsZWQgKCVkKVxuIiwKPiA+IHJl dCk7Cj4gPiArCQlyZXR1cm4gcmV0Owo+ID4gKwl9Cj4gPiArCWlmICghc3RhdGUtPnZpc2libGUp Cj4gPiArCQlyZXR1cm4gMDsKPiA+IAo+ID4gIAlzcmMueDEgPSBzdGF0ZS0+c3JjX3ggPj4gMTY7 Cj4gPiAgCXNyYy55MSA9IHN0YXRlLT5zcmNfeSA+PiAxNjsKPiA+IEBAIC0xMDk5LDI1ICsxMTEy LDYgQEAgc3RhdGljIGludCBkcHVfcGxhbmVfc3NwcF9hdG9taWNfY2hlY2soc3RydWN0Cj4gPiBk cm1fcGxhbmUgKnBsYW5lLAo+ID4gCj4gPiAgCW1heF9saW5ld2lkdGggPSBwZHB1LT5waXBlX3Ni bGstPmNvbW1vbi0+bWF4bGluZXdpZHRoOwo+ID4gCj4gPiAtCWlmIChwZHB1LT5mZWF0dXJlcyAm IERQVV9TU1BQX1NDQUxFUikgewo+ID4gLQkJbWF4X2Rvd25zY2FsZSA9IHBkcHUtPnBpcGVfc2Js ay0+bWF4ZHduc2NhbGU7Cj4gPiAtCQltYXhfdXBzY2FsZSA9IHBkcHUtPnBpcGVfc2Jsay0+bWF4 dXBzY2FsZTsKPiA+IC0JfQo+ID4gLQlpZiAoZHJtX3JlY3Rfd2lkdGgoJnNyYykgPCBkcm1fcmVj dF93aWR0aCgmZHN0KSkKPiA+IC0JCWhzY2FsZSA9IGRybV9yZWN0X2NhbGNfaHNjYWxlKCZzcmMs ICZkc3QsIDEsIG1heF91cHNjYWxlKTsKPiA+IC0JZWxzZQo+ID4gLQkJaHNjYWxlID0gZHJtX3Jl Y3RfY2FsY19oc2NhbGUoJmRzdCwgJnNyYywgMSwKPiA+IG1heF9kb3duc2NhbGUpOwo+ID4gLQlp ZiAoZHJtX3JlY3RfaGVpZ2h0KCZzcmMpIDwgZHJtX3JlY3RfaGVpZ2h0KCZkc3QpKQo+ID4gLQkJ dnNjYWxlID0gZHJtX3JlY3RfY2FsY192c2NhbGUoJnNyYywgJmRzdCwgMSwgbWF4X3Vwc2NhbGUp Owo+ID4gLQllbHNlCj4gPiAtCQl2c2NhbGUgPSBkcm1fcmVjdF9jYWxjX3ZzY2FsZSgmZHN0LCAm c3JjLCAxLAo+ID4gbWF4X2Rvd25zY2FsZSk7Cj4gPiAtCj4gPiAtCURQVV9ERUJVR19QTEFORShw ZHB1LCAiY2hlY2sgJWQgLT4gJWRcbiIsCj4gPiAtCQlkcHVfcGxhbmVfZW5hYmxlZChwbGFuZS0+ c3RhdGUpLAo+ID4gZHB1X3BsYW5lX2VuYWJsZWQoc3RhdGUpKTsKPiA+IC0KPiA+IC0JaWYgKCFk cHVfcGxhbmVfZW5hYmxlZChzdGF0ZSkpCj4gPiAtCQlnb3RvIGV4aXQ7Cj4gPiAtCj4gPiAgCWZt dCA9IHRvX2RwdV9mb3JtYXQobXNtX2ZyYW1lYnVmZmVyX2Zvcm1hdChzdGF0ZS0+ZmIpKTsKPiA+ IAo+ID4gIAltaW5fc3JjX3NpemUgPSBEUFVfRk9STUFUX0lTX1lVVihmbXQpID8gMiA6IDE7Cj4g PiBAQCAtMTE1NiwxNiArMTE1MCw4IEBAIHN0YXRpYyBpbnQgZHB1X3BsYW5lX3NzcHBfYXRvbWlj X2NoZWNrKHN0cnVjdAo+ID4gZHJtX3BsYW5lICpwbGFuZSwKPiA+ICAJCURQVV9FUlJPUl9QTEFO RShwZHB1LCAiaW52YWxpZCBzcmMgIiBEUk1fUkVDVF9GTVQgIgo+ID4gbGluZToldVxuIiwKPiA+ ICAJCQkJRFJNX1JFQ1RfQVJHKCZzcmMpLCBtYXhfbGluZXdpZHRoKTsKPiA+ICAJCXJldCA9IC1F MkJJRzsKPiA+IC0KPiA+IC0JLyogY2hlY2sgc2NhbGVyIGNhcGFiaWxpdHkgKi8KPiA+IC0JfSBl bHNlIGlmIChoc2NhbGUgPCAwIHx8IHZzY2FsZSA8IDApIHsKPiA+IC0JCURQVV9FUlJPUl9QTEFO RShwZHB1LCAiaW52YWxpZCBzY2FsaW5nIHJlcXVlc3RlZCBzcmM9Igo+ID4gLQkJCQlEUk1fUkVD VF9GTVQgIiBkc3Q9IiBEUk1fUkVDVF9GTVQgIlxuIiwKPiA+IC0JCQkJRFJNX1JFQ1RfQVJHKCZz cmMpLCBEUk1fUkVDVF9BUkcoJmRzdCkpOwo+ID4gLQkJcmV0ID0gLUUyQklHOwo+ID4gIAl9Cj4g PiAKPiA+IC1leGl0Ogo+ID4gIAlyZXR1cm4gcmV0Owo+ID4gIH0KPiA+IAo+ID4gQEAgLTEyMzcs NyArMTIyMyw2IEBAIHN0YXRpYyBpbnQgZHB1X3BsYW5lX3NzcHBfYXRvbWljX3VwZGF0ZShzdHJ1 Y3QKPiA+IGRybV9wbGFuZSAqcGxhbmUsCj4gPiAgCWNvbnN0IHN0cnVjdCBkcHVfZm9ybWF0ICpm bXQ7Cj4gPiAgCXN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPiA+ICAJc3RydWN0IGRybV9mcmFtZWJ1 ZmZlciAqZmI7Cj4gPiAtCWludCByZXQsIG1pbl9zY2FsZTsKPiA+IAo+ID4gIAlpZiAoIXBsYW5l KSB7Cj4gPiAgCQlEUFVfRVJST1IoImludmFsaWQgcGxhbmVcbiIpOwo+ID4gQEAgLTEyNzYsMTUg KzEyNjEsNiBAQCBzdGF0aWMgaW50IGRwdV9wbGFuZV9zc3BwX2F0b21pY191cGRhdGUoc3RydWN0 Cj4gPiBkcm1fcGxhbmUgKnBsYW5lLAo+ID4gIAlwZHB1LT5pc19ydF9waXBlID0gKGRwdV9jcnRj X2dldF9jbGllbnRfdHlwZShjcnRjKSAhPSBOUlRfQ0xJRU5UKTsKPiA+ICAJX2RwdV9wbGFuZV9z ZXRfcW9zX2N0cmwocGxhbmUsIGZhbHNlLCBEUFVfUExBTkVfUU9TX1BBTklDX0NUUkwpOwo+ID4g Cj4gPiAtCW1pbl9zY2FsZSA9IEZSQUNfMTZfMTYoMSwgcGRwdS0+cGlwZV9zYmxrLT5tYXhkd25z Y2FsZSk7Cj4gPiAtCXJldCA9IGRybV9hdG9taWNfaGVscGVyX2NoZWNrX3BsYW5lX3N0YXRlKHN0 YXRlLCBjcnRjLT5zdGF0ZSwKPiA+IG1pbl9zY2FsZSwKPiA+IC0JCQkJCSAgcGRwdS0+cGlwZV9z YmxrLT5tYXh1cHNjYWxlIDw8Cj4gPiAxNiwKPiA+IC0JCQkJCSAgdHJ1ZSwgZmFsc2UpOwo+ID4g LQlpZiAocmV0KSB7Cj4gPiAtCQlEUFVfRVJST1JfUExBTkUocGRwdSwgIkNoZWNrIHBsYW5lIHN0 YXRlIGZhaWxlZCAoJWQpXG4iLAo+ID4gcmV0KTsKPiA+IC0JCXJldHVybiByZXQ7Cj4gPiAtCX0K PiA+IC0KPiA+ICAJRFBVX0RFQlVHX1BMQU5FKHBkcHUsICJGQlsldV0gIiBEUk1fUkVDVF9GUF9G TVQgIi0+Y3J0YyV1ICIKPiA+IERSTV9SRUNUX0ZNVAo+ID4gIAkJCSIsICU0LjRzIHVid2MgJWRc biIsIGZiLT5iYXNlLmlkLAo+ID4gRFJNX1JFQ1RfRlBfQVJHKCZzdGF0ZS0+c3JjKSwKPiA+ICAJ CQljcnRjLT5iYXNlLmlkLCBEUk1fUkVDVF9BUkcoJnN0YXRlLT5kc3QpLAo+IAo+IC0tIAo+IEpl eWt1bWFyIFMKCi0tIApTZWFuIFBhdWwsIFNvZnR3YXJlIEVuZ2luZWVyLCBHb29nbGUgLyBDaHJv bWl1bSBPUwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpG cmVlZHJlbm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJlbm8K