From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Kaehlcke Subject: Re: [PATCH v2 5/6] drivers: qcom: rpmh-rsc: write PDC data Date: Wed, 12 Sep 2018 15:37:56 -0700 Message-ID: <20180912223756.GL22824@google.com> References: <1532685889-31345-1-git-send-email-rplsssn@codeaurora.org> <1532685889-31345-6-git-send-email-rplsssn@codeaurora.org> <20180912222809.GK22824@google.com> <20180912223356.GA11079@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20180912223356.GA11079@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Lina Iyer Cc: Raju P L S S S N , andy.gross@linaro.org, david.brown@linaro.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, rnayak@codeaurora.org, bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org, sboyd@kernel.org, evgreen@chromium.org, dianders@chromium.org List-Id: linux-arm-msm@vger.kernel.org On Wed, Sep 12, 2018 at 04:33:56PM -0600, Lina Iyer wrote: > On Wed, Sep 12 2018 at 16:28 -0600, Matthias Kaehlcke wrote: > > On Fri, Jul 27, 2018 at 03:34:48PM +0530, Raju P L S S S N wrote: > > > From: Lina Iyer > > > > > > The Power Domain Controller can be programmed to wakeup the RSC and > > > setup the resources back in the active state, before the processor is > > > woken up by a timer interrupt. The wakeup value from the timer hardware > > > can be copied to the PDC which has its own timer and is in an always-on > > > power domain. Programming the wakeup value is done through a separate > > > register on the RSC. > > > > > > Signed-off-by: Lina Iyer > > > Signed-off-by: Raju P.L.S.S.S.N > > > --- > > > Changes in v2: > > > - Remove unnecessary EXPORT_SYMBOL > > > --- > > > > > +int rpmh_rsc_write_pdc_data(struct rsc_drv *drv, const struct tcs_request *msg) > > > +{ > > > + int i; > > > + void __iomem *addr = drv->base + RSC_PDC_DRV_DATA; > > > + > > > + if (!msg || !msg->cmds || msg->num_cmds != RSC_PDC_DATA_SIZE) > > > + return -EINVAL; > > > > Is it really always exactly 2 (RSC_PDC_DATA_SIZE) commands? > > > Yes, always. Thanks for the confirmation! Reviewed-by: Matthias Kaehlcke