From: Matthias Kaehlcke <mka@chromium.org>
To: Balakrishna Godavarthi <bgodavar@codeaurora.org>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 0/1] Cold on & off support for Qualcomm BT chip wcn3990
Date: Wed, 19 Sep 2018 10:26:48 -0700 [thread overview]
Message-ID: <20180919172648.GR22824@google.com> (raw)
In-Reply-To: <20180919152113.7611-1-bgodavar@codeaurora.org>
nit: Not sure there is much value in a cover letter for a 'series'
with a single patch. The changelog and additional comments (if needed)
can be placed in the post with the patch below '---'.
On Wed, Sep 19, 2018 at 08:51:12PM +0530, Balakrishna Godavarthi wrote:
> This patch will power off regulators while hci0 down and turn on them
> back on hci0 up. Every time we power off we call proto specific close
> function, so that we will free the memory of Qualcomm BT specific buffers.
> Will call proto open to assign the memory and turn on the regulators, before
> calling qualcomm setup.
>
> v2:
> * Removed vendor specific hdev->open and close functions.
> * Added hdev->shutdown function to turn off the regs.
>
> v1:
> * initial patch.
>
> Balakrishna Godavarthi (1):
> Bluetooth: hci_qca: Add poweroff support during hci down for wcn3990
>
> drivers/bluetooth/hci_qca.c | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
prev parent reply other threads:[~2018-09-19 17:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 15:21 [PATCH v2 0/1] Cold on & off support for Qualcomm BT chip wcn3990 Balakrishna Godavarthi
2018-09-19 15:21 ` [PATCH v2 1/1] Bluetooth: hci_qca: Add poweroff support during hci down for wcn3990 Balakrishna Godavarthi
2018-09-19 17:21 ` Matthias Kaehlcke
2018-09-20 13:48 ` Balakrishna Godavarthi
2018-09-19 17:26 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180919172648.GR22824@google.com \
--to=mka@chromium.org \
--cc=bgodavar@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).