From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH 1/5] drm/msm/dpu: Remove unneeded checks from dpu_plane Date: Wed, 19 Sep 2018 15:01:44 -0400 Message-ID: <20180919190144.GU188300@art_vandelay> References: <20180919154415.131292-1-bzwang@chromium.org> <20180919154415.131292-2-bzwang@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180919154415.131292-2-bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Bruce Wang Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gV2VkLCBTZXAgMTksIDIwMTggYXQgMTE6NDQ6MTFBTSAtMDQwMCwgQnJ1Y2UgV2FuZyB3cm90 ZToKPiBSZW1vdmVzIHNvbWUgY2hlY2tzIGZyb20gZHB1X3BsYW5lLmMgdGhhdCB3aWxsIG5ldmVy IHJlc3VsdCBpbiBhbiBlcnJvci4KPiBTdWJzZXF1ZW50IHZhcmlhYmxlIGFzc2lnbm1lbnRzIGJl Y29tZSBwYXJ0IG9mIHRoZSBpbml0aWFsaXphdGlvbiB3aGVyZXZlcgo+IHBvc3NpYmxlLgo+IAo+ IFNpZ25lZC1vZmYtYnk6IEJydWNlIFdhbmcgPGJ6d2FuZ0BjaHJvbWl1bS5vcmc+Cj4gLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9wbGFuZS5jIHwgNTMgKysrLS0tLS0t LS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNDcgZGVs ZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUx L2RwdV9wbGFuZS5jIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X3BsYW5lLmMK PiBpbmRleCAxY2U3NjQ2MGQ3MTAuLmE4ZDAwZjU3ZjA2YSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfcGxhbmUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9tc20vZGlzcC9kcHUxL2RwdV9wbGFuZS5jCj4gQEAgLTIyOSwxOSArMjI5LDExIEBAIHN0YXRp YyB1NjQgX2RwdV9wbGFuZV9nZXRfcW9zX2x1dChjb25zdCBzdHJ1Y3QgZHB1X3Fvc19sdXRfdGJs ICp0YmwsCj4gIHN0YXRpYyB2b2lkIF9kcHVfcGxhbmVfc2V0X3Fvc19sdXQoc3RydWN0IGRybV9w bGFuZSAqcGxhbmUsCj4gIAkJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIpCj4gIHsKPiAtCXN0 cnVjdCBkcHVfcGxhbmUgKnBkcHU7Cj4gKwlzdHJ1Y3QgZHB1X3BsYW5lICpwZHB1ID0gdG9fZHB1 X3BsYW5lKHBsYW5lKTsKPiAgCWNvbnN0IHN0cnVjdCBkcHVfZm9ybWF0ICpmbXQgPSBOVUxMOwo+ ICAJdTY0IHFvc19sdXQ7Cj4gIAl1MzIgdG90YWxfZmwgPSAwLCBsdXRfdXNhZ2U7Cj4gIAo+IC0J aWYgKCFwbGFuZSB8fCAhZmIpIHsKPiAtCQlEUFVfRVJST1IoImludmFsaWQgYXJndW1lbnRzIHBs YW5lICVkIGZiICVkXG4iLAo+IC0JCQkJcGxhbmUgIT0gMCwgZmIgIT0gMCk7Cj4gLQkJcmV0dXJu Owo+IC0JfQo+IC0KPiAtCXBkcHUgPSB0b19kcHVfcGxhbmUocGxhbmUpOwo+IC0KPiAgCWlmICgh cGRwdS0+cGlwZV9odyB8fCAhcGRwdS0+cGlwZV9zYmxrIHx8ICFwZHB1LT5jYXRhbG9nKSB7CgpB cyB3ZSBkaXNjdXNzZWQsIGl0IGxvb2tzIGxpa2Ugd2UgY2FuIHJlbW92ZSBhbGwgb2YgdGhlc2Ug dG9vIFxvLwoKPiAgCQlEUFVfRVJST1IoImludmFsaWQgYXJndW1lbnRzXG4iKTsKPiAgCQlyZXR1 cm47Cj4gQEAgLTI5MCwxNyArMjgyLDEwIEBAIHN0YXRpYyB2b2lkIF9kcHVfcGxhbmVfc2V0X3Fv c19sdXQoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gIHN0YXRpYyB2b2lkIF9kcHVfcGxhbmVf c2V0X2Rhbmdlcl9sdXQoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gIAkJc3RydWN0IGRybV9m cmFtZWJ1ZmZlciAqZmIpCj4gIHsKPiAtCXN0cnVjdCBkcHVfcGxhbmUgKnBkcHU7Cj4gKwlzdHJ1 Y3QgZHB1X3BsYW5lICpwZHB1ID0gdG9fZHB1X3BsYW5lKHBsYW5lKTsKPiAgCWNvbnN0IHN0cnVj dCBkcHVfZm9ybWF0ICpmbXQgPSBOVUxMOwo+ICAJdTMyIGRhbmdlcl9sdXQsIHNhZmVfbHV0Owo+ ICAKPiAtCWlmICghcGxhbmUgfHwgIWZiKSB7Cj4gLQkJRFBVX0VSUk9SKCJpbnZhbGlkIGFyZ3Vt ZW50c1xuIik7Cj4gLQkJcmV0dXJuOwo+IC0JfQo+IC0KPiAtCXBkcHUgPSB0b19kcHVfcGxhbmUo cGxhbmUpOwo+IC0KPiAgCWlmICghcGRwdS0+cGlwZV9odyB8fCAhcGRwdS0+cGlwZV9zYmxrIHx8 ICFwZHB1LT5jYXRhbG9nKSB7CgphbmQgaGVyZQoKPiAgCQlEUFVfRVJST1IoImludmFsaWQgYXJn dW1lbnRzXG4iKTsKPiAgCQlyZXR1cm47Cj4gQEAgLTM2MSwxNCArMzQ2LDcgQEAgc3RhdGljIHZv aWQgX2RwdV9wbGFuZV9zZXRfZGFuZ2VyX2x1dChzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiAg c3RhdGljIHZvaWQgX2RwdV9wbGFuZV9zZXRfcW9zX2N0cmwoc3RydWN0IGRybV9wbGFuZSAqcGxh bmUsCj4gIAlib29sIGVuYWJsZSwgdTMyIGZsYWdzKQo+ICB7Cj4gLQlzdHJ1Y3QgZHB1X3BsYW5l ICpwZHB1Owo+IC0KPiAtCWlmICghcGxhbmUpIHsKPiAtCQlEUFVfRVJST1IoImludmFsaWQgYXJn dW1lbnRzXG4iKTsKPiAtCQlyZXR1cm47Cj4gLQl9Cj4gLQo+IC0JcGRwdSA9IHRvX2RwdV9wbGFu ZShwbGFuZSk7Cj4gKwlzdHJ1Y3QgZHB1X3BsYW5lICpwZHB1ID0gdG9fZHB1X3BsYW5lKHBsYW5l KTsKPiAgCj4gIAlpZiAoIXBkcHUtPnBpcGVfaHcgfHwgIXBkcHUtPnBpcGVfc2JsaykgewoKYW5k IGhlcmUKCj4gIAkJRFBVX0VSUk9SKCJpbnZhbGlkIGFyZ3VtZW50c1xuIik7Cj4gQEAgLTQ1Miwx NiArNDMwLDkgQEAgc3RhdGljIHZvaWQgX2RwdV9wbGFuZV9zZXRfb3RfbGltaXQoc3RydWN0IGRy bV9wbGFuZSAqcGxhbmUsCj4gIHsKPiAgCXN0cnVjdCBkcHVfcGxhbmUgKnBkcHU7Cj4gIAlzdHJ1 Y3QgZHB1X3ZiaWZfc2V0X290X3BhcmFtcyBvdF9wYXJhbXM7Cj4gLQlzdHJ1Y3QgbXNtX2RybV9w cml2YXRlICpwcml2Owo+ICsJc3RydWN0IG1zbV9kcm1fcHJpdmF0ZSAqcHJpdiA9IHBsYW5lLT5k ZXYtPmRldl9wcml2YXRlOwo+ICAJc3RydWN0IGRwdV9rbXMgKmRwdV9rbXM7Cj4gIAo+IC0JaWYg KCFwbGFuZSB8fCAhcGxhbmUtPmRldiB8fCAhY3J0Yykgewo+IC0JCURQVV9FUlJPUigiaW52YWxp ZCBhcmd1bWVudHMgcGxhbmUgJWQgY3J0YyAlZFxuIiwKPiAtCQkJCXBsYW5lICE9IDAsIGNydGMg IT0gMCk7Cj4gLQkJcmV0dXJuOwo+IC0JfQo+IC0KPiAtCXByaXYgPSBwbGFuZS0+ZGV2LT5kZXZf cHJpdmF0ZTsKPiAgCWlmICghcHJpdiB8fCAhcHJpdi0+a21zKSB7CgpUaGVzZSBhcmUgYWxzbyBn dWFyYW50ZWVkIHRvIGJlIG5vbi1OVUxMIChkZXZfcHJpdmF0ZSBjaGVja2VkIGluIG1zbV9kcnYg YW5kIGttcwppcyBjaGVja2VkIGluIGRwdV9rbXMuYyAob3IgbWF5YmUgbXNtX2ttcy5jLCBidXQg ZWl0aGVyIHdheSkpLgoKPiAgCQlEUFVfRVJST1IoImludmFsaWQgS01TIHJlZmVyZW5jZVxuIik7 Cj4gIAkJcmV0dXJuOwo+IEBAIC00OTYsMTUgKzQ2Nyw5IEBAIHN0YXRpYyB2b2lkIF9kcHVfcGxh bmVfc2V0X3Fvc19yZW1hcChzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSkKPiAgewo+ICAJc3RydWN0 IGRwdV9wbGFuZSAqcGRwdTsKPiAgCXN0cnVjdCBkcHVfdmJpZl9zZXRfcW9zX3BhcmFtcyBxb3Nf cGFyYW1zOwo+IC0Jc3RydWN0IG1zbV9kcm1fcHJpdmF0ZSAqcHJpdjsKPiArCXN0cnVjdCBtc21f ZHJtX3ByaXZhdGUgKnByaXYgPSBwbGFuZS0+ZGV2LT5kZXZfcHJpdmF0ZTsKPiAgCXN0cnVjdCBk cHVfa21zICpkcHVfa21zOwo+ICAKPiAtCWlmICghcGxhbmUgfHwgIXBsYW5lLT5kZXYpIHsKPiAt CQlEUFVfRVJST1IoImludmFsaWQgYXJndW1lbnRzXG4iKTsKPiAtCQlyZXR1cm47Cj4gLQl9Cj4g LQo+IC0JcHJpdiA9IHBsYW5lLT5kZXYtPmRldl9wcml2YXRlOwo+ICAJaWYgKCFwcml2IHx8ICFw cml2LT5rbXMpIHsKPiAgCQlEUFVfRVJST1IoImludmFsaWQgS01TIHJlZmVyZW5jZVxuIik7Cj4g IAkJcmV0dXJuOwo+IEBAIC0xNzM3LDE3ICsxNzAyLDExIEBAIHN0cnVjdCBkcm1fcGxhbmUgKmRw dV9wbGFuZV9pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAlzdHJ1Y3QgZHJtX3BsYW5l ICpwbGFuZSA9IE5VTEwsICptYXN0ZXJfcGxhbmUgPSBOVUxMOwo+ICAJY29uc3Qgc3RydWN0IGRw dV9mb3JtYXRfZXh0ZW5kZWQgKmZvcm1hdF9saXN0Owo+ICAJc3RydWN0IGRwdV9wbGFuZSAqcGRw dTsKPiAtCXN0cnVjdCBtc21fZHJtX3ByaXZhdGUgKnByaXY7Cj4gKwlzdHJ1Y3QgbXNtX2RybV9w cml2YXRlICpwcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAgCXN0cnVjdCBkcHVfa21zICprbXM7 Cj4gIAlpbnQgenBvc19tYXggPSBEUFVfWlBPU19NQVg7Cj4gIAlpbnQgcmV0ID0gLUVJTlZBTDsK PiAgCj4gLQlpZiAoIWRldikgewo+IC0JCURQVV9FUlJPUigiWyV1XWRldmljZSBpcyBOVUxMXG4i LCBwaXBlKTsKPiAtCQlnb3RvIGV4aXQ7Cj4gLQl9Cj4gLQo+IC0JcHJpdiA9IGRldi0+ZGV2X3By aXZhdGU7Cj4gIAlpZiAoIXByaXYpIHsKClNvIGxldCdzIGRvIGFub3RoZXIgcGFzcyBvZiBhbGwg ZGV2X3ByaXZhdGUgY2hlY2tzIGFsb25nIHdpdGgga21zLCBwaXBlX2h3L3NibGsvZXRjLgoKU2Vh bgoKPiAgCQlEUFVfRVJST1IoIlsldV1wcml2YXRlIGRhdGEgaXMgTlVMTFxuIiwgcGlwZSk7Cj4g IAkJZ290byBleGl0Owo+IC0tIAo+IDIuMTkuMC4zOTcuZ2RkOTAzNDBmNmEtZ29vZwo+IAoKLS0g ClNlYW4gUGF1bCwgU29mdHdhcmUgRW5naW5lZXIsIEdvb2dsZSAvIENocm9taXVtIE9TCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkZyZWVkcmVubyBtYWls aW5nIGxpc3QKRnJlZWRyZW5vQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ZyZWVkcmVubwo=