From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH 4/5] drm/msm/dpu: Change _dpu_crtc_power_enable to void Date: Wed, 19 Sep 2018 15:13:12 -0400 Message-ID: <20180919191312.GX188300@art_vandelay> References: <20180919154415.131292-1-bzwang@chromium.org> <20180919154415.131292-5-bzwang@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180919154415.131292-5-bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Bruce Wang Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gV2VkLCBTZXAgMTksIDIwMTggYXQgMTE6NDQ6MTRBTSAtMDQwMCwgQnJ1Y2UgV2FuZyB3cm90 ZToKPiBBbGwgY2hlY2tzIGZvciBfZHB1X2NydGNfcG93ZXJfZW5hYmxlIGFyZSBub3QgdHJ1ZSwg c28gdGhlIGZ1bmN0aW9uCj4gY2FuIG5ldmVyIHJldHVybiBhbiBlcnJvciBjb2RlLiBBbGwgY2Fs bHMgb2YgdGhlIGZ1bmN0aW9uIGhhdmUgYWxzbwo+IGJlZW4gY2hhbmdlZCBzbyB0aGF0IHRoZXkg ZG9uJ3QgZXhwZWN0IGEgcmV0dXJuIHZhbHVlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEJydWNlIFdh bmcgPGJ6d2FuZ0BjaHJvbWl1bS5vcmc+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlz cC9kcHUxL2RwdV9jcnRjLmMgfCAzNSArKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxl IGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMzAgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9jcnRjLmMgYi9kcml2ZXJzL2dw dS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfY3J0Yy5jCj4gaW5kZXggMDE3ZDE2MTMxZGFjLi5mMGI1 MjI4MWM0NmYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1 X2NydGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9jcnRjLmMK PiBAQCAtNjAsMzcgKzYwLDE2IEBAIHN0YXRpYyBpbmxpbmUgc3RydWN0IGRwdV9rbXMgKl9kcHVf Y3J0Y19nZXRfa21zKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiAgCXJldHVybiB0b19kcHVfa21z KHByaXYtPmttcyk7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbmxpbmUgaW50IF9kcHVfY3J0Y19wb3dl cl9lbmFibGUoc3RydWN0IGRwdV9jcnRjICpkcHVfY3J0YywgYm9vbCBlbmFibGUpCj4gK3N0YXRp YyBpbmxpbmUgdm9pZCBfZHB1X2NydGNfcG93ZXJfZW5hYmxlKHN0cnVjdCBkcHVfY3J0YyAqZHB1 X2NydGMsIGJvb2wgZW5hYmxlKQo+ICB7Cj4gLQlzdHJ1Y3QgZHJtX2NydGMgKmNydGM7Cj4gLQlz dHJ1Y3QgbXNtX2RybV9wcml2YXRlICpwcml2Owo+IC0Jc3RydWN0IGRwdV9rbXMgKmRwdV9rbXM7 Cj4gLQo+IC0JaWYgKCFkcHVfY3J0Yykgewo+IC0JCURQVV9FUlJPUigiaW52YWxpZCBkcHUgY3J0 Y1xuIik7Cj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gLQl9Cj4gLQo+IC0JY3J0YyA9ICZkcHVfY3J0 Yy0+YmFzZTsKPiAtCWlmICghY3J0Yy0+ZGV2IHx8ICFjcnRjLT5kZXYtPmRldl9wcml2YXRlKSB7 Cj4gLQkJRFBVX0VSUk9SKCJpbnZhbGlkIGRybSBkZXZpY2VcbiIpOwo+IC0JCXJldHVybiAtRUlO VkFMOwo+IC0JfQo+IC0KPiAtCXByaXYgPSBjcnRjLT5kZXYtPmRldl9wcml2YXRlOwo+IC0JaWYg KCFwcml2LT5rbXMpIHsKPiAtCQlEUFVfRVJST1IoImludmFsaWQga21zXG4iKTsKPiAtCQlyZXR1 cm4gLUVJTlZBTDsKPiAtCX0KPiAtCj4gLQlkcHVfa21zID0gdG9fZHB1X2ttcyhwcml2LT5rbXMp Owo+ICsJc3RydWN0IGRybV9jcnRjICpjcnRjID0gJmRwdV9jcnRjLT5iYXNlOwo+ICsJc3RydWN0 IG1zbV9kcm1fcHJpdmF0ZSAqcHJpdiA9IGNydGMtPmRldi0+ZGV2X3ByaXZhdGU7Cj4gKwlzdHJ1 Y3QgZHB1X2ttcyAqZHB1X2ttcyA9IHRvX2RwdV9rbXMocHJpdi0+a21zKTsKPiAgCj4gIAlpZiAo ZW5hYmxlKQo+ICAJCXBtX3J1bnRpbWVfZ2V0X3N5bmMoJmRwdV9rbXMtPnBkZXYtPmRldik7Cj4g IAllbHNlCj4gIAkJcG1fcnVudGltZV9wdXRfc3luYygmZHB1X2ttcy0+cGRldi0+ZGV2KTsKPiAt Cj4gLQlyZXR1cm4gMDsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgZHB1X2NydGNfZGVzdHJveShz dHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gQEAgLTg0OSwxNCArODI4LDEwIEBAIHN0YXRpYyBpbnQg X2RwdV9jcnRjX3ZibGFua19lbmFibGVfbm9fbG9jaygKCkkgdGhpbmsgdGhpcyBjYW4gZ28gdG8g dm9pZCBub3cgdG9vIHNpbmNlIHRoZSBpZiAoIWRwdV9jcnRjKSBjaGVjayBhdCB0aGUgdG9wIGlz CmEgbm8tb3AuCgpUaGlzIGlzIGEgZ29vZCB0aGluZywgdG9vIHNpbmNlIHRoaXMgZnVuY3Rpb24g aXMgb25seSBjYWxsZWQgZnJvbSB2b2lkIGZ1bmN0aW9ucwp3aXRoIG9uZSBleGNlcHRpb24gd2hl cmUgaXRzIHJldHVybiB2YWx1ZSBpc24ndCBwYXNzZWQgb24hCgpTZWFuCgo+ICAJZGV2ID0gY3J0 Yy0+ZGV2Owo+ICAKPiAgCWlmIChlbmFibGUpIHsKPiAtCQlpbnQgcmV0Owo+IC0KPiAgCQkvKiBk cm9wIGxvY2sgc2luY2UgcG93ZXIgY3J0YyBjYiBtYXkgdHJ5IHRvIHJlLWFjcXVpcmUgbG9jayAq Lwo+ICAJCW11dGV4X3VubG9jaygmZHB1X2NydGMtPmNydGNfbG9jayk7Cj4gLQkJcmV0ID0gX2Rw dV9jcnRjX3Bvd2VyX2VuYWJsZShkcHVfY3J0YywgdHJ1ZSk7Cj4gKwkJX2RwdV9jcnRjX3Bvd2Vy X2VuYWJsZShkcHVfY3J0YywgdHJ1ZSk7Cj4gIAkJbXV0ZXhfbG9jaygmZHB1X2NydGMtPmNydGNf bG9jayk7Cj4gLQkJaWYgKHJldCkKPiAtCQkJcmV0dXJuIHJldDsKPiAgCj4gIAkJbGlzdF9mb3Jf ZWFjaF9lbnRyeShlbmMsICZkZXYtPm1vZGVfY29uZmlnLmVuY29kZXJfbGlzdCwgaGVhZCkgewo+ ICAJCQlpZiAoZW5jLT5jcnRjICE9IGNydGMpCj4gLS0gCj4gMi4xOS4wLjM5Ny5nZGQ5MDM0MGY2 YS1nb29nCj4gCgotLSAKU2VhbiBQYXVsLCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hy b21pdW0gT1MKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K RnJlZWRyZW5vIG1haWxpbmcgbGlzdApGcmVlZHJlbm9AbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZnJlZWRyZW5vCg==