From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jordan Crouse Subject: Re: [PATCH v2 4/7] drm/msm/dpu: Change _dpu_crtc_power_enable to void Date: Thu, 20 Sep 2018 11:36:34 -0600 Message-ID: <20180920173634.GD809@jcrouse-lnx.qualcomm.com> References: <20180920164924.225847-1-bzwang@chromium.org> <20180920164924.225847-5-bzwang@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180920164924.225847-5-bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Bruce Wang Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gVGh1LCBTZXAgMjAsIDIwMTggYXQgMTI6NDk6MjFQTSAtMDQwMCwgQnJ1Y2UgV2FuZyB3cm90 ZToKPiBBbGwgY2hlY2tzIGZvciBfZHB1X2NydGNfcG93ZXJfZW5hYmxlIGFyZSBub3QgdHJ1ZSwg c28gdGhlIGZ1bmN0aW9uCj4gY2FuIG5ldmVyIHJldHVybiBhbiBlcnJvciBjb2RlLiBBbGwgY2Fs bHMgb2YgdGhlIGZ1bmN0aW9uIGhhdmUgYWxzbwo+IGJlZW4gY2hhbmdlZCBzbyB0aGF0IHRoZXkg ZG9uJ3QgZXhwZWN0IGEgcmV0dXJuIHZhbHVlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEJydWNlIFdh bmcgPGJ6d2FuZ0BjaHJvbWl1bS5vcmc+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlz cC9kcHUxL2RwdV9jcnRjLmMgfCAzNSArKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxl IGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMzAgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9jcnRjLmMgYi9kcml2ZXJzL2dw dS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfY3J0Yy5jCj4gaW5kZXggYTlhZGIxNmVhYzZmLi42NDhk NzdjNDFjM2UgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1 X2NydGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9jcnRjLmMK PiBAQCAtNTksMzcgKzU5LDE2IEBAIHN0YXRpYyBpbmxpbmUgc3RydWN0IGRwdV9rbXMgKl9kcHVf Y3J0Y19nZXRfa21zKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiAgCQkJLT5rbXMpOwo+ICB9Cj4g IAo+IC1zdGF0aWMgaW5saW5lIGludCBfZHB1X2NydGNfcG93ZXJfZW5hYmxlKHN0cnVjdCBkcHVf Y3J0YyAqZHB1X2NydGMsIGJvb2wgZW5hYmxlKQo+ICtzdGF0aWMgaW5saW5lIHZvaWQgX2RwdV9j cnRjX3Bvd2VyX2VuYWJsZShzdHJ1Y3QgZHB1X2NydGMgKmRwdV9jcnRjLCBib29sIGVuYWJsZSkK ClNpbmNlIHRoaXMgaXMgb25seSB0d28gbGluZXMgb2YgY29kZSB3aXRoIHRoZSBvcHRpbWl6YXRp b24gYmVsb3cgbXkgcGVyc29uYWwKcHJlZmVyZW5jZSB3b3VsZCBiZSB0byB0dXJuIHRoaXMgaW50 byB0d28gZnVuY3Rpb25zOiBfZHB1X2NydGNfcG93ZXJfZW5hYmxlIGFuZApfZHB1X2NydGNfcG93 ZXJfZGlzYWJsZS4gSSBmaW5kIHRoYXQgdG8gYmUgbW9yZSByZWFkYWJsZSB3aGVuIHdhbGtpbmcg dGhyb3VnaAp0aGUgZnVuY3Rpb25hbCBjb2RlLgoKPiAgewo+IC0Jc3RydWN0IGRybV9jcnRjICpj cnRjOwo+IC0Jc3RydWN0IG1zbV9kcm1fcHJpdmF0ZSAqcHJpdjsKPiAtCXN0cnVjdCBkcHVfa21z ICpkcHVfa21zOwo+IC0KPiAtCWlmICghZHB1X2NydGMpIHsKPiAtCQlEUFVfRVJST1IoImludmFs aWQgZHB1IGNydGNcbiIpOwo+IC0JCXJldHVybiAtRUlOVkFMOwo+IC0JfQo+IC0KPiAtCWNydGMg PSAmZHB1X2NydGMtPmJhc2U7Cj4gLQlpZiAoIWNydGMtPmRldiB8fCAhY3J0Yy0+ZGV2LT5kZXZf cHJpdmF0ZSkgewo+IC0JCURQVV9FUlJPUigiaW52YWxpZCBkcm0gZGV2aWNlXG4iKTsKPiAtCQly ZXR1cm4gLUVJTlZBTDsKPiAtCX0KPiAtCj4gLQlwcml2ID0gY3J0Yy0+ZGV2LT5kZXZfcHJpdmF0 ZTsKPiAtCWlmICghcHJpdi0+a21zKSB7Cj4gLQkJRFBVX0VSUk9SKCJpbnZhbGlkIGttc1xuIik7 Cj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gLQl9Cj4gLQo+IC0JZHB1X2ttcyA9IHRvX2RwdV9rbXMo cHJpdi0+a21zKTsKPiArCXN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9ICZkcHVfY3J0Yy0+YmFzZTsK PiArCXN0cnVjdCBtc21fZHJtX3ByaXZhdGUgKnByaXYgPSBjcnRjLT5kZXYtPmRldl9wcml2YXRl Owo+ICsJc3RydWN0IGRwdV9rbXMgKmRwdV9rbXMgPSB0b19kcHVfa21zKHByaXYtPmttcyk7CgpJ IHRoaW5rIGFsbCB0aHJlZSBvZiB0aGVzZSBjYW4gYmUgcmVwbGFjZWQgYnkKCnN0cnVjdCBkcHVf a21zICpkcHVfa21zID0gX2RwdV9jcnRjX2dldF9rbXMoJmRwdV9jcnRjLT5iYXNlKTsKCj4gIAlp ZiAoZW5hYmxlKQo+ICAJCXBtX3J1bnRpbWVfZ2V0X3N5bmMoJmRwdV9rbXMtPnBkZXYtPmRldik7 Cj4gIAllbHNlCj4gIAkJcG1fcnVudGltZV9wdXRfc3luYygmZHB1X2ttcy0+cGRldi0+ZGV2KTsK PiAtCj4gLQlyZXR1cm4gMDsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgZHB1X2NydGNfZGVzdHJv eShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gQEAgLTgyMiwxNCArODAxLDEwIEBAIHN0YXRpYyBp bnQgX2RwdV9jcnRjX3ZibGFua19lbmFibGVfbm9fbG9jaygKPiAgCWRldiA9IGNydGMtPmRldjsK PiAgCj4gIAlpZiAoZW5hYmxlKSB7Cj4gLQkJaW50IHJldDsKPiAtCj4gIAkJLyogZHJvcCBsb2Nr IHNpbmNlIHBvd2VyIGNydGMgY2IgbWF5IHRyeSB0byByZS1hY3F1aXJlIGxvY2sgKi8KPiAgCQlt dXRleF91bmxvY2soJmRwdV9jcnRjLT5jcnRjX2xvY2spOwo+IC0JCXJldCA9IF9kcHVfY3J0Y19w b3dlcl9lbmFibGUoZHB1X2NydGMsIHRydWUpOwo+ICsJCV9kcHVfY3J0Y19wb3dlcl9lbmFibGUo ZHB1X2NydGMsIHRydWUpOwo+ICAJCW11dGV4X2xvY2soJmRwdV9jcnRjLT5jcnRjX2xvY2spOwo+ IC0JCWlmIChyZXQpCj4gLQkJCXJldHVybiByZXQ7Cj4gIAo+ICAJCWxpc3RfZm9yX2VhY2hfZW50 cnkoZW5jLCAmZGV2LT5tb2RlX2NvbmZpZy5lbmNvZGVyX2xpc3QsIGhlYWQpIHsKPiAgCQkJaWYg KGVuYy0+Y3J0YyAhPSBjcnRjKQo+IC0tIAo+IDIuMTkuMC40NDQuZzE4MjQyZGE3ZWYtZ29vZwo+ IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gRnJl ZWRyZW5vIG1haWxpbmcgbGlzdAo+IEZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ZyZWVkcmVubwoK LS0gClRoZSBRdWFsY29tbSBJbm5vdmF0aW9uIENlbnRlciwgSW5jLiBpcyBhIG1lbWJlciBvZiBD b2RlIEF1cm9yYSBGb3J1bSwKYSBMaW51eCBGb3VuZGF0aW9uIENvbGxhYm9yYXRpdmUgUHJvamVj dApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpGcmVlZHJl bm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJlbm8K