From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v2 4/7] drm/msm/dpu: Change _dpu_crtc_power_enable to void Date: Fri, 21 Sep 2018 11:51:02 -0400 Message-ID: <20180921155102.GJ72545@art_vandelay> References: <20180920164924.225847-1-bzwang@chromium.org> <20180920164924.225847-5-bzwang@chromium.org> <20180920173634.GD809@jcrouse-lnx.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180920173634.GD809-9PYrDHPZ2Orvke4nUoYGnHL1okKdlPRT@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Bruce Wang , freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gVGh1LCBTZXAgMjAsIDIwMTggYXQgMTE6MzY6MzRBTSAtMDYwMCwgSm9yZGFuIENyb3VzZSB3 cm90ZToKPiBPbiBUaHUsIFNlcCAyMCwgMjAxOCBhdCAxMjo0OToyMVBNIC0wNDAwLCBCcnVjZSBX YW5nIHdyb3RlOgo+ID4gQWxsIGNoZWNrcyBmb3IgX2RwdV9jcnRjX3Bvd2VyX2VuYWJsZSBhcmUg bm90IHRydWUsIHNvIHRoZSBmdW5jdGlvbgo+ID4gY2FuIG5ldmVyIHJldHVybiBhbiBlcnJvciBj b2RlLiBBbGwgY2FsbHMgb2YgdGhlIGZ1bmN0aW9uIGhhdmUgYWxzbwo+ID4gYmVlbiBjaGFuZ2Vk IHNvIHRoYXQgdGhleSBkb24ndCBleHBlY3QgYSByZXR1cm4gdmFsdWUuCj4gPiAKPiA+IFNpZ25l ZC1vZmYtYnk6IEJydWNlIFdhbmcgPGJ6d2FuZ0BjaHJvbWl1bS5vcmc+Cj4gPiAtLS0KPiA+ICBk cml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfY3J0Yy5jIHwgMzUgKysrKy0tLS0tLS0t LS0tLS0tLS0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMzAgZGVs ZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3Av ZHB1MS9kcHVfY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2NydGMu Ywo+ID4gaW5kZXggYTlhZGIxNmVhYzZmLi42NDhkNzdjNDFjM2UgMTAwNjQ0Cj4gPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfY3J0Yy5jCj4gPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfY3J0Yy5jCj4gPiBAQCAtNTksMzcgKzU5LDE2IEBA IHN0YXRpYyBpbmxpbmUgc3RydWN0IGRwdV9rbXMgKl9kcHVfY3J0Y19nZXRfa21zKHN0cnVjdCBk cm1fY3J0YyAqY3J0YykKPiA+ICAJCQktPmttcyk7Cj4gPiAgfQo+ID4gIAo+ID4gLXN0YXRpYyBp bmxpbmUgaW50IF9kcHVfY3J0Y19wb3dlcl9lbmFibGUoc3RydWN0IGRwdV9jcnRjICpkcHVfY3J0 YywgYm9vbCBlbmFibGUpCj4gPiArc3RhdGljIGlubGluZSB2b2lkIF9kcHVfY3J0Y19wb3dlcl9l bmFibGUoc3RydWN0IGRwdV9jcnRjICpkcHVfY3J0YywgYm9vbCBlbmFibGUpCj4gCj4gU2luY2Ug dGhpcyBpcyBvbmx5IHR3byBsaW5lcyBvZiBjb2RlIHdpdGggdGhlIG9wdGltaXphdGlvbiBiZWxv dyBteSBwZXJzb25hbAo+IHByZWZlcmVuY2Ugd291bGQgYmUgdG8gdHVybiB0aGlzIGludG8gdHdv IGZ1bmN0aW9uczogX2RwdV9jcnRjX3Bvd2VyX2VuYWJsZSBhbmQKPiBfZHB1X2NydGNfcG93ZXJf ZGlzYWJsZS4gSSBmaW5kIHRoYXQgdG8gYmUgbW9yZSByZWFkYWJsZSB3aGVuIHdhbGtpbmcgdGhy b3VnaAo+IHRoZSBmdW5jdGlvbmFsIGNvZGUuCgouLi5vciBqdXN0IGNhbGwgdGhlIHBtX3J1bnRp bWUgZnVuY3Rpb25zIGRpcmVjdGx5PyBJZiB3ZSBjYW4gdXNlCl9kcHVfY3J0Y19nZXRfa21zKCkg aXQgc2hvdWxkbid0IGJlIHRvbyBuYXN0eS4KClNlYW4KCj4gCj4gPiAgewo+ID4gLQlzdHJ1Y3Qg ZHJtX2NydGMgKmNydGM7Cj4gPiAtCXN0cnVjdCBtc21fZHJtX3ByaXZhdGUgKnByaXY7Cj4gPiAt CXN0cnVjdCBkcHVfa21zICpkcHVfa21zOwo+ID4gLQo+ID4gLQlpZiAoIWRwdV9jcnRjKSB7Cj4g PiAtCQlEUFVfRVJST1IoImludmFsaWQgZHB1IGNydGNcbiIpOwo+ID4gLQkJcmV0dXJuIC1FSU5W QUw7Cj4gPiAtCX0KPiA+IC0KPiA+IC0JY3J0YyA9ICZkcHVfY3J0Yy0+YmFzZTsKPiA+IC0JaWYg KCFjcnRjLT5kZXYgfHwgIWNydGMtPmRldi0+ZGV2X3ByaXZhdGUpIHsKPiA+IC0JCURQVV9FUlJP UigiaW52YWxpZCBkcm0gZGV2aWNlXG4iKTsKPiA+IC0JCXJldHVybiAtRUlOVkFMOwo+ID4gLQl9 Cj4gPiAtCj4gPiAtCXByaXYgPSBjcnRjLT5kZXYtPmRldl9wcml2YXRlOwo+ID4gLQlpZiAoIXBy aXYtPmttcykgewo+ID4gLQkJRFBVX0VSUk9SKCJpbnZhbGlkIGttc1xuIik7Cj4gPiAtCQlyZXR1 cm4gLUVJTlZBTDsKPiA+IC0JfQo+ID4gLQo+ID4gLQlkcHVfa21zID0gdG9fZHB1X2ttcyhwcml2 LT5rbXMpOwo+ID4gKwlzdHJ1Y3QgZHJtX2NydGMgKmNydGMgPSAmZHB1X2NydGMtPmJhc2U7Cj4g PiArCXN0cnVjdCBtc21fZHJtX3ByaXZhdGUgKnByaXYgPSBjcnRjLT5kZXYtPmRldl9wcml2YXRl Owo+ID4gKwlzdHJ1Y3QgZHB1X2ttcyAqZHB1X2ttcyA9IHRvX2RwdV9rbXMocHJpdi0+a21zKTsK PiAKPiBJIHRoaW5rIGFsbCB0aHJlZSBvZiB0aGVzZSBjYW4gYmUgcmVwbGFjZWQgYnkKPiAKPiBz dHJ1Y3QgZHB1X2ttcyAqZHB1X2ttcyA9IF9kcHVfY3J0Y19nZXRfa21zKCZkcHVfY3J0Yy0+YmFz ZSk7Cj4gCj4gPiAgCWlmIChlbmFibGUpCj4gPiAgCQlwbV9ydW50aW1lX2dldF9zeW5jKCZkcHVf a21zLT5wZGV2LT5kZXYpOwo+ID4gIAllbHNlCj4gPiAgCQlwbV9ydW50aW1lX3B1dF9zeW5jKCZk cHVfa21zLT5wZGV2LT5kZXYpOwo+ID4gLQo+ID4gLQlyZXR1cm4gMDsKPiA+ICB9Cj4gPiAgCj4g PiAgc3RhdGljIHZvaWQgZHB1X2NydGNfZGVzdHJveShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4g PiBAQCAtODIyLDE0ICs4MDEsMTAgQEAgc3RhdGljIGludCBfZHB1X2NydGNfdmJsYW5rX2VuYWJs ZV9ub19sb2NrKAo+ID4gIAlkZXYgPSBjcnRjLT5kZXY7Cj4gPiAgCj4gPiAgCWlmIChlbmFibGUp IHsKPiA+IC0JCWludCByZXQ7Cj4gPiAtCj4gPiAgCQkvKiBkcm9wIGxvY2sgc2luY2UgcG93ZXIg Y3J0YyBjYiBtYXkgdHJ5IHRvIHJlLWFjcXVpcmUgbG9jayAqLwo+ID4gIAkJbXV0ZXhfdW5sb2Nr KCZkcHVfY3J0Yy0+Y3J0Y19sb2NrKTsKPiA+IC0JCXJldCA9IF9kcHVfY3J0Y19wb3dlcl9lbmFi bGUoZHB1X2NydGMsIHRydWUpOwo+ID4gKwkJX2RwdV9jcnRjX3Bvd2VyX2VuYWJsZShkcHVfY3J0 YywgdHJ1ZSk7Cj4gPiAgCQltdXRleF9sb2NrKCZkcHVfY3J0Yy0+Y3J0Y19sb2NrKTsKPiA+IC0J CWlmIChyZXQpCj4gPiAtCQkJcmV0dXJuIHJldDsKPiA+ICAKPiA+ICAJCWxpc3RfZm9yX2VhY2hf ZW50cnkoZW5jLCAmZGV2LT5tb2RlX2NvbmZpZy5lbmNvZGVyX2xpc3QsIGhlYWQpIHsKPiA+ICAJ CQlpZiAoZW5jLT5jcnRjICE9IGNydGMpCj4gPiAtLSAKPiA+IDIuMTkuMC40NDQuZzE4MjQyZGE3 ZWYtZ29vZwo+ID4gCj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+ID4gRnJlZWRyZW5vIG1haWxpbmcgbGlzdAo+ID4gRnJlZWRyZW5vQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9mcmVlZHJlbm8KPiAKPiAtLSAKPiBUaGUgUXVhbGNvbW0gSW5ub3ZhdGlvbiBDZW50 ZXIsIEluYy4gaXMgYSBtZW1iZXIgb2YgQ29kZSBBdXJvcmEgRm9ydW0sCj4gYSBMaW51eCBGb3Vu ZGF0aW9uIENvbGxhYm9yYXRpdmUgUHJvamVjdAoKLS0gClNlYW4gUGF1bCwgU29mdHdhcmUgRW5n aW5lZXIsIEdvb2dsZSAvIENocm9taXVtIE9TCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkZyZWVkcmVubyBtYWlsaW5nIGxpc3QKRnJlZWRyZW5vQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ZyZWVkcmVubwo=