From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH 1/2] drm/msm: Use atomic helpers for pm_suspend/resume Date: Tue, 2 Oct 2018 11:22:53 -0400 Message-ID: <20181002152253.GB72545@art_vandelay> References: <20181002150530.6407-1-bzwang@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181002150530.6407-1-bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Bruce Wang Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gVHVlLCBPY3QgMDIsIDIwMTggYXQgMTE6MDU6MjlBTSAtMDQwMCwgQnJ1Y2UgV2FuZyB3cm90 ZToKPiBUaGUgZHB1IGltcGxlbWVudGF0aW9uIG9mIHBtX3Jlc3VtZSB3ZXJlIGNhdXNpbmcgYSBj cmFzaC4gVGhpcyBwYXRjaAo+IGNoYW5nZXMgbXNtX3BtX3N1c3BlbmQgYW5kIG1zbV9wbV9yZXN1 bWUgdG8gdXNlIHRoZSBhdG9taWMKPiBoZWxwZXJzIGRybV9hdG9taWNfaGVscGVyX3N1c3BlbmQg YW5kIGRybV9hdG9taWNfaGVscGVyX3Jlc3VtZS4KPiBSZW1vdmVzIHRoZSBob29rcyBuZWVkZWQg Zm9yIGNhbGxpbmcgdGhlIGRwdV9rbXMgaW1wbGVtZW50YXRpb25zIG9mCj4gc3VzcGVuZC9yZXN1 bWUuIE5vdGUgdGhhdCB0aGUgcG9sbF9kaXNhYmxlIGNhbGwgaXMgbGlrZWx5IG5vdCBuZWVkZWQg YXMKPiBvZiByaWdodCBub3cgYXMgdGhlIERSTV9DT05ORUNUT1JfUE9MTF9DT05ORUNUIGZsYWcg aXMgbmV2ZXIgc2V0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IEJydWNlIFdhbmcgPGJ6d2FuZ0BjaHJv bWl1bS5vcmc+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMu YyB8ICAyIC0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vbXNtX2Rydi5jICAgICAgICAgICB8IDI4 ICsrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL21zbS9tc21fa21z LmggICAgICAgICAgIHwgIDMgLS0tCj4gIDMgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygr KSwgMjMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20v ZGlzcC9kcHUxL2RwdV9rbXMuYyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9r bXMuYwo+IGluZGV4IDBhNjgzZTY1YTlmMy4uZTAxNDI5MTJkNjc2IDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMuYwo+IEBAIC04NzMsOCArODczLDYgQEAgc3RhdGlj IGNvbnN0IHN0cnVjdCBtc21fa21zX2Z1bmNzIGttc19mdW5jcyA9IHsKPiAgCS5jaGVja19tb2Rp ZmllZF9mb3JtYXQgPSBkcHVfZm9ybWF0X2NoZWNrX21vZGlmaWVkX2Zvcm1hdCwKPiAgCS5nZXRf Zm9ybWF0ICAgICAgPSBkcHVfZ2V0X21zbV9mb3JtYXQsCj4gIAkucm91bmRfcGl4Y2xrICAgID0g ZHB1X2ttc19yb3VuZF9waXhjbGssCj4gLQkucG1fc3VzcGVuZCAgICAgID0gZHB1X2ttc19wbV9z dXNwZW5kLAo+IC0JLnBtX3Jlc3VtZSAgICAgICA9IGRwdV9rbXNfcG1fcmVzdW1lLAoKQ2FuIHlv dSBmbGlwIHRoZSBvcmRlciBvZiB0aGVzZSBwYXRjaGVzIHN1Y2ggdGhhdCB5b3UgcmVtb3ZlIHRo ZSBkcHUKaW1wbGVtZW50YXRpb24gZW50aXJlbHkgZmlyc3QsIGFuZCB0aGVuIHJlbW92ZSB0aGUg dW51c2VkIGJpdHMgaW4gbXNtIGNvcmU/IFRoYXQKd2F5IHRoZSBkcHUgYW5kIG1zbSBiaXRzIGFy ZSBjbGVhcmx5IGRlbGluZWF0ZWQuCgpTZWFuCgo+ICAJLmRlc3Ryb3kgICAgICAgICA9IGRwdV9r bXNfZGVzdHJveSwKPiAgCS5zZXRfZW5jb2Rlcl9tb2RlID0gX2RwdV9rbXNfc2V0X2VuY29kZXJf bW9kZSwKPiAgI2lmZGVmIENPTkZJR19ERUJVR19GUwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vbXNtL21zbV9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vbXNtX2Rydi5jCj4gaW5k ZXggYzFhYmFkOGE4NjEyLi5iOGRjODU0Yzk5ZjIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL21zbS9tc21fZHJ2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9kcnYuYwo+ IEBAIC0xMDY5LDM3ICsxMDY5LDI5IEBAIHN0YXRpYyBpbnQgbXNtX3BtX3N1c3BlbmQoc3RydWN0 IGRldmljZSAqZGV2KQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGRldiA9IGRldl9nZXRf ZHJ2ZGF0YShkZXYpOwo+ICAJc3RydWN0IG1zbV9kcm1fcHJpdmF0ZSAqcHJpdiA9IGRkZXYtPmRl dl9wcml2YXRlOwo+IC0Jc3RydWN0IG1zbV9rbXMgKmttcyA9IHByaXYtPmttczsKPiAtCj4gLQkv KiBUT0RPOiBVc2UgYXRvbWljIGhlbHBlciBzdXNwZW5kL3Jlc3VtZSAqLwo+IC0JaWYgKGttcyAm JiBrbXMtPmZ1bmNzICYmIGttcy0+ZnVuY3MtPnBtX3N1c3BlbmQpCj4gLQkJcmV0dXJuIGttcy0+ ZnVuY3MtPnBtX3N1c3BlbmQoZGV2KTsKPiAgCj4gLQlkcm1fa21zX2hlbHBlcl9wb2xsX2Rpc2Fi bGUoZGRldik7Cj4gKwlpZiAoIUlTX0VSUl9PUl9OVUxMKHByaXYtPnBtX3N0YXRlKSkKPiArCQly ZXR1cm4gMDsKPiAgCj4gIAlwcml2LT5wbV9zdGF0ZSA9IGRybV9hdG9taWNfaGVscGVyX3N1c3Bl bmQoZGRldik7Cj4gLQlpZiAoSVNfRVJSKHByaXYtPnBtX3N0YXRlKSkgewo+IC0JCWRybV9rbXNf aGVscGVyX3BvbGxfZW5hYmxlKGRkZXYpOwo+IC0JCXJldHVybiBQVFJfRVJSKHByaXYtPnBtX3N0 YXRlKTsKPiAtCX0KPiAgCj4gLQlyZXR1cm4gMDsKPiArCXJldHVybiBJU19FUlIocHJpdi0+cG1f c3RhdGUpID8gUFRSX0VSUihwcml2LT5wbV9zdGF0ZSkgOiAwOwo+ICB9Cj4gIAo+ICBzdGF0aWMg aW50IG1zbV9wbV9yZXN1bWUoc3RydWN0IGRldmljZSAqZGV2KQo+ICB7Cj4gIAlzdHJ1Y3QgZHJt X2RldmljZSAqZGRldiA9IGRldl9nZXRfZHJ2ZGF0YShkZXYpOwo+ICAJc3RydWN0IG1zbV9kcm1f cHJpdmF0ZSAqcHJpdiA9IGRkZXYtPmRldl9wcml2YXRlOwo+IC0Jc3RydWN0IG1zbV9rbXMgKmtt cyA9IHByaXYtPmttczsKPiArCWludCByZXQ7Cj4gIAo+IC0JLyogVE9ETzogVXNlIGF0b21pYyBo ZWxwZXIgc3VzcGVuZC9yZXN1bWUgKi8KPiAtCWlmIChrbXMgJiYga21zLT5mdW5jcyAmJiBrbXMt PmZ1bmNzLT5wbV9yZXN1bWUpCj4gLQkJcmV0dXJuIGttcy0+ZnVuY3MtPnBtX3Jlc3VtZShkZXYp Owo+ICsJaWYgKElTX0VSUl9PUl9OVUxMKHByaXYtPnBtX3N0YXRlKSkKPiArCQlyZXR1cm4gMDsK PiAgCj4gLQlkcm1fYXRvbWljX2hlbHBlcl9yZXN1bWUoZGRldiwgcHJpdi0+cG1fc3RhdGUpOwo+ IC0JZHJtX2ttc19oZWxwZXJfcG9sbF9lbmFibGUoZGRldik7Cj4gKwlyZXQgPSBkcm1fYXRvbWlj X2hlbHBlcl9yZXN1bWUoZGRldiwgcHJpdi0+cG1fc3RhdGUpOwo+ICsJaWYgKHJldCA9PSAwKQo+ ICsJCXByaXYtPnBtX3N0YXRlID0gTlVMTDsKPiAgCj4gLQlyZXR1cm4gMDsKPiArCXJldHVybiBy ZXQ7Cj4gIH0KPiAgI2VuZGlmCj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNt L21zbV9rbXMuaCBiL2RyaXZlcnMvZ3B1L2RybS9tc20vbXNtX2ttcy5oCj4gaW5kZXggZmQ4OGNl YmI2YWRiLi4yYjgxYjQzYTRiYWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9t c21fa21zLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9rbXMuaAo+IEBAIC02Nyw5 ICs2Nyw2IEBAIHN0cnVjdCBtc21fa21zX2Z1bmNzIHsKPiAgCXZvaWQgKCpzZXRfZW5jb2Rlcl9t b2RlKShzdHJ1Y3QgbXNtX2ttcyAqa21zLAo+ICAJCQkJIHN0cnVjdCBkcm1fZW5jb2RlciAqZW5j b2RlciwKPiAgCQkJCSBib29sIGNtZF9tb2RlKTsKPiAtCS8qIHBtIHN1c3BlbmQvcmVzdW1lIGhv b2tzICovCj4gLQlpbnQgKCpwbV9zdXNwZW5kKShzdHJ1Y3QgZGV2aWNlICpkZXYpOwo+IC0JaW50 ICgqcG1fcmVzdW1lKShzdHJ1Y3QgZGV2aWNlICpkZXYpOwo+ICAJLyogY2xlYW51cDogKi8KPiAg CXZvaWQgKCpkZXN0cm95KShzdHJ1Y3QgbXNtX2ttcyAqa21zKTsKPiAgI2lmZGVmIENPTkZJR19E RUJVR19GUwo+IC0tIAo+IDIuMTkuMC42MDUuZzAxZDM3MWY3NDEtZ29vZwo+IAoKLS0gClNlYW4g UGF1bCwgU29mdHdhcmUgRW5naW5lZXIsIEdvb2dsZSAvIENocm9taXVtIE9TCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkZyZWVkcmVubyBtYWlsaW5nIGxp c3QKRnJlZWRyZW5vQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ZyZWVkcmVubwo=