From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH 1/2] drm/msm: dpu: Only check flush register against pending flushes Date: Wed, 3 Oct 2018 11:45:01 -0400 Message-ID: <20181003154501.GG72545@art_vandelay> References: <20180919185627.206368-1-sean@poorly.run> <20180919185627.206368-2-sean@poorly.run> <709b39ac985c0687e248710c75d16599@codeaurora.org> <20181001202953.GZ72545@art_vandelay> <7ee73b3551e82df746d478a6ac02e8be@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <7ee73b3551e82df746d478a6ac02e8be-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Jeykumar Sankaran Cc: Sean Paul , abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, Rob Clark , Sean Paul , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, hoegsberg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gVHVlLCBPY3QgMDIsIDIwMTggYXQgMDY6MTQ6MzhQTSAtMDcwMCwgSmV5a3VtYXIgU2Fua2Fy YW4gd3JvdGU6Cj4gT24gMjAxOC0xMC0wMSAxMzoyOSwgU2VhbiBQYXVsIHdyb3RlOgo+ID4gT24g V2VkLCBTZXAgMjYsIDIwMTggYXQgMTE6NTE6MzVBTSAtMDcwMCwgSmV5a3VtYXIgU2Fua2FyYW4g d3JvdGU6Cj4gPiA+IE9uIDIwMTgtMDktMTkgMTE6NTYsIFNlYW4gUGF1bCB3cm90ZToKPiA+ID4g PiBGcm9tOiBTZWFuIFBhdWwgPHNlYW5wYXVsQGNocm9taXVtLm9yZz4KPiA+ID4gPgo+ID4gPiA+ IFRoZXJlIGV4aXN0cyBhIGNhc2Ugd2hlcmUgYSBmbHVzaCBvZiBhIHBsYW5lL2RtYSBtYXkgaGF2 ZSBiZWVuCj4gPiB0cmlnZ2VyZWQKPiA+ID4gPiAmIHN0YXJ0ZWQgZnJvbSBhbiBhc3luYyBjb21t aXQuIElmIHRoYXQgcGxhbmUvZG1hIGlzIHN1YnNlcXVlbnRseQo+ID4gPiA+IGRpc2FibGVkCj4g PiA+ID4gYnkgdGhlIG5leHQgY29tbWl0LCB0aGUgZmx1c2ggcmVnaXN0ZXIgd2lsbCBjb250aW51 ZSB0byBob2xkIHRoZSBmbHVzaAo+ID4gPiA+IGJpdCBmb3IgdGhlIGRpc2FibGVkIHBsYW5lLiBT aW5jZSB0aGUgYml0IHJlbWFpbnMgYWN0aXZlLAo+ID4gPiA+IHBlbmRpbmdfa2lja29mZl9jbnQg d2lsbCBuZXZlciBkZWNyZW1lbnQgYW5kIHdlJ2xsIG1pc3MgZnJhbWVfZG9uZQo+ID4gPiA+IGV2 ZW50cy4KPiA+ID4gPgo+ID4gPiBJIHN1cHBvc2UgdGhpcyBpcyB0aGUgdmJsYW5rIGluIGJldHdl ZW4gdGhlIGFzeW5jIGNvbW1pdCBhbmQgdGhlIG5leHQKPiA+IGNvbW1pdAo+ID4gPiAob25lIHdo ZXJlCj4gPiA+IHRoZSBwbGFuZSBpcyBkaXNhYmxlZCkuCj4gPiA+IAo+ID4gPiBJZiB0aGlzIHZi bGFuayBoYWQgY29uc3VtZWQgdGhlIGZsdXNoIGJpdHMsIGl0IG1lYW5zIHRoZSBIVwo+ID4gPiBo YXMgcmVhZCB0aGUgY29uZmlndXJhdGlvbiBhbmQgaXQgc2hvdWxkIGhhdmUgY2xlYXJlZCBiaXRz Lgo+ID4gPiAKPiA+ID4gSWYgeW91IHN0aWxsIHNlZSB0aGUgZmx1c2ggYml0IGFjdGl2ZSwgaXQg bWVhbnMgdGhlIGFzeW5jIGNvbW1pdCBoYXMKPiA+IG1pc3NlZAo+ID4gPiB0aGUgVkJMQU5LIGJv dW5kYXJ5Cj4gPiA+IGFuZCB0aGUgSFcgaGFzIG5vdCB5ZXQgdGFrZW4gdGhlIGN1cnNvciBjb25m aWd1cmF0aW9uLiBTbyB5b3UgYXJlIG5vdAo+ID4gPiBzdXBwb3NlZCB0bwo+ID4gPiBnZXQgZnJh bWVfZG9uZSBldmVudC4KPiA+IAo+ID4gUmlnaHQsIHdlJ3JlIG5vdCBnZXR0aW5nIGZyYW1lX2Rv bmUgdW50aWwgdGhlIG5leHQgZnJhbWUgY29tZXMgaW4uIFRoZQo+ID4gaXNzdWUgaXMKPiA+IHRo YXQgd2UgZ2V0IDIgY29tbWl0cyBpbiBiZXR3ZWVuIHZibGFua3MsIHRoZSBmaXJzdCBjb21taXQg dHJpZ2dlcnMgdGhlCj4gPiBjdXJzb3IKPiA+IGZvciBmbHVzaCBhbmQgdGhlIHNlY29uZCBvbmUg ZGlzYWJsZXMgaXQuIFVuZm9ydHVuYXRlbHkgdGhlIGZpcnN0IGNvbW1pdAo+ID4gaGFzCj4gPiBh bHJlYWR5IGNhbGxlZCBDVExfU1RBUlQgYW5kIG1hZGUgaXQgaW1wb3NzaWJsZSBmb3IgdGhlIHNl Y29uZCBjb21taXQgdG8KPiA+IGNsZWFyCj4gPiB0aGF0IGZsdXNoIGJpdCAoYWZhaWN0KS4KPiA+ IAo+ID4gVGhlIGZyYW1lX2RvbmUgZXZlbnRzIHNlZW0gdG8gZmxvdyBwcm9wZXJseSwgb25seSBi ZWluZyB0cmlnZ2VyZWQgb25jZQo+ID4gcGVyCj4gPiB2YmxhbmsgYW5kIG9ubHkgd2hlbiBhIG5v bi1hc3luYyBjb21taXQgaGFzIGhhcHBlbmVkLgo+ID4gCj4gPiBTbyBpcyB0aGVyZSBhIHdheSB0 byBjbGVhciB0aGUgQ1RMX0ZMVVNIIHJlZ2lzdGVyIG9uIHN1YnNlcXVlbnQgY29tbWl0cz8KPiA+ IEkndmUKPiA+IHBva2VkIGFyb3VuZCBzb21lIG1vcmUgYW5kIGNhbid0IHNlZW0gdG8gZmlndXJl IGl0IG91dC4KPiA+IAo+IFdlIHNob3VsZG4ndCBiZSBleHBsaWNpdGx5IGNsZWFyaW5nIHRoZSBG TFVTSCByZWdpc3Rlci4gVW5jbGVhcmVkIGZsdXNoIGJpdHMKPiBnZW5lcmFsbHkgaW5kaWNhdGVz IHRoYXQgdGhlIGNvbmZpZyBpcyBub3QgcHJvZ3JhbW1lZCB5ZXQuIFdoYXQgaXMgdGhlCj4gb2Jz ZXJ2YXRpb24gaWYgdGhlcmUgaXMgbm8gZm9sbG93dXAgbm9uLWFzeW5jIGNvbW1pdD8gQXJlIHlv dSBzZWVpbmcgYSBoYW5nCj4gb3IgZGVsYXkgaW4gZnJhbWVfZG9uZT8gCgpUaGVyZSdzIG5vIHBy b2JsZW1zIGlmIHRoZXJlIGlzIG5vIGZvbGxvd3VwLiBQZXJoYXBzIHRoZSBpc3N1ZSBpcyBiZXR0 ZXIKaWxsdXN0cmF0ZWQgd2l0aCBzb21lIHRyYWNpbmcuIFRoZSBmb2xsb3dpbmcgYXJlIHRyYWNl cyB3aGVuIGNocm9tZSBjaGFuZ2VzIHRoZQpVSSBhbmQgaGlkZXMgdGhlIGN1cnNvciBhdCB0aGUg c2FtZSB0aW1lLgoKCjE4Mi42MDc1MTU6IGRwdV9od19jdGxfY2xlYXJfcGVuZGluZ19mbHVzaDog cGVuZGluZ19tYXNrPTEwMjAwYzEgQ1RMX0ZMVVNIPTAKMTgyLjYwNzU2OTogZHB1X2h3X2N0bF91 cGRhdGVfcGVuZGluZ19mbHVzaDogbmV3PTEwMjAwNDEgZXhpc3Rpbmc9MAoxODIuNjA3NTgxOiBk cHVfaHdfY3RsX3VwZGF0ZV9wZW5kaW5nX2ZsdXNoOiBuZXc9MTAyMDA4MSBleGlzdGluZz0xMDIw MDQxCjE4Mi42MDc4MjI6IGRwdV9rbXNfY29tbWl0OiBpZD00NgoxODIuNjA3ODY3OiBkcHVfaHdf Y3RsX3RyaWdnZXJfcGVuZGluZ19mbHVzaDogcGVuZGluZ19tYXNrPTEwMjAwYzEgQ1RMX0ZMVVNI PTAKClRoaXMgaXMgYSBub3JtYWwgYXRvbWljIGNvbW1pdCB3aGVyZSBjaHJvbWUgaXMgcHJvdmlk aW5nIHVwZGF0ZXMgdG8gYm90aCBwbGFuZXMKKHByaW1hcnkgYW5kIGN1cnNvcikuIFdlIGNsZWFy IHRoZSBwZW5kaW5nIGZsdXNoIG1hc2ssIGZpZ3VyZSBvdXQgd2hpY2ggcGxhbmVzCm5lZWQgdG8g YmUgZmx1c2hlZCBhbmQgdHJpZ2dlciB0aGUgZmx1c2guCgoKMTgyLjYwNzk5OTogZHB1X2h3X2N0 bF9jbGVhcl9wZW5kaW5nX2ZsdXNoOiBwZW5kaW5nX21hc2s9MTAyMDBjMSBDVExfRkxVU0g9MTAy MDBjMQoxODIuNjA4MDQyOiBkcHVfaHdfY3RsX3VwZGF0ZV9wZW5kaW5nX2ZsdXNoOiBuZXc9MjAw NDEgZXhpc3Rpbmc9MAoxODIuNjA4MDU0OiBkcHVfaHdfY3RsX3VwZGF0ZV9wZW5kaW5nX2ZsdXNo OiBuZXc9MjAwODEgZXhpc3Rpbmc9MjAwNDEKMTgyLjYwODEzNjogZHB1X3BsYW5lX2Rpc2FibGU6 IGlkOjQyIGlzX3ZpcnR1YWw6ZmFsc2UgbXVsdGlyZWN0X21vZGU6MAoxODIuNjA4MjIyOiBkcHVf a21zX2NvbW1pdDogaWQ9NDYKMTgyLjYwODI0NjogZHB1X2h3X2N0bF90cmlnZ2VyX3BlbmRpbmdf Zmx1c2g6IHBlbmRpbmdfbWFzaz0yMDBjMSBDVExfRkxVU0g9MTAyMDBjMQoKVGhpcyBjb21taXQg Y29tZXMgaW4gYXN5bmNocm9ub3VzbHkgYmVmb3JlIHZibGFuayBhbmQgZGlzYWJsZXMgdGhlIGN1 cnNvci4gQXMKeW91IGNhbiBzZWUsIENUTF9GTFVTSCBpcyBzdGlsbCBzZXQgYXQgMTAyMDBjMSBm cm9tIHRoZSBwcmV2aW91cyBjb21taXQgd2hlbgp3ZSBmaXJzdCBjbGVhciB0aGUgcGVuZGluZyBt YXNrLiBUaGUgbmV3IG1hc2sgZHJvcHMgYml0IDI0IChETUEyKSBhbmQgd3JpdGVzCjIwMGMxICh0 aGUgY3VycmVudCB2YWx1ZSBvZiBwZW5kaW5nX21hc2spIHRvIENUTF9GTFVTSC4KCjE4Mi42MDk5 MjQ6IGRwdV9lbmNfcGh5c192aWRfdmJsYW5rOiBtYXNrPTAsIHJlZ2lzdGVyPTEwMDAwMDAgICAg ICAgICAgICAgICAgICAgICAKCldoZW4gdGhlIHZibGFuayBkb2VzIGNvbWUgaW4sIHRoZSBoYXJk d2FyZSBoYXMgZmx1c2hlZCB0aGUgdmlzaWJsZSBwbGFuZXMsIGJ1dApDVExfRkxVU0ggc3RpbGwg Y29udGFpbnMgdGhlIGJpdCBmb3IgRE1BMiBzaW5jZSBpdCB3YXMgbm90IGZsdXNoZWQuIFRoZSBj cml0ZXJpYQpmb3IgZnJhbWVfZG9uZSBpcyB0aGF0IHRoZSBiaXR3aXNlICYgb2YgdGhlIENUTF9G TFVTSCBhbmQgcGVuZGluZ19tYXNrLiBTaW5jZQpwZW5kaW5nIG1hc2sgZG9lc24ndCBjb250YWlu IERNQTEgYW5kIHRoZSBmbHVzaCByZWdpc3RlciBkb2VzLCB3ZSBkb24ndCBnZXQgYQpmcmFtZV9k b25lIGZvciB0aGUgY29tbWl0LgoKClNvIHRoZXJlIGFyZSAyIHdheXMgdG8gc29sdmUgdGhpcywg YWZhaWN0OgoKMS0gQ2xlYXIgQ1RMX0ZMVVNIIHdoZW4gd2UgY2xlYXIgcGVuZGluZyBmbHVzaC4g QUZBSUNULCB0aGVyZSdzIG5vIGdvb2Qgd2F5IHRvCiAgIGRvIHRoaXMsIGFuZCBpdCdzIGluaGVy ZW50bHkgcmFjeSB3aXRoIHZibGFuay4KMi0gRW5zdXJlIHRoYXQgdGhlIGJpdHMgd2UgY2FyZSBh Ym91dCBpbiBwZW5kaW5nX2ZsdXNoX21hc2sgYXJlIGNsZWFyZWQgYXMgYQogICBjcml0ZXJpYSBm b3IgZnJhbWVfZG9uZS4KCkknbSBjZXJ0YWlubHkgb3BlbiB0byBpZGVhcyBpZiB0aGVyZSdzIGEg YmV0dGVyIHdheSwgaG93ZXZlciBJIGhhdmVuJ3QgZm91bmQgb25lCnlldC4KClNlYW4KCj4gRXZl bnR1YWxseSwgdGhlIG5leHQgVkJMQU5LIHNob3VsZCBwaWNrIHRoZQo+IGNvbmZpZ3VyYXRpb24K PiBhbmQgd2lwZSBvZmYgdGhlIGZsdXNoIHJlZ2lzdGVyIGFuZCB0aGUgdmJsYW5rIGlycSBoYW5k bGVyIHNob3VsZCB0cmlnZ2VyCj4gdGhlIGV2ZW50Lgo+IAo+ID4gPiAKPiA+ID4gQ29tbWVudHMg b3V0c2lkZSB0aGUgc2NvcGUgb2YgdGhpcyBwYXRjaDogVG8gc3VwcG9ydCBhc3luYyBhbmQgc3lu Ywo+ID4gdXBkYXRlcwo+ID4gPiBvbiB0aGUgc2FtZSBkaXNwbGF5IGNvbW1pdCB0aHJlYWQsIHdl IHNob3VsZCBiZSBhZGRpbmcgbW9yZSBwcm90ZWN0aW9uCj4gPiB0bwo+ID4gPiBzdXBwb3J0Cj4g PiA+IGNvbmN1cnJlbmN5IHNjZW5hcmlvcyB0byBhdm9pZCBtb3JlIHRoYW4gb25lIGN0bCBmbHVz aGVzIHBlciBWQkxBTksKPiA+IHBlcmlvZC4KPiA+IAo+ID4gWWVhaCwgY2VydGFpbmx5IGVhc2ll ciBzYWlkIHRoYW4gZG9uZS4gSSdtIG5vdCByZWFsbHkgc3VyZSBob3cgdG8KPiA+IGltcGxlbWVu dAo+ID4gdGhhdCwgdGJoLgo+ID4gCj4gPiBUaGVyZSdzIG5vIHdheSB0byBrbm93IGhvdyBtYW55 IGNvbW1pdHMgeW91J2xsIGhhdmUsIGFuZCB0aGVyZSdzIG5vIHdheQo+ID4gdG8KPiA+IGRlbGF5 IHRoZSBGTFVTSCB1bnRpbCByaWdodCBiZWZvcmUgdmJsYW5rLiBEbyB5b3UgaGF2ZSBhbnkgaWRl YXMgdGhhdCBJCj4gPiBtaWdodCBiZQo+ID4gbWlzc2luZz8KPiA+IAo+IE9uZSB3YXkgdG8gZnJl ZXplIGh3IHJlYWRpbmcgZnJvbSBDVExfRkxVU0ggaXMgYnkgd3JpdGluZyAweDEgdG8KPiBDVExf RkxVU0hfTUFTSy4KPiBUaGlzIGd1YXJhbnRlZXMgbm8gaGFsZi13YXkgcHJvZ3JhbW1lZCBjb21t aXQgaXMgZmx1c2hlZCBieSB0aGUgSFcuCj4gCj4gVGhlIG90aGVyIG1ldGhvZCAtIHByb2JhYmx5 IHRoZSBub24tY29udmVudGlvbmFsIG9uZSAtIHdvdWxkIGJlIHRvIHVwZGF0ZQo+IGN1cnNvciAv IGFzeW5jIGNvbW1pdHMgb3V0c2lkZSB0aGUgZGlzcGxheSBjb21taXQgdGhyZWFkLiBCdXQgb2Zj LCB3ZSBuZWVkCj4gdG8gbWFrZQo+IGFyY2hpdGVjdHVyYWwgY2hhbmdlcyB0byB0aGUgY3VycmVu dCBkcml2ZXIgdG8gc3VwcG9ydCB0aGlzIHBhdGguCj4gCj4gVGhhbmtzLAo+IEpleWt1bWFyIFMu Cj4gPiBTZWFuCj4gPiAKPiA+ID4gCj4gPiA+IFRoYW5rcywKPiA+ID4gSmV5a3VtYXIgUy4KPiA+ ID4gCj4gPiA+IAo+ID4gPiAKPiA+ID4gPiBUaGlzIHBhdGNoIGxpbWl0cyB0aGUgY2hlY2sgb2Yg Zmx1c2hfcmVnaXN0ZXIgdG8gaW5jbHVkZSBvbmx5IHRob3NlCj4gPiBiaXRzCj4gPiA+ID4gd2hp Y2ggaGF2ZSBiZWVuIHVwZGF0ZWQgd2l0aCB0aGUgbGF0ZXN0IGNvbW1pdC4KPiA+ID4gPgo+ID4g PiA+IFNpZ25lZC1vZmYtYnk6IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+ID4g PiA+IC0tLQo+ID4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5jb2Rl cl9waHlzX3ZpZC5jIHwgMiArLQo+ID4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24o KyksIDEgZGVsZXRpb24oLSkKPiA+ID4gPgo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5jb2Rlcl9waHlzX3ZpZC5jCj4gPiA+ID4gYi9kcml2 ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5jb2Rlcl9waHlzX3ZpZC5jCj4gPiA+ID4g aW5kZXggODRkZTM4NWE5ZjYyLi42MGYxNDZmMDJiNzcgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2VuY29kZXJfcGh5c192aWQuYwo+ID4gPiA+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9lbmNvZGVyX3BoeXNfdmlk LmMKPiA+ID4gPiBAQCAtMzMxLDcgKzMzMSw3IEBAIHN0YXRpYyB2b2lkIGRwdV9lbmNvZGVyX3Bo eXNfdmlkX3ZibGFua19pcnEodm9pZAo+ID4gPiA+ICphcmcsCj4gPiA+ID4gaW50IGlycV9pZHgp Cj4gPiA+ID4gIAlpZiAoaHdfY3RsICYmIGh3X2N0bC0+b3BzLmdldF9mbHVzaF9yZWdpc3RlcikK PiA+ID4gPiAgCQlmbHVzaF9yZWdpc3RlciA9IGh3X2N0bC0+b3BzLmdldF9mbHVzaF9yZWdpc3Rl cihod19jdGwpOwo+ID4gPiA+Cj4gPiA+ID4gLQlpZiAoZmx1c2hfcmVnaXN0ZXIgPT0gMCkKPiA+ ID4gPiArCWlmICghKGZsdXNoX3JlZ2lzdGVyICYgaHdfY3RsLT5vcHMuZ2V0X3BlbmRpbmdfZmx1 c2goaHdfY3RsKSkpCj4gPiA+ID4gIAkJbmV3X2NudCA9Cj4gPiA+ID4gYXRvbWljX2FkZF91bmxl c3MoJnBoeXNfZW5jLT5wZW5kaW5nX2tpY2tvZmZfY250LAo+ID4gPiA+ICAJCQkJLTEsIDApOwo+ ID4gPiA+ICAJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZShwaHlzX2VuYy0+ZW5jX3NwaW5sb2NrLCBs b2NrX2ZsYWdzKTsKPiA+ID4gCj4gPiA+IC0tCj4gPiA+IEpleWt1bWFyIFMKPiAKPiAtLSAKPiBK ZXlrdW1hciBTCgotLSAKU2VhbiBQYXVsLCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hy b21pdW0gT1MKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K RnJlZWRyZW5vIG1haWxpbmcgbGlzdApGcmVlZHJlbm9AbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZnJlZWRyZW5vCg==