public inbox for linux-arm-msm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Paul <sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
To: Bruce Wang <bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 4/4] drm/msm/dpu: Remove suspend_state from dpu_kms
Date: Fri, 5 Oct 2018 14:05:00 -0400	[thread overview]
Message-ID: <20181005180500.GO72545@art_vandelay> (raw)
In-Reply-To: <20181005154843.172326-5-bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

On Fri, Oct 05, 2018 at 11:48:43AM -0400, Bruce Wang wrote:
> The suspend_state field is no longer used and can be removed along with
> dpu_kms_is_suspend_state.
> 

This can be rolled up into patch 3, since that's where the usage of these is
being removed.

Sean

> Signed-off-by: Bruce Wang <bzwang@chromium.org>
> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
> index 1991cbe424a3..2a3625eef6d3 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
> @@ -135,9 +135,6 @@ struct dpu_kms {
>  
>  	struct dpu_core_perf perf;
>  
> -	/* saved atomic state during system suspend */
> -	struct drm_atomic_state *suspend_state;
> -
>  	struct dpu_rm rm;
>  	bool rm_init;
>  
> @@ -162,19 +159,6 @@ struct vsync_info {
>  #define ddev_to_msm_kms(D) ((D) && (D)->dev_private ? \
>  		((struct msm_drm_private *)((D)->dev_private))->kms : NULL)
>  
> -/**
> - * dpu_kms_is_suspend_state - whether or not the system is pm suspended
> - * @dev: Pointer to drm device
> - * Return: Suspend status
> - */
> -static inline bool dpu_kms_is_suspend_state(struct drm_device *dev)
> -{
> -	if (!ddev_to_msm_kms(dev))
> -		return false;
> -
> -	return to_dpu_kms(ddev_to_msm_kms(dev))->suspend_state != NULL;
> -}
> -
>  /**
>   * Debugfs functions - extra helper functions for debugfs support
>   *
> -- 
> 2.19.0.605.g01d371f741-goog
> 

-- 
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

      parent reply	other threads:[~2018-10-05 18:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05 15:48 [PATCH 0/4] drm/msm: Use atomic helpers for PM suspend/resume Bruce Wang
     [not found] ` <20181005154843.172326-1-bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-10-05 15:48   ` [PATCH 1/4] drm/msm/dpu: Remove dpu_kms_pm_suspend/resume Bruce Wang
     [not found]     ` <20181005154843.172326-2-bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-10-05 17:27       ` Sean Paul
2018-10-05 17:35         ` Sean Paul
2018-10-05 15:48   ` [PATCH 2/4] drm/msm: Cut dpu_kms hooks from msm_pm_suspend/resume Bruce Wang
     [not found]     ` <20181005154843.172326-3-bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-10-05 17:34       ` Sean Paul
2018-10-05 15:48   ` [PATCH 3/4] drm/msm/dpu: Remove suspend state tracking from crtc Bruce Wang
     [not found]     ` <20181005154843.172326-4-bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-10-05 18:04       ` Sean Paul
2018-10-05 15:48   ` [PATCH 4/4] drm/msm/dpu: Remove suspend_state from dpu_kms Bruce Wang
     [not found]     ` <20181005154843.172326-5-bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-10-05 18:05       ` Sean Paul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181005180500.GO72545@art_vandelay \
    --to=sean-p7ytbzm4h96eqtr555yldq@public.gmane.org \
    --cc=abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox