From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v3 4/4] drm/msm/dpu: Replace dpu_crtc_reset by atomic helper Date: Mon, 8 Oct 2018 13:07:47 -0400 Message-ID: <20181008170747.GC154160@art_vandelay> References: <20181005210403.54615-1-bzwang@chromium.org> <20181005210403.54615-5-bzwang@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181005210403.54615-5-bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Bruce Wang Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gRnJpLCBPY3QgMDUsIDIwMTggYXQgMDU6MDQ6MDNQTSAtMDQwMCwgQnJ1Y2UgV2FuZyB3cm90 ZToKPiBTaW5jZSB3ZSByZW1vdmVkIGFsbCBzdXNwZW5kIGxvZ2ljIGZyb20gdGhlIGNydGMgY29k ZSAoc2VlIHBhdGNoIDMvNCksCj4gZHB1X2NydGNfcmVzZXQgZG9lcyB0aGUgc2FtZSB0aGluZ3Mg YXMgZHJtX2F0b21pY19oZWxwZXJfY3J0Y19yZXNldCwgc28gbGV0J3MKPiBqdXN0IHJlcGxhY2Ug aXQgd2l0aCBhIGNhbGwgdG8gdGhlIGF0b21pYyBoZWxwZXIuCj4gCj4gdjM6IGFkZGVkIHBhdGNo IHRvIHBhdGNoc2V0Cj4gCj4gU2lnbmVkLW9mZi1ieTogQnJ1Y2UgV2FuZyA8Ynp3YW5nQGNocm9t aXVtLm9yZz4KCkFsbGxsbGxscmlnaHQhCgpSZXZpZXdlZC1ieTogU2VhbiBQYXVsIDxzZWFucGF1 bEBjaHJvbWl1bS5vcmc+CgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEv ZHB1X2NydGMuYyB8IDM5ICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdl ZCwgMSBpbnNlcnRpb24oKyksIDM4IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJtL21z bS9kaXNwL2RwdTEvZHB1X2NydGMuYwo+IGluZGV4IGFjNjA0MDU1YTgyNC4uYzViYTc1M2Q0NDFj IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9jcnRjLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfY3J0Yy5jCj4gQEAgLTg0 NCw0MyArODQ0LDYgQEAgc3RhdGljIHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqZHB1X2NydGNfZHVw bGljYXRlX3N0YXRlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiAgCXJldHVybiAmY3N0YXRlLT5i YXNlOwo+ICB9Cj4gIAo+IC0vKioKPiAtICogZHB1X2NydGNfcmVzZXQgLSByZXNldCBob29rIGZv ciBDUlRDcwo+IC0gKiBSZXNldHMgdGhlIGF0b21pYyBzdGF0ZSBmb3IgQGNydGMgYnkgZnJlZWlu ZyB0aGUgc3RhdGUgcG9pbnRlciAod2hpY2ggbWlnaHQKPiAtICogYmUgTlVMTCwgZS5nLiBhdCBk cml2ZXIgbG9hZCB0aW1lKSBhbmQgYWxsb2NhdGluZyBhIG5ldyBlbXB0eSBzdGF0ZSBvYmplY3Qu Cj4gLSAqIEBjcnRjOiBQb2ludGVyIHRvIGRybSBjcnRjIHN0cnVjdHVyZQo+IC0gKi8KPiAtc3Rh dGljIHZvaWQgZHB1X2NydGNfcmVzZXQoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+IC17Cj4gLQlz dHJ1Y3QgZHB1X2NydGMgKmRwdV9jcnRjOwo+IC0Jc3RydWN0IGRwdV9jcnRjX3N0YXRlICpjc3Rh dGU7Cj4gLQo+IC0JaWYgKCFjcnRjKSB7Cj4gLQkJRFBVX0VSUk9SKCJpbnZhbGlkIGNydGNcbiIp Owo+IC0JCXJldHVybjsKPiAtCX0KPiAtCj4gLQkvKiByZXZlcnQgc3VzcGVuZCBhY3Rpb25zLCBp ZiBuZWNlc3NhcnkgKi8KPiAtCWlmIChkcHVfa21zX2lzX3N1c3BlbmRfc3RhdGUoY3J0Yy0+ZGV2 KSkKPiAtCQlfZHB1X2NydGNfc2V0X3N1c3BlbmQoY3J0YywgZmFsc2UpOwo+IC0KPiAtCS8qIHJl bW92ZSBwcmV2aW91cyBzdGF0ZSwgaWYgcHJlc2VudCAqLwo+IC0JaWYgKGNydGMtPnN0YXRlKSB7 Cj4gLQkJZHB1X2NydGNfZGVzdHJveV9zdGF0ZShjcnRjLCBjcnRjLT5zdGF0ZSk7Cj4gLQkJY3J0 Yy0+c3RhdGUgPSAwOwo+IC0JfQo+IC0KPiAtCWRwdV9jcnRjID0gdG9fZHB1X2NydGMoY3J0Yyk7 Cj4gLQljc3RhdGUgPSBremFsbG9jKHNpemVvZigqY3N0YXRlKSwgR0ZQX0tFUk5FTCk7Cj4gLQlp ZiAoIWNzdGF0ZSkgewo+IC0JCURQVV9FUlJPUigiZmFpbGVkIHRvIGFsbG9jYXRlIHN0YXRlXG4i KTsKPiAtCQlyZXR1cm47Cj4gLQl9Cj4gLQo+IC0JY3N0YXRlLT5iYXNlLmNydGMgPSBjcnRjOwo+ IC0JY3J0Yy0+c3RhdGUgPSAmY3N0YXRlLT5iYXNlOwo+IC19Cj4gLQo+ICBzdGF0aWMgdm9pZCBk cHVfY3J0Y19oYW5kbGVfcG93ZXJfZXZlbnQodTMyIGV2ZW50X3R5cGUsIHZvaWQgKmFyZykKPiAg ewo+ICAJc3RydWN0IGRybV9jcnRjICpjcnRjID0gYXJnOwo+IEBAIC0xNDk5LDcgKzE0NjIsNyBA QCBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9jcnRjX2Z1bmNzIGRwdV9jcnRjX2Z1bmNzID0gewo+ ICAJLnNldF9jb25maWcgPSBkcm1fYXRvbWljX2hlbHBlcl9zZXRfY29uZmlnLAo+ICAJLmRlc3Ry b3kgPSBkcHVfY3J0Y19kZXN0cm95LAo+ICAJLnBhZ2VfZmxpcCA9IGRybV9hdG9taWNfaGVscGVy X3BhZ2VfZmxpcCwKPiAtCS5yZXNldCA9IGRwdV9jcnRjX3Jlc2V0LAo+ICsJLnJlc2V0ID0gZHJt X2F0b21pY19oZWxwZXJfY3J0Y19yZXNldCwKPiAgCS5hdG9taWNfZHVwbGljYXRlX3N0YXRlID0g ZHB1X2NydGNfZHVwbGljYXRlX3N0YXRlLAo+ICAJLmF0b21pY19kZXN0cm95X3N0YXRlID0gZHB1 X2NydGNfZGVzdHJveV9zdGF0ZSwKPiAgCS5sYXRlX3JlZ2lzdGVyID0gZHB1X2NydGNfbGF0ZV9y ZWdpc3RlciwKPiAtLSAKPiAyLjE5LjAuNjA1LmcwMWQzNzFmNzQxLWdvb2cKPiAKCi0tIApTZWFu IFBhdWwsIFNvZnR3YXJlIEVuZ2luZWVyLCBHb29nbGUgLyBDaHJvbWl1bSBPUwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpGcmVlZHJlbm8gbWFpbGluZyBs aXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJlbm8K