From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [Freedreno] [PATCH 01/25] drm/msm/dpu: fix hw ctl retrieval for mixer muxing Date: Wed, 10 Oct 2018 10:29:57 -0400 Message-ID: <20181010142957.GR154160@art_vandelay> References: <1539059262-8326-1-git-send-email-jsanka@codeaurora.org> <1539059262-8326-2-git-send-email-jsanka@codeaurora.org> <20181009180700.GG154160@art_vandelay> <0d88c6600ede8b2dfb5c88147398f484@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <0d88c6600ede8b2dfb5c88147398f484@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jeykumar Sankaran Cc: Sean Paul , dri-devel@lists.freedesktop.org, hoegsberg@google.com, linux-arm-msm@vger.kernel.org, seanpaul@chromium.org, freedreno@lists.freedesktop.org List-Id: linux-arm-msm@vger.kernel.org T24gVHVlLCBPY3QgMDksIDIwMTggYXQgMTA6NDY6NDFQTSAtMDcwMCwgSmV5a3VtYXIgU2Fua2Fy YW4gd3JvdGU6Cj4gT24gMjAxOC0xMC0wOSAxMTowNywgU2VhbiBQYXVsIHdyb3RlOgo+ID4gT24g TW9uLCBPY3QgMDgsIDIwMTggYXQgMDk6Mjc6MThQTSAtMDcwMCwgSmV5a3VtYXIgU2Fua2FyYW4g d3JvdGU6Cj4gPiA+IExheWVyIG1peGVyL3Bpbmdwb25nIGJsb2NrIGNvdW50cyBhbmQgaHcgY3Rs IGJsb2NrIGNvdW50cwo+ID4gPiB3aWxsIG5vdCBiZSBzYW1lIGZvciBhbGwgdGhlIHRvcG9sb2dp ZXMgKGUuZy4gbGF5ZXIKPiA+ID4gbWl4ZXIgbXV4aW5nIHRvIHNpbmdsZSBpbnRlcmZhY2UpCj4g PiA+IAo+ID4gPiBVc2UgdGhlIGVuY29kZXIncyBzcGxpdF9yb2xlIGluZm8gdG8gcmV0cmlldmUg dGhlCj4gPiA+IHJlc3BlY3RpdmUgY29udHJvbCBwYXRoIGZvciBwcm9ncmFtbWluZy4KPiA+ID4g Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IEpleWt1bWFyIFNhbmthcmFuIDxqc2Fua2FAY29kZWF1cm9y YS5vcmc+Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1 X2VuY29kZXIuYyB8IDkgKysrKysrLS0tCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRp b25zKCspLCAzIGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9lbmNvZGVyLmMKPiA+IGIvZHJpdmVycy9ncHUvZHJt L21zbS9kaXNwL2RwdTEvZHB1X2VuY29kZXIuYwo+ID4gPiBpbmRleCA5NmNkZjA2Li5kMTJmODk2 IDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5j b2Rlci5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9lbmNv ZGVyLmMKPiA+ID4gQEAgLTEwNjAsNiArMTA2MCw3IEBAIHN0YXRpYyB2b2lkIGRwdV9lbmNvZGVy X3ZpcnRfbW9kZV9zZXQoc3RydWN0Cj4gPiBkcm1fZW5jb2RlciAqZHJtX2VuYywKPiA+ID4gCj4g PiA+ICAJZm9yIChpID0gMDsgaSA8IGRwdV9lbmMtPm51bV9waHlzX2VuY3M7IGkrKykgewo+ID4g PiAgCQlzdHJ1Y3QgZHB1X2VuY29kZXJfcGh5cyAqcGh5cyA9IGRwdV9lbmMtPnBoeXNfZW5jc1tp XTsKPiA+ID4gKwkJaW50IGN0bF9pbmRleDsKPiA+ID4gCj4gPiA+ICAJCWlmIChwaHlzKSB7Cj4g PiA+ICAJCQlpZiAoIWRwdV9lbmMtPmh3X3BwW2ldKSB7Cj4gPiA+IEBAIC0xMDY4LDE0ICsxMDY5 LDE2IEBAIHN0YXRpYyB2b2lkIGRwdV9lbmNvZGVyX3ZpcnRfbW9kZV9zZXQoc3RydWN0Cj4gPiBk cm1fZW5jb2RlciAqZHJtX2VuYywKPiA+ID4gIAkJCQlyZXR1cm47Cj4gPiA+ICAJCQl9Cj4gPiA+ IAo+ID4gPiAtCQkJaWYgKCFod19jdGxbaV0pIHsKPiA+ID4gKwkJCWN0bF9pbmRleCA9IHBoeXMt PnNwbGl0X3JvbGUgPT0gRU5DX1JPTEVfU0xBVkUgPyAxCj4gPiA6IDA7Cj4gPiA+ICsKPiA+IAo+ ID4gV2hhdCBpZiBNQVhfQ0hBTk5FTFNfUEVSX0VOQyBpc24ndCAyPyBTaW1pbGFybHksIHdoYXQg aWYgbnVtX3BoeXNfZW5jcyA+Cj4gPiBNQVhfQ0hBTk5FTFNfUEVSX0VOQz8gSXQgc2VlbXMgbGlr ZSB0aGVyZSBzaG91bGQgYmUgYSBtb3JlIGZvcm1hbAo+ID4gcmVsYXRpb25zaGlwCj4gPiBiZXR3 ZWVuIGFsbCBvZiB0aGVzZSB2ZXJpb3VzIHZhbHVlcyAobnVtX29mX2hfdGlsZXMgYXNzdW1lZCB0 byBiZSA8PSAyCj4gPiBhcwo+ID4gd2VsbCkuCj4gPiBJZiBvbmUgb2YgdGhlbSBjaGFuZ2VzIGJl eW9uZCB0aGUgYXNzdW1lZCBib3VuZCwgdGhlIHJlc3Qgb2YgdGhlIGRyaXZlcgo+ID4gZmFsbHMK PiA+IG92ZXIgcHJldHR5IGhhcmQuCj4gPiAKPiBNQVhfQ0hBTk5FTFNfUEVSX0VOQyBpcyBzZXQg dG8gMiB0byByZXByZXNlbnQgSFcgbGltaXRhdGlvbiBvbiB0aGUgY2hpcHNldAo+IGFzCj4gd2Ug Y2Fubm90IGdhbmcgdXAgbW9yZSB0aGFuIDIgTE0gY2hhaW4gdG8gYW4gaW50ZXJmYWNlLiBTdXBw b3J0aW5nIG1vcmUgdGhhbgo+IDIKPiBtaWdodCBkZW1hbmQgbXVjaCBsYXJnZXIgY2hhbmdlcyB0 aGFuIHZhbGlkYXRpbmcgZm9yIGJvdW5kYXJpZXMuCj4gCj4gbnVtX3BoeXNfZW5jIGlzIHRoZSBt YXggbm8gb2YgcGh5cyBlbmNvZGVycyB3ZSBjcmVhdGUgYXMgd2UgYXJlIGxvb3BpbmcKPiB0aHJv dWdoCj4gbnVtX29mX2hfdGlsZXMgd2hpY2ggY2Fubm90IGJlIG1vcmUgdGhhbiBwcml2LT5kc2kg YXJyYXkgc2l6ZS4KPiAKPiBTbyBpdHMgdmVyeSB1bmxpa2VseSB3ZSB3b3VsZCBleHBlY3QgdGhl c2UgbG9vcHMgdG8gZ28gb3V0IG9mIGJvdW5kIQoKRm9yIG5vdywgc3VyZS4gSG93ZXZlciBhIG5l dyByZXZpc2lvbiBvZiBoYXJkd2FyZSB3aWxsIGJlIGEgcGFpbiB0byBhZGQgc3VwcG9ydApmb3Ig aWYgd2UgYWRkIG1vcmUgYXNzdW1wdGlvbnMsIGFuZCBzZWNvbmRseSBpdCBtYWtlcyBpdCBfcmVh bGx5XyBoYXJkIHRvCnVuZGVyc3RhbmQgdGhlIGNvZGUgaWYgeW91IGRvbid0IGhhdmUgUXVhbGNv bW0gZW1wbG95ZWUtbGV2ZWwgYWNjZXNzIHRvIHRoZQpoYXJkd2FyZSBkZXNpZ24gOikuCgpTbyB0 aGlzIGlzIHdoeSBJJ20gYWR2b2NhdGluZyBmb3IgdGhlIHJlZHVjdGlvbiBvZiB0aGUgbnVtYmVy IG9mICJudW1fb2ZfIgp2YWx1ZXMgd2UgYXNzdW1lIGFyZSBhbGwgaW4gdGhlIHNhbWUgcmFuZ2Uu IEl0J3MgYSBsb3QgZWFzaWVyIHRvIHVuZGVyc3RhbmQgdGhlCmhhcmR3YXJlIHdoZW4geW91IGNh biBzZWUgdGhhdCBhIHBoeXMgZW5jb2RlciBpcyBuZWVkZWQgcGVyIGggdGlsZSwgYW5kIHRoYXQg YQpjdGwvcHAgaXMgbmVlZGVkIHBlciBwaHlzIGVuY29kZXIuCgpBbnl3YXlzLCBqdXN0IG15ICQw LjAyLgoKU2VhbgoKPiAKPiBUaGFua3MsCj4gSmV5a3VtYXIgUy4KPiA+IAo+ID4gPiArCQkJaWYg KCFod19jdGxbY3RsX2luZGV4XSkgewo+ID4gPiAgCQkJCURQVV9FUlJPUl9FTkMoZHB1X2VuYywg Im5vIGN0bCBibG9jawo+ID4gYXNzaWduZWQiCj4gPiA+IC0JCQkJCSAgICAgImF0IGlkeDogJWRc biIsIGkpOwo+ID4gPiArCQkJCQkgICAgICJhdCBpZHg6ICVkXG4iLCBjdGxfaW5kZXgpOwo+ID4g PiAgCQkJCXJldHVybjsKPiA+IAo+ID4gV2hlbiB5b3UgcmV0dXJuIG9uIGVycm9yIGhlcmUsIHNo b3VsZCB5b3UgZ2l2ZSBiYWNrIHRoZSByZXNvdXJjZXMgdGhhdAo+ID4geW91J3ZlCj4gPiBhbHJl YWR5IHByb3Zpc2lvbmVkPwo+ID4gCj4gPiA+ICAJCQl9Cj4gPiA+IAo+ID4gPiAgCQkJcGh5cy0+ aHdfcHAgPSBkcHVfZW5jLT5od19wcFtpXTsKPiA+ID4gLQkJCXBoeXMtPmh3X2N0bCA9IGh3X2N0 bFtpXTsKPiA+ID4gKwkJCXBoeXMtPmh3X2N0bCA9IGh3X2N0bFtjdGxfaW5kZXhdOwo+ID4gPiAK PiA+ID4gIAkJCXBoeXMtPmNvbm5lY3RvciA9IGNvbm4tPnN0YXRlLT5jb25uZWN0b3I7Cj4gPiA+ ICAJCQlpZiAocGh5cy0+b3BzLm1vZGVfc2V0KQo+ID4gPiAtLQo+ID4gPiBUaGUgUXVhbGNvbW0g SW5ub3ZhdGlvbiBDZW50ZXIsIEluYy4gaXMgYSBtZW1iZXIgb2YgdGhlIENvZGUgQXVyb3JhCj4g PiBGb3J1bSwKPiA+ID4gYSBMaW51eCBGb3VuZGF0aW9uIENvbGxhYm9yYXRpdmUgUHJvamVjdAo+ ID4gPiAKPiA+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPiA+ID4gRnJlZWRyZW5vIG1haWxpbmcgbGlzdAo+ID4gPiBGcmVlZHJlbm9AbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCj4gPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZnJlZWRyZW5vCj4gCj4gLS0gCj4gSmV5a3VtYXIgUwoKLS0gClNlYW4gUGF1bCwg U29mdHdhcmUgRW5naW5lZXIsIEdvb2dsZSAvIENocm9taXVtIE9TCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=