Re: [PATCH] arm64: dts: qcom: sdm845: Add reserve-memory nodes

Sibi Sankar
2018-10-31T05:58:31Z

Hi Doug,
Thanks for the review!

I noticed both the quirks just after sending it out :(, will fix them.

On 2018-10-30 00:07, Doug Anderson wrote:
> Hi,
>
> On Fri, Oct 26, 2018 at 5:28 AM Sibi Sankar <sibis@codeaurora.org>
> wrote:
>>
>> Add reserve-memory nodes for mpss and mba required for
>> remoteproc mss pil.
>>
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> index d3fe012ad84e..f74892e447f9 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> @@ -88,6 +88,16 @@
>> reg = <0 0x86200000 0 0x2d00000>;
>> no-map;
>> };
>> +
>> + mpss_region: reserved-memory@8e000000 {
>> + no-map;
>> + reg = <0 0x8e000000 0 0x7800000>;
>> + };
>> +
>> + mba_region: reserved-memory@96500000 {
>
> nit: All of the other reserved memory in this same section just has
> the node name "memory". Can you please follow suit? Also above.
> This is the kind of thing that Rob H. usually cares about doing right.
>
>> + no-map;
>> + reg = <0 0x96500000 0 0x200000>;
>
> nit: All of the other reserved memory in this same section has "reg"
> above "no-map". It doesn't matter a whole lot, but why not make it
> match everyone else? Also above.
>
>
> -Doug

--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.