public inbox for linux-arm-msm@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian Masney <masneyb@onstation.org>
To: sre@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
	andy.gross@linaro.org, david.brown@linaro.org,
	bjorn.andersson@linaro.org, linus.walleij@linaro.org
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
	jonathan@marek.ca, masneyb@onstation.org
Subject: [PATCH v2 2/7] power: supply: bq24190_charger: add support for bq24192 variant
Date: Wed, 31 Oct 2018 20:11:44 -0400	[thread overview]
Message-ID: <20181101001149.13453-3-masneyb@onstation.org> (raw)
In-Reply-To: <20181101001149.13453-1-masneyb@onstation.org>

From: Jonathan Marek <jonathan@marek.ca>

This patch adds support for the bq24192 variant to bq24190_charger.

Signed-off-by: Jonathan Marek <jonathan@marek.ca>
[masneyb@onstation.org: Changed if statement to a switch based on
feedback from Sebastian Reichel.]
Signed-off-by: Brian Masney <masneyb@onstation.org>
---
 drivers/power/supply/bq24190_charger.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
index b58df04d03b3..44d3aff32885 100644
--- a/drivers/power/supply/bq24190_charger.c
+++ b/drivers/power/supply/bq24190_charger.c
@@ -1637,8 +1637,12 @@ static int bq24190_hw_init(struct bq24190_dev_info *bdi)
 	if (ret < 0)
 		return ret;
 
-	if (v != BQ24190_REG_VPRS_PN_24190 &&
-	    v != BQ24190_REG_VPRS_PN_24192I) {
+	switch (v) {
+	case BQ24190_REG_VPRS_PN_24190:
+	case BQ24190_REG_VPRS_PN_24192:
+	case BQ24190_REG_VPRS_PN_24192I:
+		break;
+	default:
 		dev_err(bdi->dev, "Error unknown model: 0x%02x\n", v);
 		return -ENODEV;
 	}
@@ -1931,6 +1935,7 @@ static const struct dev_pm_ops bq24190_pm_ops = {
 
 static const struct i2c_device_id bq24190_i2c_ids[] = {
 	{ "bq24190" },
+	{ "bq24192" },
 	{ "bq24192i" },
 	{ },
 };
@@ -1939,6 +1944,7 @@ MODULE_DEVICE_TABLE(i2c, bq24190_i2c_ids);
 #ifdef CONFIG_OF
 static const struct of_device_id bq24190_of_match[] = {
 	{ .compatible = "ti,bq24190", },
+	{ .compatible = "ti,bq24192", },
 	{ .compatible = "ti,bq24192i", },
 	{ },
 };
-- 
2.17.2

  parent reply	other threads:[~2018-11-01  0:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01  0:11 [PATCH v2 0/7] ARM: qcom: msm8974-hammerhead: add USB OTG support Brian Masney
2018-11-01  0:11 ` [PATCH v2 1/7] dt-bindings: power: supply: bq24190_charger: add bq24192 and usb-otg-vbus Brian Masney
2018-11-05 21:59   ` Rob Herring
2018-12-05 21:55   ` Sebastian Reichel
2018-11-01  0:11 ` Brian Masney [this message]
2018-12-05 21:56   ` [PATCH v2 2/7] power: supply: bq24190_charger: add support for bq24192 variant Sebastian Reichel
2018-11-01  0:11 ` [PATCH v2 3/7] power: supply: bq24190_charger: add of_match for usb-otg-vbus regulator Brian Masney
2018-12-05 21:56   ` Sebastian Reichel
2018-11-01  0:11 ` [PATCH v2 4/7] power: supply: bq24190_charger: add extcon support for USB OTG Brian Masney
2018-12-05 21:56   ` Sebastian Reichel
2018-11-01  0:11 ` [PATCH v2 5/7] pinctrl: qcom: spmi-gpio: fix gpio-hog related boot issues Brian Masney
2018-11-09  8:59   ` Linus Walleij
2018-11-09 10:22     ` Brian Masney
2018-11-01  0:11 ` [PATCH v2 6/7] ARM: dts: qcom: msm8974: add gpio-ranges Brian Masney
2018-12-07 11:41   ` Brian Masney
2018-11-01  0:11 ` [PATCH v2 7/7] ARM: dts: qcom: msm8974-hammerhead: add USB OTG support Brian Masney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181101001149.13453-3-masneyb@onstation.org \
    --to=masneyb@onstation.org \
    --cc=andy.gross@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathan@marek.ca \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox