From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sean Paul <sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
Subject: Re: [PATCH] drm/msm/dpu: Don't use devm for component
 devices
Date: Fri, 2 Nov 2018 10:39:38 -0400
Message-ID: <20181102143938.GH154160@art_vandelay>
References: <20181102143008.8288-1-jcrouse@codeaurora.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Content-Disposition: inline
In-Reply-To: <20181102143008.8288-1-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/freedreno>,
 <mailto:freedreno-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/freedreno>
List-Post: <mailto:freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
List-Help: <mailto:freedreno-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/freedreno>,
 <mailto:freedreno-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=subscribe>
Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Sender: "Freedreno" <freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
To: Jordan Crouse <jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, jshekhar-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
List-Id: linux-arm-msm@vger.kernel.org

T24gRnJpLCBOb3YgMDIsIDIwMTggYXQgMDg6MzA6MDhBTSAtMDYwMCwgSm9yZGFuIENyb3VzZSB3
cm90ZToKPiBEZXZpY2VzIHRoYXQgYXJlIGJvdW5kIGFzIGNvbXBvbmVudHMgc2hvdWxkIG5vdCB1
c2UgZGV2bSBzaW5jZQo+IGRldmljZSBtYW5hZ2VkIG1lbW9yeSBpcyBub3QgZnJlZWQgd2hlbiB0
aGUgY29tcG9uZW50IGlzCj4gdW5ib3VuZC4KPiAKPiBJbiBwYXJ0aWN1bGFyIHRoaXMgaXMgYW4g
aXNzdWUgaWYgdGhlIGNvbXBvbmVudCBiaW5kIGZhaWxzCj4gZHVlIHRvIGFuIC1FUFJPQkVfREVG
RVIuIEluIHRoaXMgY2FzZSB0aGUgYmluZCB3b3VsZCB0cnkgYWdhaW4KPiBsYXRlciBhbmQgYW55
IGRldm0gbWFuYWdlZCBtZW1vcnkgYWxsb2NhdGVkIGR1cmluZyB0aGUgZm9ybWVyCj4gYWJvcnRl
ZCBhdHRlbXB0IHdvdWxkIGJlIGxlYWtlZCB1bnRpbCB0aGUgZGV2aWNlIGl0c2VsZiB3YXMKPiBk
ZXN0cm95ZWQuIFNpbmNlIGFsbCB0aGUgbWVtb3J5IGFsbG9jYXRlZCBkdXJpbmcgYSBiaW5kCj4g
c2hvdWxkIGJlIGZyZWVkIGR1cmluZyBhbiB1bmJpbmQgKG9yIGJpbmQgZXJyb3IgY2FzZSkgdGhl
cmUgaXNuJ3QKPiBhbnkgcmVhc29uIHRvIHVzZSBkZXZtIGZvciByZXNvdXJjZXMgdGhhdCBoYXZl
IGEgZXhwbGljaXQKPiB0ZWFyZG93biBzdGVwLgo+IAo+IFRoaXMgZG9lc24ndCByZW1vdmUgZGV2
bSBmb3IgYWxsIHJlc291cmNlcyAtIGluIHBhcnRpY3VsYXIKPiBtc21faW9yZW1hcCgpIHN0aWxs
IHVzZXMgZGV2bV9pb3JlbWFwKCkgYnV0IHRoYXRzIGEgZ2VuZXJpYwo+IGlzc3VlIHRoYXQgY2Fu
IGVhc2lseSBiZSBhZGRyZXNzZWQgYXMgYSBjbGVhbnVwIGxhdGVyIGFuZCB0aGUKPiB1bmJpbmQg
Y29kZSBhbHJlYWR5IGRvZXMgdGhlIHJlcXVpc2l0ZSBkZXZtIGNhbGxzIHRvIHVubWFwIGl0Lgo+
IAo+IFNpZ25lZC1vZmYtYnk6IEpvcmRhbiBDcm91c2UgPGpjcm91c2VAY29kZWF1cm9yYS5vcmc+
Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9lbmNvZGVyLmMgfCAg
NCArKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9pb191dGlsLmMgfCAg
NCArLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMuYyAgICAgfCAx
MCArKysrKystLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9tZHNzLmMg
ICAgfCAgOCArKysrKy0tLQo+ICA0IGZpbGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDEy
IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3Av
ZHB1MS9kcHVfZW5jb2Rlci5jIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2Vu
Y29kZXIuYwo+IGluZGV4IDgyYzU1ZWZiNTAwZi4uMjg3ZDRjM2U1OGMzIDEwMDY0NAo+IC0tLSBh
L2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9lbmNvZGVyLmMKPiArKysgYi9kcml2
ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5jb2Rlci5jCj4gQEAgLTIyMjAsMTQgKzIy
MjAsMTQgQEAgc3RydWN0IGRybV9lbmNvZGVyICpkcHVfZW5jb2Rlcl9pbml0KHN0cnVjdCBkcm1f
ZGV2aWNlICpkZXYsCj4gIAlzdHJ1Y3QgZHB1X2VuY29kZXJfdmlydCAqZHB1X2VuYyA9IE5VTEw7
Cj4gIAlpbnQgcmMgPSAwOwo+ICAKPiAtCWRwdV9lbmMgPSBkZXZtX2t6YWxsb2MoZGV2LT5kZXYs
IHNpemVvZigqZHB1X2VuYyksIEdGUF9LRVJORUwpOwo+ICsJZHB1X2VuYyA9IGt6YWxsb2Moc2l6
ZW9mKCpkcHVfZW5jKSwgR0ZQX0tFUk5FTCk7Cj4gIAlpZiAoIWRwdV9lbmMpCj4gIAkJcmV0dXJu
IEVSUl9QVFIoRU5PTUVNKTsKPiAgCj4gIAlyYyA9IGRybV9lbmNvZGVyX2luaXQoZGV2LCAmZHB1
X2VuYy0+YmFzZSwgJmRwdV9lbmNvZGVyX2Z1bmNzLAo+ICAJCQlkcm1fZW5jX21vZGUsIE5VTEwp
Owo+ICAJaWYgKHJjKSB7Cj4gLQkJZGV2bV9rZnJlZShkZXYtPmRldiwgZHB1X2VuYyk7Cj4gKwkJ
a2ZyZWUoZHB1X2VuYyk7Cj4gIAkJcmV0dXJuIEVSUl9QVFIocmMpOwo+ICAJfQo+ICAKPiBkaWZm
IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2lvX3V0aWwuYyBiL2Ry
aXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9pb191dGlsLmMKPiBpbmRleCA4OWVlNGIz
NmJlZmYuLjkwYjUzZTk1MDhmMiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rp
c3AvZHB1MS9kcHVfaW9fdXRpbC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2Rw
dTEvZHB1X2lvX3V0aWwuYwo+IEBAIC0xNTUsOSArMTU1LDcgQEAgaW50IG1zbV9kc3NfcGFyc2Vf
Y2xvY2soc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldiwKPiAgCQlyZXR1cm4gMDsKPiAgCX0K
PiAgCj4gLQltcC0+Y2xrX2NvbmZpZyA9IGRldm1fa3phbGxvYygmcGRldi0+ZGV2LAo+IC0JCQkJ
ICAgICAgc2l6ZW9mKHN0cnVjdCBkc3NfY2xrKSAqIG51bV9jbGssCj4gLQkJCQkgICAgICBHRlBf
S0VSTkVMKTsKPiArCW1wLT5jbGtfY29uZmlnID0ga2NhbGxvYyhudW1fY2xrLCBzaXplb2Yoc3Ry
dWN0IGRzc19jbGspLCBHRlBfS0VSTkVMKTsKClRoaXMgc2hvdWxkIGJlIGZyZWVkIGluIHRoZSBl
cnIgbGFiZWwgaW5zdGVhZCBvZiByZWx5aW5nIG9uIHRoZSBjYWxsZXIgdG8gY2xlYW4KaXQgdXAg
b24gZmFpbHVyZS4KCj4gIAlpZiAoIW1wLT5jbGtfY29uZmlnKQo+ICAJCXJldHVybiAtRU5PTUVN
Owo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2tt
cy5jIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2ttcy5jCj4gaW5kZXggOTg1
Yzg1NTc5NmFlLi41YWMzYzNmM2IwOGQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21z
bS9kaXNwL2RwdTEvZHB1X2ttcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2Rw
dTEvZHB1X2ttcy5jCj4gQEAgLTEwODYsMTMgKzEwODYsMTQgQEAgc3RhdGljIGludCBkcHVfYmlu
ZChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBkZXZpY2UgKm1hc3Rlciwgdm9pZCAqZGF0YSkK
PiAgCXN0cnVjdCBkc3NfbW9kdWxlX3Bvd2VyICptcDsKPiAgCWludCByZXQgPSAwOwo+ICAKPiAt
CWRwdV9rbXMgPSBkZXZtX2t6YWxsb2MoJnBkZXYtPmRldiwgc2l6ZW9mKCpkcHVfa21zKSwgR0ZQ
X0tFUk5FTCk7Cj4gKwlkcHVfa21zID0ga3phbGxvYyhzaXplb2YoKmRwdV9rbXMpLCBHRlBfS0VS
TkVMKTsKPiAgCWlmICghZHB1X2ttcykKPiAgCQlyZXR1cm4gLUVOT01FTTsKPiAgCj4gIAltcCA9
ICZkcHVfa21zLT5tcDsKPiAgCXJldCA9IG1zbV9kc3NfcGFyc2VfY2xvY2socGRldiwgbXApOwo+
ICAJaWYgKHJldCkgewo+ICsJCWtmcmVlKGRwdV9rbXMpOwo+ICAJCURQVV9FUlJPUigiZmFpbGVk
IHRvIHBhcnNlIGNsb2NrcywgcmV0PSVkXG4iLCByZXQpOwo+ICAJCXJldHVybiByZXQ7Cj4gIAl9
Cj4gQEAgLTExMDksNyArMTExMCw3IEBAIHN0YXRpYyBpbnQgZHB1X2JpbmQoc3RydWN0IGRldmlj
ZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlICptYXN0ZXIsIHZvaWQgKmRhdGEpCj4gIAlkcHVfa21zLT5y
cG1fZW5hYmxlZCA9IHRydWU7Cj4gIAo+ICAJcHJpdi0+a21zID0gJmRwdV9rbXMtPmJhc2U7Cj4g
LQlyZXR1cm4gcmV0Owo+ICsJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIGRwdV91
bmJpbmQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlICptYXN0ZXIsIHZvaWQgKmRh
dGEpCj4gQEAgLTExMjAsMTEgKzExMjEsMTIgQEAgc3RhdGljIHZvaWQgZHB1X3VuYmluZChzdHJ1
Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBkZXZpY2UgKm1hc3Rlciwgdm9pZCAqZGF0YSkKPiAgCj4g
IAlkcHVfcG93ZXJfcmVzb3VyY2VfZGVpbml0KHBkZXYsICZkcHVfa21zLT5waGFuZGxlKTsKPiAg
CW1zbV9kc3NfcHV0X2NsayhtcC0+Y2xrX2NvbmZpZywgbXAtPm51bV9jbGspOwo+IC0JZGV2bV9r
ZnJlZSgmcGRldi0+ZGV2LCBtcC0+Y2xrX2NvbmZpZyk7Cj4gLQltcC0+bnVtX2NsayA9IDA7Cj4g
KwlrZnJlZShtcC0+Y2xrX2NvbmZpZyk7Cj4gIAo+ICAJaWYgKGRwdV9rbXMtPnJwbV9lbmFibGVk
KQo+ICAJCXBtX3J1bnRpbWVfZGlzYWJsZSgmcGRldi0+ZGV2KTsKPiArCj4gKwlrZnJlZShkcHVf
a21zKTsKPiAgfQo+ICAKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBjb21wb25lbnRfb3BzIGRwdV9v
cHMgPSB7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9t
ZHNzLmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfbWRzcy5jCj4gaW5kZXgg
MjIzNWVmODEyOWY0Li4zNGFiNDg5YjFhNWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt
L21zbS9kaXNwL2RwdTEvZHB1X21kc3MuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlz
cC9kcHUxL2RwdV9tZHNzLmMKPiBAQCAtMTYxLDcgKzE2MSw3IEBAIHN0YXRpYyB2b2lkIGRwdV9t
ZHNzX2Rlc3Ryb3koc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCWZyZWVfaXJxKHBsYXRmb3Jt
X2dldF9pcnEocGRldiwgMCksIGRwdV9tZHNzKTsKPiAgCj4gIAltc21fZHNzX3B1dF9jbGsobXAt
PmNsa19jb25maWcsIG1wLT5udW1fY2xrKTsKPiAtCWRldm1fa2ZyZWUoJnBkZXYtPmRldiwgbXAt
PmNsa19jb25maWcpOwo+ICsJa2ZyZWUobXAtPmNsa19jb25maWcpOwo+ICAKPiAgCWlmIChkcHVf
bWRzcy0+bW1pbykKPiAgCQlkZXZtX2lvdW5tYXAoJnBkZXYtPmRldiwgZHB1X21kc3MtPm1taW8p
Owo+IEBAIC0xNjksNiArMTY5LDggQEAgc3RhdGljIHZvaWQgZHB1X21kc3NfZGVzdHJveShzdHJ1
Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAKPiAgCXBtX3J1bnRpbWVfZGlzYWJsZShkZXYtPmRldik7
Cj4gIAlwcml2LT5tZHNzID0gTlVMTDsKPiArCj4gKwlrZnJlZShkcHVfbWRzcyk7Cj4gIH0KPiAg
Cj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgbXNtX21kc3NfZnVuY3MgbWRzc19mdW5jcyA9IHsKPiBA
QCAtMTg2LDcgKzE4OCw3IEBAIGludCBkcHVfbWRzc19pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpk
ZXYpCj4gIAlzdHJ1Y3QgZHNzX21vZHVsZV9wb3dlciAqbXA7Cj4gIAlpbnQgcmV0ID0gMDsKPiAg
Cj4gLQlkcHVfbWRzcyA9IGRldm1fa3phbGxvYyhkZXYtPmRldiwgc2l6ZW9mKCpkcHVfbWRzcyks
IEdGUF9LRVJORUwpOwo+ICsJZHB1X21kc3MgPSBremFsbG9jKHNpemVvZigqZHB1X21kc3MpLCBH
RlBfS0VSTkVMKTsKPiAgCWlmICghZHB1X21kc3MpCj4gIAkJcmV0dXJuIC1FTk9NRU07Cj4gIAo+
IEBAIC0yMzksNyArMjQxLDcgQEAgaW50IGRwdV9tZHNzX2luaXQoc3RydWN0IGRybV9kZXZpY2Ug
KmRldikKPiAgaXJxX2RvbWFpbl9lcnJvcjoKPiAgCW1zbV9kc3NfcHV0X2NsayhtcC0+Y2xrX2Nv
bmZpZywgbXAtPm51bV9jbGspOwo+ICBjbGtfcGFyc2VfZXJyOgo+IC0JZGV2bV9rZnJlZSgmcGRl
di0+ZGV2LCBtcC0+Y2xrX2NvbmZpZyk7Cj4gKwlrZnJlZShtcC0+Y2xrX2NvbmZpZyk7Cj4gIAlp
ZiAoZHB1X21kc3MtPm1taW8pCj4gIAkJZGV2bV9pb3VubWFwKCZwZGV2LT5kZXYsIGRwdV9tZHNz
LT5tbWlvKTsKPiAgCWRwdV9tZHNzLT5tbWlvID0gTlVMTDsKPiAtLSAKPiAyLjE4LjAKPiAKPiBf
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEZyZWVkcmVu
byBtYWlsaW5nIGxpc3QKPiBGcmVlZHJlbm9AbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6
Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJlbm8KCi0tIApT
ZWFuIFBhdWwsIFNvZnR3YXJlIEVuZ2luZWVyLCBHb29nbGUgLyBDaHJvbWl1bSBPUwpfX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpGcmVlZHJlbm8gbWFpbGlu
ZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl
ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJlbm8K