From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jordan Crouse Subject: Re: [PATCH] drm/msm/dpu: Don't use devm for component devices Date: Fri, 2 Nov 2018 13:05:24 -0600 Message-ID: <20181102190524.GF19984@jcrouse-lnx.qualcomm.com> References: <20181102143008.8288-1-jcrouse@codeaurora.org> <66f6f2363e24a4a9780df8bb5dbc8666@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <66f6f2363e24a4a9780df8bb5dbc8666@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jeykumar Sankaran Cc: dri-devel , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, jshekhar@codeaurora.org, seanpaul@chromium.org, abhinavk@codeaurora.org, freedreno@lists.freedesktop.org List-Id: linux-arm-msm@vger.kernel.org T24gRnJpLCBOb3YgMDIsIDIwMTggYXQgMTA6NTc6NDZBTSAtMDcwMCwgSmV5a3VtYXIgU2Fua2Fy YW4gd3JvdGU6Cj4gT24gMjAxOC0xMS0wMiAwNzozMCwgSm9yZGFuIENyb3VzZSB3cm90ZToKPiA+ RGV2aWNlcyB0aGF0IGFyZSBib3VuZCBhcyBjb21wb25lbnRzIHNob3VsZCBub3QgdXNlIGRldm0g c2luY2UKPiA+ZGV2aWNlIG1hbmFnZWQgbWVtb3J5IGlzIG5vdCBmcmVlZCB3aGVuIHRoZSBjb21w b25lbnQgaXMKPiA+dW5ib3VuZC4KPiA+Cj4gPkluIHBhcnRpY3VsYXIgdGhpcyBpcyBhbiBpc3N1 ZSBpZiB0aGUgY29tcG9uZW50IGJpbmQgZmFpbHMKPiA+ZHVlIHRvIGFuIC1FUFJPQkVfREVGRVIu IEluIHRoaXMgY2FzZSB0aGUgYmluZCB3b3VsZCB0cnkgYWdhaW4KPiAKPiBJc24ndCB0aGlzIHRo ZSBvbmx5IGNhc2Ugd2hlcmUgdXNpbmcgZGV2bSB3b3VsZCBiZSBhIHByb2JsZW0/IEV2ZW4KPiBp biB0aGlzIGNhc2UKPiBkbyB5b3UgZXhwZWN0IGFueSBsZWFrcyBpZiBkZXZtX2tmcmVlIGlzIGNh bGxlZCBiZWZvcmUgREVGRVJpbmcgZHVlCj4gdG8gZXJyb3JzCj4gYW5kIGluIHVuYm91bmRzPwoK WWVzLCBkZWZlciB3b3VsZCBiZSB0aGUgb25seSBjYXNlIHdoZXJlIHRoZSBtZW1vcnkgd291bGQg YmUgbGVha2VkIGJlY2F1c2UgeW91CndvdWxkIHJlLWluaXRpYWxpemUgdGhlIHBvaW50ZXIgd2hl biB5b3UgYXR0ZW1wdGVkIHRvIGJpbmQgYWdhaW4gYnV0IHRoZW4KYWdhaW4gdGhpcyBpcyB0aGUg b25seSByZWFsIGNhc2UgeW91IG5lZWQgdG8gd29ycnkgYWJvdXQgaW4gYSBzdGFibGUgZW52aXJv bm1lbnQKc28gaXQgaXMgd29ydGggb3B0aW1pemluZyBmb3IuCgpZb3UgYXJlIHJpZ2h0IHRoYXQg dXNpbmcgZGV2bV9rZnJlZSB3b3VsZCBzb2x2ZSB0aGUgcHJvYmxlbSBidXQgdGhlIHdob2xlIHBv aW50Cm9mIGRldm0gaXMgdGhhdCBpdCBpcyBzdXBwb3NlZCB0byBiZSBmaXJlLWFuZC1mb3JnZXQu IElmIHlvdSBoYXZlIHRvIGdvIHRvCnRoZSBlZmZvcnQgb2YgZXhwbGljaXRseSBib3VuZGluZyBk ZXZtX2ttYWxsb2Mgd2l0aCBkZXZtX2tmcmVlIHRoZW4gd2h5IGFyZSB5b3UKYm90aGVyaW5nIHRv IHVzZSBkZXZtIGluIHRoZSBmaXJzdCBwbGFjZT8KCkpvcmRhbgoKPiA+bGF0ZXIgYW5kIGFueSBk ZXZtIG1hbmFnZWQgbWVtb3J5IGFsbG9jYXRlZCBkdXJpbmcgdGhlIGZvcm1lcgo+ID5hYm9ydGVk IGF0dGVtcHQgd291bGQgYmUgbGVha2VkIHVudGlsIHRoZSBkZXZpY2UgaXRzZWxmIHdhcwo+ID5k ZXN0cm95ZWQuIFNpbmNlIGFsbCB0aGUgbWVtb3J5IGFsbG9jYXRlZCBkdXJpbmcgYSBiaW5kCj4g PnNob3VsZCBiZSBmcmVlZCBkdXJpbmcgYW4gdW5iaW5kIChvciBiaW5kIGVycm9yIGNhc2UpIHRo ZXJlIGlzbid0Cj4gPmFueSByZWFzb24gdG8gdXNlIGRldm0gZm9yIHJlc291cmNlcyB0aGF0IGhh dmUgYSBleHBsaWNpdAo+ID50ZWFyZG93biBzdGVwLgo+ID4KPiA+VGhpcyBkb2Vzbid0IHJlbW92 ZSBkZXZtIGZvciBhbGwgcmVzb3VyY2VzIC0gaW4gcGFydGljdWxhcgo+ID5tc21faW9yZW1hcCgp IHN0aWxsIHVzZXMgZGV2bV9pb3JlbWFwKCkgYnV0IHRoYXRzIGEgZ2VuZXJpYwo+ID5pc3N1ZSB0 aGF0IGNhbiBlYXNpbHkgYmUgYWRkcmVzc2VkIGFzIGEgY2xlYW51cCBsYXRlciBhbmQgdGhlCj4g PnVuYmluZCBjb2RlIGFscmVhZHkgZG9lcyB0aGUgcmVxdWlzaXRlIGRldm0gY2FsbHMgdG8gdW5t YXAgaXQuCj4gPgo+ID5TaWduZWQtb2ZmLWJ5OiBKb3JkYW4gQ3JvdXNlIDxqY3JvdXNlQGNvZGVh dXJvcmEub3JnPgo+ID4tLS0KPiA+IGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9l bmNvZGVyLmMgfCAgNCArKy0tCj4gPiBkcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVf aW9fdXRpbC5jIHwgIDQgKy0tLQo+ID4gZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1 X2ttcy5jICAgICB8IDEwICsrKysrKy0tLS0KPiA+IGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9k cHUxL2RwdV9tZHNzLmMgICAgfCAgOCArKysrKy0tLQo+ID4gNCBmaWxlcyBjaGFuZ2VkLCAxNCBp bnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKPiA+Cj4gPmRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5jb2Rlci5jCj4gPmIvZHJpdmVycy9ncHUvZHJt L21zbS9kaXNwL2RwdTEvZHB1X2VuY29kZXIuYwo+ID5pbmRleCA4MmM1NWVmYjUwMGYuLjI4N2Q0 YzNlNThjMyAxMDA2NDQKPiA+LS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1 X2VuY29kZXIuYwo+ID4rKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5j b2Rlci5jCj4gPkBAIC0yMjIwLDE0ICsyMjIwLDE0IEBAIHN0cnVjdCBkcm1fZW5jb2RlciAqZHB1 X2VuY29kZXJfaW5pdChzdHJ1Y3QKPiA+ZHJtX2RldmljZSAqZGV2LAo+ID4gCXN0cnVjdCBkcHVf ZW5jb2Rlcl92aXJ0ICpkcHVfZW5jID0gTlVMTDsKPiA+IAlpbnQgcmMgPSAwOwo+ID4KPiA+LQlk cHVfZW5jID0gZGV2bV9remFsbG9jKGRldi0+ZGV2LCBzaXplb2YoKmRwdV9lbmMpLCBHRlBfS0VS TkVMKTsKPiA+KwlkcHVfZW5jID0ga3phbGxvYyhzaXplb2YoKmRwdV9lbmMpLCBHRlBfS0VSTkVM KTsKPiA+IAlpZiAoIWRwdV9lbmMpCj4gPiAJCXJldHVybiBFUlJfUFRSKEVOT01FTSk7Cj4gPgo+ ID4gCXJjID0gZHJtX2VuY29kZXJfaW5pdChkZXYsICZkcHVfZW5jLT5iYXNlLCAmZHB1X2VuY29k ZXJfZnVuY3MsCj4gPiAJCQlkcm1fZW5jX21vZGUsIE5VTEwpOwo+ID4gCWlmIChyYykgewo+ID4t CQlkZXZtX2tmcmVlKGRldi0+ZGV2LCBkcHVfZW5jKTsKPiA+KwkJa2ZyZWUoZHB1X2VuYyk7Cj4g PiAJCXJldHVybiBFUlJfUFRSKHJjKTsKPiA+IAl9Cj4gPgo+ID5kaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2lvX3V0aWwuYwo+ID5iL2RyaXZlcnMvZ3B1L2Ry bS9tc20vZGlzcC9kcHUxL2RwdV9pb191dGlsLmMKPiA+aW5kZXggODllZTRiMzZiZWZmLi45MGI1 M2U5NTA4ZjIgMTAwNjQ0Cj4gPi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2Rw dV9pb191dGlsLmMKPiA+KysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2lv X3V0aWwuYwo+ID5AQCAtMTU1LDkgKzE1NSw3IEBAIGludCBtc21fZHNzX3BhcnNlX2Nsb2NrKHN0 cnVjdCBwbGF0Zm9ybV9kZXZpY2UKPiA+KnBkZXYsCj4gPiAJCXJldHVybiAwOwo+ID4gCX0KPiA+ Cj4gPi0JbXAtPmNsa19jb25maWcgPSBkZXZtX2t6YWxsb2MoJnBkZXYtPmRldiwKPiA+LQkJCQkg ICAgICBzaXplb2Yoc3RydWN0IGRzc19jbGspICogbnVtX2NsaywKPiA+LQkJCQkgICAgICBHRlBf S0VSTkVMKTsKPiA+KwltcC0+Y2xrX2NvbmZpZyA9IGtjYWxsb2MobnVtX2Nsaywgc2l6ZW9mKHN0 cnVjdCBkc3NfY2xrKSwKPiA+R0ZQX0tFUk5FTCk7Cj4gPiAJaWYgKCFtcC0+Y2xrX2NvbmZpZykK PiA+IAkJcmV0dXJuIC1FTk9NRU07Cj4gPgo+ID5kaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L21zbS9kaXNwL2RwdTEvZHB1X2ttcy5jCj4gPmIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2Rw dTEvZHB1X2ttcy5jCj4gPmluZGV4IDk4NWM4NTU3OTZhZS4uNWFjM2MzZjNiMDhkIDEwMDY0NAo+ ID4tLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfa21zLmMKPiA+KysrIGIv ZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2ttcy5jCj4gPkBAIC0xMDg2LDEzICsx MDg2LDE0IEBAIHN0YXRpYyBpbnQgZHB1X2JpbmQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QK PiA+ZGV2aWNlICptYXN0ZXIsIHZvaWQgKmRhdGEpCj4gPiAJc3RydWN0IGRzc19tb2R1bGVfcG93 ZXIgKm1wOwo+ID4gCWludCByZXQgPSAwOwo+ID4KPiA+LQlkcHVfa21zID0gZGV2bV9remFsbG9j KCZwZGV2LT5kZXYsIHNpemVvZigqZHB1X2ttcyksIEdGUF9LRVJORUwpOwo+ID4rCWRwdV9rbXMg PSBremFsbG9jKHNpemVvZigqZHB1X2ttcyksIEdGUF9LRVJORUwpOwo+ID4gCWlmICghZHB1X2tt cykKPiA+IAkJcmV0dXJuIC1FTk9NRU07Cj4gPgo+ID4gCW1wID0gJmRwdV9rbXMtPm1wOwo+ID4g CXJldCA9IG1zbV9kc3NfcGFyc2VfY2xvY2socGRldiwgbXApOwo+ID4gCWlmIChyZXQpIHsKPiA+ KwkJa2ZyZWUoZHB1X2ttcyk7Cj4gPiAJCURQVV9FUlJPUigiZmFpbGVkIHRvIHBhcnNlIGNsb2Nr cywgcmV0PSVkXG4iLCByZXQpOwo+ID4gCQlyZXR1cm4gcmV0Owo+ID4gCX0KPiA+QEAgLTExMDks NyArMTExMCw3IEBAIHN0YXRpYyBpbnQgZHB1X2JpbmQoc3RydWN0IGRldmljZSAqZGV2LAo+ID5z dHJ1Y3QgZGV2aWNlCj4gPiptYXN0ZXIsIHZvaWQgKmRhdGEpCj4gPiAJZHB1X2ttcy0+cnBtX2Vu YWJsZWQgPSB0cnVlOwo+ID4KPiA+IAlwcml2LT5rbXMgPSAmZHB1X2ttcy0+YmFzZTsKPiA+LQly ZXR1cm4gcmV0Owo+ID4rCXJldHVybiAwOwo+ID4gfQo+ID4KPiA+IHN0YXRpYyB2b2lkIGRwdV91 bmJpbmQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlICptYXN0ZXIsIHZvaWQKPiA+ KmRhdGEpCj4gPkBAIC0xMTIwLDExICsxMTIxLDEyIEBAIHN0YXRpYyB2b2lkIGRwdV91bmJpbmQo c3RydWN0IGRldmljZSAqZGV2LAo+ID5zdHJ1Y3QKPiA+ZGV2aWNlICptYXN0ZXIsIHZvaWQgKmRh dGEpCj4gPgo+ID4gCWRwdV9wb3dlcl9yZXNvdXJjZV9kZWluaXQocGRldiwgJmRwdV9rbXMtPnBo YW5kbGUpOwo+ID4gCW1zbV9kc3NfcHV0X2NsayhtcC0+Y2xrX2NvbmZpZywgbXAtPm51bV9jbGsp Owo+ID4tCWRldm1fa2ZyZWUoJnBkZXYtPmRldiwgbXAtPmNsa19jb25maWcpOwo+ID4tCW1wLT5u dW1fY2xrID0gMDsKPiA+KwlrZnJlZShtcC0+Y2xrX2NvbmZpZyk7Cj4gPgo+ID4gCWlmIChkcHVf a21zLT5ycG1fZW5hYmxlZCkKPiA+IAkJcG1fcnVudGltZV9kaXNhYmxlKCZwZGV2LT5kZXYpOwo+ ID4rCj4gPisJa2ZyZWUoZHB1X2ttcyk7Cj4gPiB9Cj4gPgo+ID4gc3RhdGljIGNvbnN0IHN0cnVj dCBjb21wb25lbnRfb3BzIGRwdV9vcHMgPSB7Cj4gPmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vbXNtL2Rpc3AvZHB1MS9kcHVfbWRzcy5jCj4gPmIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNw L2RwdTEvZHB1X21kc3MuYwo+ID5pbmRleCAyMjM1ZWY4MTI5ZjQuLjM0YWI0ODliMWE1YiAxMDA2 NDQKPiA+LS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X21kc3MuYwo+ID4r KysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfbWRzcy5jCj4gPkBAIC0xNjEs NyArMTYxLDcgQEAgc3RhdGljIHZvaWQgZHB1X21kc3NfZGVzdHJveShzdHJ1Y3QgZHJtX2Rldmlj ZQo+ID4qZGV2KQo+ID4gCWZyZWVfaXJxKHBsYXRmb3JtX2dldF9pcnEocGRldiwgMCksIGRwdV9t ZHNzKTsKPiA+Cj4gPiAJbXNtX2Rzc19wdXRfY2xrKG1wLT5jbGtfY29uZmlnLCBtcC0+bnVtX2Ns ayk7Cj4gPi0JZGV2bV9rZnJlZSgmcGRldi0+ZGV2LCBtcC0+Y2xrX2NvbmZpZyk7Cj4gPisJa2Zy ZWUobXAtPmNsa19jb25maWcpOwo+ID4KPiA+IAlpZiAoZHB1X21kc3MtPm1taW8pCj4gPiAJCWRl dm1faW91bm1hcCgmcGRldi0+ZGV2LCBkcHVfbWRzcy0+bW1pbyk7Cj4gPkBAIC0xNjksNiArMTY5 LDggQEAgc3RhdGljIHZvaWQgZHB1X21kc3NfZGVzdHJveShzdHJ1Y3QgZHJtX2RldmljZQo+ID4q ZGV2KQo+ID4KPiA+IAlwbV9ydW50aW1lX2Rpc2FibGUoZGV2LT5kZXYpOwo+ID4gCXByaXYtPm1k c3MgPSBOVUxMOwo+ID4rCj4gPisJa2ZyZWUoZHB1X21kc3MpOwo+ID4gfQo+ID4KPiA+IHN0YXRp YyBjb25zdCBzdHJ1Y3QgbXNtX21kc3NfZnVuY3MgbWRzc19mdW5jcyA9IHsKPiA+QEAgLTE4Niw3 ICsxODgsNyBAQCBpbnQgZHB1X21kc3NfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4g CXN0cnVjdCBkc3NfbW9kdWxlX3Bvd2VyICptcDsKPiA+IAlpbnQgcmV0ID0gMDsKPiA+Cj4gPi0J ZHB1X21kc3MgPSBkZXZtX2t6YWxsb2MoZGV2LT5kZXYsIHNpemVvZigqZHB1X21kc3MpLCBHRlBf S0VSTkVMKTsKPiA+KwlkcHVfbWRzcyA9IGt6YWxsb2Moc2l6ZW9mKCpkcHVfbWRzcyksIEdGUF9L RVJORUwpOwo+ID4gCWlmICghZHB1X21kc3MpCj4gPiAJCXJldHVybiAtRU5PTUVNOwo+ID4KPiA+ QEAgLTIzOSw3ICsyNDEsNyBAQCBpbnQgZHB1X21kc3NfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2KQo+ID4gaXJxX2RvbWFpbl9lcnJvcjoKPiA+IAltc21fZHNzX3B1dF9jbGsobXAtPmNsa19j b25maWcsIG1wLT5udW1fY2xrKTsKPiA+IGNsa19wYXJzZV9lcnI6Cj4gPi0JZGV2bV9rZnJlZSgm cGRldi0+ZGV2LCBtcC0+Y2xrX2NvbmZpZyk7Cj4gPisJa2ZyZWUobXAtPmNsa19jb25maWcpOwo+ ID4gCWlmIChkcHVfbWRzcy0+bW1pbykKPiA+IAkJZGV2bV9pb3VubWFwKCZwZGV2LT5kZXYsIGRw dV9tZHNzLT5tbWlvKTsKPiA+IAlkcHVfbWRzcy0+bW1pbyA9IE5VTEw7Cj4gCj4gLS0gCj4gSmV5 a3VtYXIgUwoKLS0gClRoZSBRdWFsY29tbSBJbm5vdmF0aW9uIENlbnRlciwgSW5jLiBpcyBhIG1l bWJlciBvZiBDb2RlIEF1cm9yYSBGb3J1bSwKYSBMaW51eCBGb3VuZGF0aW9uIENvbGxhYm9yYXRp dmUgUHJvamVjdApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK