Re: [PATCH v2 13/17] arm64: dts: qcom: qcs404: Add remoteproc nodes

Bjorn Andersson
2018-11-05T19:10:35Z

On Mon 05 Nov 07:45 PST 2018, Vinod Koul wrote:

> From: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> Add the TrustZone based remoteproc nodes and their glink edges for
> adsp, cdsp and wcss.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> arch/arm64/boot/dts/qcom/qcs404.dtsi | 87 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 87 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> index 8e207a25ddf0..b560ab6e49ff 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> @@ -373,4 +373,91 @@
> #interrupt-cells = <2>;
> };
> };
> +
> + remoteproc-adsp {
> + compatible = "qcom,qcs404-adsp-pas";
> +
> + interrupts-extended = <&intc GIC_SPI 293 IRQ_TYPE_EDGE_RISING>,
> + <&adsp_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
> + <&adsp_smp2p_in 1 IRQ_TYPE_EDGE_RISING>,
> + <&adsp_smp2p_in 2 IRQ_TYPE_EDGE_RISING>,
> + <&adsp_smp2p_in 3 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "wdog", "fatal", "ready",
> + "handover", "stop-ack";
> +
> + clocks = <&xo_board>;
> + clock-names = "xo";
> +

As the TZ-backed remoteproc drivers will not be used on all variation of
products on this platform please add status = "disabled"; to these nodes
and enable them in the evb.

Regards,
Bjorn

> + memory-region = <&adsp_fw_mem>;
> +
> + qcom,smem-states = <&adsp_smp2p_out 0>;
> + qcom,smem-state-names = "stop";
> +
> + glink-edge {
> + interrupts = <GIC_SPI 289 IRQ_TYPE_EDGE_RISING>;
> +
> + qcom,remote-pid = <2>;
> + mboxes = <&apcs_glb 8>;
> +
> + label = "adsp";
> + };
> + };
> +
> + remoteproc-cdsp {
> + compatible = "qcom,qcs404-cdsp-pas";
> +
> + interrupts-extended = <&intc GIC_SPI 229 IRQ_TYPE_EDGE_RISING>,
> + <&cdsp_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
> + <&cdsp_smp2p_in 1 IRQ_TYPE_EDGE_RISING>,
> + <&cdsp_smp2p_in 2 IRQ_TYPE_EDGE_RISING>,
> + <&cdsp_smp2p_in 3 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "wdog", "fatal", "ready",
> + "handover", "stop-ack";
> +
> + clocks = <&xo_board>;
> + clock-names = "xo";
> +
> + memory-region = <&cdsp_fw_mem>;
> +
> + qcom,smem-states = <&cdsp_smp2p_out 0>;
> + qcom,smem-state-names = "stop";
> +
> + glink-edge {
> + interrupts = <GIC_SPI 141 IRQ_TYPE_EDGE_RISING>;
> +
> + qcom,remote-pid = <5>;
> + mboxes = <&apcs_glb 12>;
> +
> + label = "cdsp";
> + };
> + };
> +
> + remoteproc-wcss {
> + compatible = "qcom,qcs404-wcss-pas";
> +
> + interrupts-extended = <&intc GIC_SPI 153 IRQ_TYPE_EDGE_RISING>,
> + <&wcss_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
> + <&wcss_smp2p_in 1 IRQ_TYPE_EDGE_RISING>,
> + <&wcss_smp2p_in 2 IRQ_TYPE_EDGE_RISING>,
> + <&wcss_smp2p_in 3 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "wdog", "fatal", "ready",
> + "handover", "stop-ack";
> +
> + clocks = <&xo_board>;
> + clock-names = "xo";
> +
> + memory-region = <&wlan_fw_mem>;
> +
> + qcom,smem-states = <&wcss_smp2p_out 0>;
> + qcom,smem-state-names = "stop";
> +
> + glink-edge {
> + interrupts = <GIC_SPI 156 IRQ_TYPE_EDGE_RISING>;
> +
> + qcom,remote-pid = <1>;
> + mboxes = <&apcs_glb 16>;
> +
> + label = "wcss";
> + };
> + };
> };
> --
> 2.14.4
>