Re: [PATCH v2 01/17] arm64: dts: qcom: qcs404: add base dts files

Vinod Koul
2018-11-06T17:35:43Z

Thanks for the review Bjorn,

On 05-11-18, 10:56, Bjorn Andersson wrote:
> On Mon 05 Nov 07:45 PST 2018, Vinod Koul wrote:
>
> > diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dts b/arch/arm64/boot/dts/qcom/qcs404-evb.dts
> > new file mode 100644
> > index 000000000000..74dc09ddb0d2
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dts
> > @@ -0,0 +1,21 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +// Copyright (c) 2018, Linaro Limited
> > +
> > +// QCS EVB DTS
>
> This can be read from the filename and the model a few lines down. So
> please drop.

Sure

>
> > +
> > +/dts-v1/;
> > +
> > +#include "qcs404.dtsi"
> > +
> > +/ {
> > + model = "Qualcomm Technologies, Inc. QCS404 EVB 1000";
> > + compatible = "qcom,qcs404-evb";
> > +
> > + aliases {
> > + serial0 = &blsp1_uart2;
> > + };
> > +
> > + chosen {
> > + stdout-path = "serial0";
> > + };
> > +};
> > diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> [..]
> > + timer {
> > + compatible = "arm,armv8-timer";
> > + interrupts = <GIC_PPI 2 0xff08>,
> > + <GIC_PPI 3 0xff08>,
> > + <GIC_PPI 4 0xff08>,
> > + <GIC_PPI 1 0xff08>;
> > + };
> > +
> > + clocks {
>
> Please sort these nodes alphabetically.

Will do and also while adding subsequent nodes

> > + xo_board: xo_board {
> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + clock-frequency = <19200000>;
> > + };
> > + };
> > +
> > + soc: soc@0 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges = <0 0 0 0xffffffff>;
> > + compatible = "simple-bus";
> > +
>
> Please pad the address in reg to 8 digits and sort these nodes by
> address.

Sure

--
~Vinod