From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jordan Crouse Subject: Re: [PATCH v2] drm/msm/dpu: Don't use devm for component devices Date: Mon, 5 Nov 2018 09:40:21 -0700 Message-ID: <20181105164020.GG19984@jcrouse-lnx.qualcomm.com> References: <20181102182529.2501-1-jcrouse@codeaurora.org> <8aa14e93-d219-d3c5-fe1a-0d77d0d53620@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <8aa14e93-d219-d3c5-fe1a-0d77d0d53620-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Andrzej Hajda Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, jshekhar-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gTW9uLCBOb3YgMDUsIDIwMTggYXQgMDc6NTQ6NTJBTSArMDEwMCwgQW5kcnplaiBIYWpkYSB3 cm90ZToKPiBPbiAwMi4xMS4yMDE4IDE5OjI1LCBKb3JkYW4gQ3JvdXNlIHdyb3RlOgo+ID4gRGV2 aWNlcyB0aGF0IGFyZSBib3VuZCBhcyBjb21wb25lbnRzIHNob3VsZCBub3QgdXNlIGRldm0gc2lu Y2UKPiA+IGRldmljZSBtYW5hZ2VkIG1lbW9yeSBpcyBub3QgZnJlZWQgd2hlbiB0aGUgY29tcG9u ZW50IGlzCj4gPiB1bmJvdW5kLgo+ID4KPiA+IEluIHBhcnRpY3VsYXIgdGhpcyBpcyBhbiBpc3N1 ZSBpZiB0aGUgY29tcG9lbnQgYmluZCBmYWlscwo+ID4gZHVlIHRvIGFuIC1FUFJPQkVfREVGRVIu IEluIHRoaXMgY2FzZSB0aGUgYmluZCB3b3VsZCB0cnkgYWdhaW4KPiA+IGxhdGVyIGFuZCBhbnkg ZGV2bSBtYW5hZ2VkIG1lb3J5IGFsbG9jYXRlZCBkdXJpbmcgdGhlIGZvcm1lcgo+ID4gYWJvcnRl ZCBhdHRlbXB0IHdvdWxkIGJlIGxlYWtlZCB1bnRpbCB0aGUgZGV2aWNlIGl0c2VsZiB3YXMKPiA+ IGRlc3Ryb3llZC4gIFRoZXJlZm9yZSwgYWxsIHRoZSBtZW1vcnkgYWxsb2NhdGVkIGR1cmluZyBh IGJpbmQKPiA+IHNob3VsZCBiZSBmcmVlZCBkdXJpbmcgYW4gdW5iaW5kIChvciBiaW5kIGVycm9y IGNhc2UpIGFuZCB0aGVyZQo+ID4gaXNuJ3QgYW55IHJlYXNvbiB0byB1c2UgZGV2bSBmb3IgcmVz b3VyY2VzIHRoYXQgaGF2ZSBhIGV4cGxpY2l0Cj4gPiB0ZWFyZG93biBzdGVwLgo+IAo+IEl0IGRv ZXMgbm90IGxvb2sgY29ycmVjdCwgY29tcG9uZW50IGZyYW1ld29yayBzaG91bGQgcHJvcGVybHkg ZnJlZSBkZXZtCj4gcmVzb3VyY2VzLCBpZSBpZiBkZXZtIHJlc291cmNlIHdhcyBhbGxvY2F0ZWQg aW4gYmluZCBjYWxsYmFjaywgaXQgc2hvdWxkCj4gYmUgcmVsZWFzZWQgYWZ0ZXIgdW5iaW5kIG9y IGZhaWxlZCBiaW5kLgo+IFNlZSBjb21tZW50cyBpbnNpZGUgY29tcG9uZW50X2JpbmRbMV0uIElm IGl0IGRvZXMgbm90IHdvcmsgaXQgc2hvdWxkIGJlCj4gZml4ZWQgaW4gY29tcG9uZW50cy4KCkkg bG9va2VkIGFnYWluIC0geW91IGFyZSByaWdodC4gIFRoZXJlIGlzIGEgZGV2cmVzX3JlbGVhc2Vf Z3JvdXAoKSBpbiB0aGUKZmFpbHVyZSBwYXRoLiBJJ2xsIHJld29yayB0aGlzIHBhdGNoIHRvIHJl bW92ZSB0aGUgZGV2bSByZWxlYXNlIGNhbGxzIGluc3RlYWQKYW5kIHJlbHkgb24gdGhhdC4KClRo YW5rcywKSm9yZGFuCgo+IFsxXToKPiBodHRwczovL2VsaXhpci5ib290bGluLmNvbS9saW51eC9s YXRlc3Qvc291cmNlL2RyaXZlcnMvYmFzZS9jb21wb25lbnQuYyNMNDY0Cj4gCj4gUmVnYXJkcwo+ IEFuZHJ6ZWoKPiAKPiAKPiAKPiA+Cj4gPiBUaGlzIGRvZXNuJ3QgcmVtb3ZlIGRldm0gZm9yIGFs bCByZXNvdXJjZXMgLSBpbiBwYXJ0aWN1bGFyCj4gPiBtc21faW9yZW1hcCgpIHN0aWxsIHVzZXMg ZGV2bV9pb3JlbWFwKCkgYnV0IHRoYXRzIGEgbW9yZQo+ID4gZ2VuZXJpYyBjb25kaXRpb24gdGhh dCBjYW4gZWFzaWx5IGJlIGFkZHJlc3NlZCBhcyBhIGNsZWFudXAKPiA+IGxhdGVyIGFuZCB0aGUg dW5iaW5kIGNvZGUgYWxyZWFkeSBkb2VzIHRoZSByZXF1aXNpdGUgZGV2bQo+ID4gY2FsbHMgdG8g dW5tYXAgaXQuCj4gPgo+ID4gdjI6IGZyZWUgbXAtPmNsa19jb25maWcgb24gZmFpbHVyZQo+ID4K PiA+IFNpZ25lZC1vZmYtYnk6IEpvcmRhbiBDcm91c2UgPGpjcm91c2VAY29kZWF1cm9yYS5vcmc+ Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5jb2Rlci5j IHwgIDQgKystLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9pb191dGls LmMgfCAgNiArKystLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfa21z LmMgICAgIHwgMTAgKysrKysrLS0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUx L2RwdV9tZHNzLmMgICAgfCAgOCArKysrKy0tLQo+ID4gIDQgZmlsZXMgY2hhbmdlZCwgMTYgaW5z ZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9lbmNvZGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNt L2Rpc3AvZHB1MS9kcHVfZW5jb2Rlci5jCj4gPiBpbmRleCA4MmM1NWVmYjUwMGYuLjI4N2Q0YzNl NThjMyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9l bmNvZGVyLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9lbmNv ZGVyLmMKPiA+IEBAIC0yMjIwLDE0ICsyMjIwLDE0IEBAIHN0cnVjdCBkcm1fZW5jb2RlciAqZHB1 X2VuY29kZXJfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4gIAlzdHJ1Y3QgZHB1X2Vu Y29kZXJfdmlydCAqZHB1X2VuYyA9IE5VTEw7Cj4gPiAgCWludCByYyA9IDA7Cj4gPiAgCj4gPiAt CWRwdV9lbmMgPSBkZXZtX2t6YWxsb2MoZGV2LT5kZXYsIHNpemVvZigqZHB1X2VuYyksIEdGUF9L RVJORUwpOwo+ID4gKwlkcHVfZW5jID0ga3phbGxvYyhzaXplb2YoKmRwdV9lbmMpLCBHRlBfS0VS TkVMKTsKPiA+ICAJaWYgKCFkcHVfZW5jKQo+ID4gIAkJcmV0dXJuIEVSUl9QVFIoRU5PTUVNKTsK PiA+ICAKPiA+ICAJcmMgPSBkcm1fZW5jb2Rlcl9pbml0KGRldiwgJmRwdV9lbmMtPmJhc2UsICZk cHVfZW5jb2Rlcl9mdW5jcywKPiA+ICAJCQlkcm1fZW5jX21vZGUsIE5VTEwpOwo+ID4gIAlpZiAo cmMpIHsKPiA+IC0JCWRldm1fa2ZyZWUoZGV2LT5kZXYsIGRwdV9lbmMpOwo+ID4gKwkJa2ZyZWUo ZHB1X2VuYyk7Cj4gPiAgCQlyZXR1cm4gRVJSX1BUUihyYyk7Cj4gPiAgCX0KPiA+ICAKPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfaW9fdXRpbC5jIGIv ZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2lvX3V0aWwuYwo+ID4gaW5kZXggODll ZTRiMzZiZWZmLi4xNGZlY2YwMGUwMzIgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v bXNtL2Rpc3AvZHB1MS9kcHVfaW9fdXRpbC5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNt L2Rpc3AvZHB1MS9kcHVfaW9fdXRpbC5jCj4gPiBAQCAtMTU1LDkgKzE1NSw3IEBAIGludCBtc21f ZHNzX3BhcnNlX2Nsb2NrKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYsCj4gPiAgCQlyZXR1 cm4gMDsKPiA+ICAJfQo+ID4gIAo+ID4gLQltcC0+Y2xrX2NvbmZpZyA9IGRldm1fa3phbGxvYygm cGRldi0+ZGV2LAo+ID4gLQkJCQkgICAgICBzaXplb2Yoc3RydWN0IGRzc19jbGspICogbnVtX2Ns aywKPiA+IC0JCQkJICAgICAgR0ZQX0tFUk5FTCk7Cj4gPiArCW1wLT5jbGtfY29uZmlnID0ga2Nh bGxvYyhudW1fY2xrLCBzaXplb2Yoc3RydWN0IGRzc19jbGspLCBHRlBfS0VSTkVMKTsKPiA+ICAJ aWYgKCFtcC0+Y2xrX2NvbmZpZykKPiA+ICAJCXJldHVybiAtRU5PTUVNOwo+ID4gIAo+ID4gQEAg LTIwMSw1ICsxOTksNyBAQCBpbnQgbXNtX2Rzc19wYXJzZV9jbG9jayhzdHJ1Y3QgcGxhdGZvcm1f ZGV2aWNlICpwZGV2LAo+ID4gIAo+ID4gIGVycjoKPiA+ICAJbXNtX2Rzc19wdXRfY2xrKG1wLT5j bGtfY29uZmlnLCBudW1fY2xrKTsKPiA+ICsJa2ZyZWUobXAtPmNsa19jb25maWcpOwo+ID4gKwlt cC0+Y2xrX2NvbmZpZyA9IE5VTEw7Cj4gPiAgCXJldHVybiByYzsKPiA+ICB9Cj4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2ttcy5jIGIvZHJpdmVycy9n cHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2ttcy5jCj4gPiBpbmRleCA5ODVjODU1Nzk2YWUuLjVh YzNjM2YzYjA4ZCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUx L2RwdV9rbXMuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2tt cy5jCj4gPiBAQCAtMTA4NiwxMyArMTA4NiwxNCBAQCBzdGF0aWMgaW50IGRwdV9iaW5kKHN0cnVj dCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZSAqbWFzdGVyLCB2b2lkICpkYXRhKQo+ID4gIAlz dHJ1Y3QgZHNzX21vZHVsZV9wb3dlciAqbXA7Cj4gPiAgCWludCByZXQgPSAwOwo+ID4gIAo+ID4g LQlkcHVfa21zID0gZGV2bV9remFsbG9jKCZwZGV2LT5kZXYsIHNpemVvZigqZHB1X2ttcyksIEdG UF9LRVJORUwpOwo+ID4gKwlkcHVfa21zID0ga3phbGxvYyhzaXplb2YoKmRwdV9rbXMpLCBHRlBf S0VSTkVMKTsKPiA+ICAJaWYgKCFkcHVfa21zKQo+ID4gIAkJcmV0dXJuIC1FTk9NRU07Cj4gPiAg Cj4gPiAgCW1wID0gJmRwdV9rbXMtPm1wOwo+ID4gIAlyZXQgPSBtc21fZHNzX3BhcnNlX2Nsb2Nr KHBkZXYsIG1wKTsKPiA+ICAJaWYgKHJldCkgewo+ID4gKwkJa2ZyZWUoZHB1X2ttcyk7Cj4gPiAg CQlEUFVfRVJST1IoImZhaWxlZCB0byBwYXJzZSBjbG9ja3MsIHJldD0lZFxuIiwgcmV0KTsKPiA+ ICAJCXJldHVybiByZXQ7Cj4gPiAgCX0KPiA+IEBAIC0xMTA5LDcgKzExMTAsNyBAQCBzdGF0aWMg aW50IGRwdV9iaW5kKHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZSAqbWFzdGVyLCB2 b2lkICpkYXRhKQo+ID4gIAlkcHVfa21zLT5ycG1fZW5hYmxlZCA9IHRydWU7Cj4gPiAgCj4gPiAg CXByaXYtPmttcyA9ICZkcHVfa21zLT5iYXNlOwo+ID4gLQlyZXR1cm4gcmV0Owo+ID4gKwlyZXR1 cm4gMDsKPiA+ICB9Cj4gPiAgCj4gPiAgc3RhdGljIHZvaWQgZHB1X3VuYmluZChzdHJ1Y3QgZGV2 aWNlICpkZXYsIHN0cnVjdCBkZXZpY2UgKm1hc3Rlciwgdm9pZCAqZGF0YSkKPiA+IEBAIC0xMTIw LDExICsxMTIxLDEyIEBAIHN0YXRpYyB2b2lkIGRwdV91bmJpbmQoc3RydWN0IGRldmljZSAqZGV2 LCBzdHJ1Y3QgZGV2aWNlICptYXN0ZXIsIHZvaWQgKmRhdGEpCj4gPiAgCj4gPiAgCWRwdV9wb3dl cl9yZXNvdXJjZV9kZWluaXQocGRldiwgJmRwdV9rbXMtPnBoYW5kbGUpOwo+ID4gIAltc21fZHNz X3B1dF9jbGsobXAtPmNsa19jb25maWcsIG1wLT5udW1fY2xrKTsKPiA+IC0JZGV2bV9rZnJlZSgm cGRldi0+ZGV2LCBtcC0+Y2xrX2NvbmZpZyk7Cj4gPiAtCW1wLT5udW1fY2xrID0gMDsKPiA+ICsJ a2ZyZWUobXAtPmNsa19jb25maWcpOwo+ID4gIAo+ID4gIAlpZiAoZHB1X2ttcy0+cnBtX2VuYWJs ZWQpCj4gPiAgCQlwbV9ydW50aW1lX2Rpc2FibGUoJnBkZXYtPmRldik7Cj4gPiArCj4gPiArCWtm cmVlKGRwdV9rbXMpOwo+ID4gIH0KPiA+ICAKPiA+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGNvbXBv bmVudF9vcHMgZHB1X29wcyA9IHsKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNt L2Rpc3AvZHB1MS9kcHVfbWRzcy5jIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1 X21kc3MuYwo+ID4gaW5kZXggMjIzNWVmODEyOWY0Li5jODIzNDdhZmM5NjcgMTAwNjQ0Cj4gPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfbWRzcy5jCj4gPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfbWRzcy5jCj4gPiBAQCAtMTYxLDcgKzE2 MSw3IEBAIHN0YXRpYyB2b2lkIGRwdV9tZHNzX2Rlc3Ryb3koc3RydWN0IGRybV9kZXZpY2UgKmRl dikKPiA+ICAJZnJlZV9pcnEocGxhdGZvcm1fZ2V0X2lycShwZGV2LCAwKSwgZHB1X21kc3MpOwo+ ID4gIAo+ID4gIAltc21fZHNzX3B1dF9jbGsobXAtPmNsa19jb25maWcsIG1wLT5udW1fY2xrKTsK PiA+IC0JZGV2bV9rZnJlZSgmcGRldi0+ZGV2LCBtcC0+Y2xrX2NvbmZpZyk7Cj4gPiArCWtmcmVl KG1wLT5jbGtfY29uZmlnKTsKPiA+ICAKPiA+ICAJaWYgKGRwdV9tZHNzLT5tbWlvKQo+ID4gIAkJ ZGV2bV9pb3VubWFwKCZwZGV2LT5kZXYsIGRwdV9tZHNzLT5tbWlvKTsKPiA+IEBAIC0xNjksNiAr MTY5LDggQEAgc3RhdGljIHZvaWQgZHB1X21kc3NfZGVzdHJveShzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2KQo+ID4gIAo+ID4gIAlwbV9ydW50aW1lX2Rpc2FibGUoZGV2LT5kZXYpOwo+ID4gIAlwcml2 LT5tZHNzID0gTlVMTDsKPiA+ICsKPiA+ICsJa2ZyZWUoZHB1X21kc3MpOwo+ID4gIH0KPiA+ICAK PiA+ICBzdGF0aWMgY29uc3Qgc3RydWN0IG1zbV9tZHNzX2Z1bmNzIG1kc3NfZnVuY3MgPSB7Cj4g PiBAQCAtMTg2LDcgKzE4OCw3IEBAIGludCBkcHVfbWRzc19pbml0KHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYpCj4gPiAgCXN0cnVjdCBkc3NfbW9kdWxlX3Bvd2VyICptcDsKPiA+ICAJaW50IHJldCA9 IDA7Cj4gPiAgCj4gPiAtCWRwdV9tZHNzID0gZGV2bV9remFsbG9jKGRldi0+ZGV2LCBzaXplb2Yo KmRwdV9tZHNzKSwgR0ZQX0tFUk5FTCk7Cj4gPiArCWRwdV9tZHNzID0ga3phbGxvYyhzaXplb2Yo KmRwdV9tZHNzKSwgR0ZQX0tFUk5FTCk7Cj4gPiAgCWlmICghZHB1X21kc3MpCj4gPiAgCQlyZXR1 cm4gLUVOT01FTTsKPiA+ICAKPiA+IEBAIC0yMzgsOCArMjQwLDggQEAgaW50IGRwdV9tZHNzX2lu aXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+ICAJX2RwdV9tZHNzX2lycV9kb21haW5fZmlu aShkcHVfbWRzcyk7Cj4gPiAgaXJxX2RvbWFpbl9lcnJvcjoKPiA+ICAJbXNtX2Rzc19wdXRfY2xr KG1wLT5jbGtfY29uZmlnLCBtcC0+bnVtX2Nsayk7Cj4gPiArCWtmcmVlKG1wLT5jbGtfY29uZmln KTsKPiA+ICBjbGtfcGFyc2VfZXJyOgo+ID4gLQlkZXZtX2tmcmVlKCZwZGV2LT5kZXYsIG1wLT5j bGtfY29uZmlnKTsKPiA+ICAJaWYgKGRwdV9tZHNzLT5tbWlvKQo+ID4gIAkJZGV2bV9pb3VubWFw KCZwZGV2LT5kZXYsIGRwdV9tZHNzLT5tbWlvKTsKPiA+ICAJZHB1X21kc3MtPm1taW8gPSBOVUxM Owo+IAo+IAoKLS0gClRoZSBRdWFsY29tbSBJbm5vdmF0aW9uIENlbnRlciwgSW5jLiBpcyBhIG1l bWJlciBvZiBDb2RlIEF1cm9yYSBGb3J1bSwKYSBMaW51eCBGb3VuZGF0aW9uIENvbGxhYm9yYXRp dmUgUHJvamVjdApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpGcmVlZHJlbm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJlbm8K