From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sean Paul <sean@poorly.run>
Subject: Re: [PATCH 04/11] drm/msm/dpu: Remove dpu_crtc_is_enabled()
Date: Tue, 6 Nov 2018 09:31:11 -0500
Message-ID: <20181106143111.GO154160@art_vandelay>
References: <20181105233103.7657-1-jcrouse@codeaurora.org>
 <20181105233103.7657-5-jcrouse@codeaurora.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20181105233103.7657-5-jcrouse@codeaurora.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Jordan Crouse <jcrouse@codeaurora.org>
Cc: sam@ravnborg.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, bzwang@chromium.org, seanpaul@chromium.org, abhinavk@codeaurora.org, freedreno@lists.freedesktop.org
List-Id: linux-arm-msm@vger.kernel.org

T24gTW9uLCBOb3YgMDUsIDIwMTggYXQgMDQ6MzA6NTZQTSAtMDcwMCwgSm9yZGFuIENyb3VzZSB3
cm90ZToKPiBUaGUgc3RhdGljIGlubGluZSBmdW5jdGlvbiBkcHVfY3J0Y19lbmFibGVkKCkgaXMg
b25seSBjYWxsZWQgb25jZQo+IGFuZCB0aGUgZnVuY3Rpb24gdGhhdCBjYWxscyBpdCBpbiB0dXJu
IGlzIG9ubHkgY2FsbGVkIG9uY2UgYW5kCj4gdGhlIHJldHVybiB2YWx1ZSBjYW4gYmUgZWFzaWx5
IGNoZWNrZWQgaW4gdGhlIGNhbGxpbmcgZnVuY3Rpb25zCj4gc28gY29sbGFwc2UgZXZlcnl0aGlu
ZyBkb3duLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEpvcmRhbiBDcm91c2UgPGpjcm91c2VAY29kZWF1
cm9yYS5vcmc+CgpSZXZpZXdlZC1ieTogU2VhbiBQYXVsIDxzZWFuQHBvb3JseS5ydW4+Cgo+IC0t
LQo+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfY29yZV9wZXJmLmMgfCAxNyAr
KysrKystLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfY3J0
Yy5oICAgICAgfCAgOSAtLS0tLS0tLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCA2IGluc2VydGlvbnMo
KyksIDIwIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNt
L2Rpc3AvZHB1MS9kcHVfY29yZV9wZXJmLmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1
MS9kcHVfY29yZV9wZXJmLmMKPiBpbmRleCAyMmU4NGIzZDdmOTguLmU2OGNjYjdhODk4YSAxMDA2
NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfY29yZV9wZXJmLmMK
PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfY29yZV9wZXJmLmMKPiBA
QCAtNTcsMTggKzU3LDEzIEBAIHN0YXRpYyBzdHJ1Y3QgZHB1X2ttcyAqX2RwdV9jcnRjX2dldF9r
bXMoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ICAJcmV0dXJuIHRvX2RwdV9rbXMocHJpdi0+a21z
KTsKPiAgfQo+ICAKPiAtc3RhdGljIGJvb2wgX2RwdV9jb3JlX3BlcmZfY3J0Y19pc19wb3dlcl9v
bihzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gLXsKPiAtCXJldHVybiBkcHVfY3J0Y19pc19lbmFi
bGVkKGNydGMpOwo+IC19Cj4gLQo+ICBzdGF0aWMgYm9vbCBfZHB1X2NvcmVfdmlkZW9fbW9kZV9p
bnRmX2Nvbm5lY3RlZChzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gIHsKPiAgCXN0cnVjdCBkcm1f
Y3J0YyAqdG1wX2NydGM7Cj4gIAo+ICAJZHJtX2Zvcl9lYWNoX2NydGModG1wX2NydGMsIGNydGMt
PmRldikgewo+ICAJCWlmICgoZHB1X2NydGNfZ2V0X2ludGZfbW9kZSh0bXBfY3J0YykgPT0gSU5U
Rl9NT0RFX1ZJREVPKSAmJgo+IC0JCQkJX2RwdV9jb3JlX3BlcmZfY3J0Y19pc19wb3dlcl9vbih0
bXBfY3J0YykpIHsKPiArCQkJCXRtcF9jcnRjLT5lbmFibGVkKSB7Cj4gIAkJCURQVV9ERUJVRygi
dmlkZW8gaW50ZXJmYWNlIGNvbm5lY3RlZCBjcnRjOiVkXG4iLAo+ICAJCQkJdG1wX2NydGMtPmJh
c2UuaWQpOwo+ICAJCQlyZXR1cm4gdHJ1ZTsKPiBAQCAtMTY0LDcgKzE1OSw3IEBAIGludCBkcHVf
Y29yZV9wZXJmX2NydGNfY2hlY2soc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJCWN1cnJfY2xp
ZW50X3R5cGUgPSBkcHVfY3J0Y19nZXRfY2xpZW50X3R5cGUoY3J0Yyk7Cj4gIAo+ICAJCWRybV9m
b3JfZWFjaF9jcnRjKHRtcF9jcnRjLCBjcnRjLT5kZXYpIHsKPiAtCQkJaWYgKF9kcHVfY29yZV9w
ZXJmX2NydGNfaXNfcG93ZXJfb24odG1wX2NydGMpICYmCj4gKwkJCWlmICh0bXBfY3J0Yy0+ZW5h
YmxlZCAmJgo+ICAJCQkgICAgKGRwdV9jcnRjX2dldF9jbGllbnRfdHlwZSh0bXBfY3J0YykgPT0K
PiAgCQkJCQkgICAgY3Vycl9jbGllbnRfdHlwZSkgJiYKPiAgCQkJICAgICh0bXBfY3J0YyAhPSBj
cnRjKSkgewo+IEBAIC0yMjMsNyArMjE4LDcgQEAgc3RhdGljIGludCBfZHB1X2NvcmVfcGVyZl9j
cnRjX3VwZGF0ZV9idXMoc3RydWN0IGRwdV9rbXMgKmttcywKPiAgCWludCByZXQgPSAwOwo+ICAK
PiAgCWRybV9mb3JfZWFjaF9jcnRjKHRtcF9jcnRjLCBjcnRjLT5kZXYpIHsKPiAtCQlpZiAoX2Rw
dV9jb3JlX3BlcmZfY3J0Y19pc19wb3dlcl9vbih0bXBfY3J0YykgJiYKPiArCQlpZiAodG1wX2Ny
dGMtPmVuYWJsZWQgJiYKPiAgCQkJY3Vycl9jbGllbnRfdHlwZSA9PQo+ICAJCQkJZHB1X2NydGNf
Z2V0X2NsaWVudF90eXBlKHRtcF9jcnRjKSkgewo+ICAJCQlkcHVfY3N0YXRlID0gdG9fZHB1X2Ny
dGNfc3RhdGUodG1wX2NydGMtPnN0YXRlKTsKPiBAQCAtMjgwLDcgKzI3NSw3IEBAIHZvaWQgZHB1
X2NvcmVfcGVyZl9jcnRjX3JlbGVhc2VfYncoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ICAJICov
Cj4gIAlpZiAoZHB1X2NydGNfZ2V0X2ludGZfbW9kZShjcnRjKSA9PSBJTlRGX01PREVfQ01EKQo+
ICAJCWRybV9mb3JfZWFjaF9jcnRjKHRtcF9jcnRjLCBjcnRjLT5kZXYpIHsKPiAtCQkJaWYgKF9k
cHVfY29yZV9wZXJmX2NydGNfaXNfcG93ZXJfb24odG1wX2NydGMpICYmCj4gKwkJCWlmICh0bXBf
Y3J0Yy0+ZW5hYmxlZCAmJgo+ICAJCQkJZHB1X2NydGNfZ2V0X2ludGZfbW9kZSh0bXBfY3J0Yykg
PT0KPiAgCQkJCQkJSU5URl9NT0RFX1ZJREVPKQo+ICAJCQkJcmV0dXJuOwo+IEBAIC0zMTUsNyAr
MzEwLDcgQEAgc3RhdGljIHU2NCBfZHB1X2NvcmVfcGVyZl9nZXRfY29yZV9jbGtfcmF0ZShzdHJ1
Y3QgZHB1X2ttcyAqa21zKQo+ICAJc3RydWN0IGRwdV9jcnRjX3N0YXRlICpkcHVfY3N0YXRlOwo+
ICAKPiAgCWRybV9mb3JfZWFjaF9jcnRjKGNydGMsIGttcy0+ZGV2KSB7Cj4gLQkJaWYgKF9kcHVf
Y29yZV9wZXJmX2NydGNfaXNfcG93ZXJfb24oY3J0YykpIHsKPiArCQlpZiAoY3J0Yy0+ZW5hYmxl
ZCkgewo+ICAJCQlkcHVfY3N0YXRlID0gdG9fZHB1X2NydGNfc3RhdGUoY3J0Yy0+c3RhdGUpOwo+
ICAJCQljbGtfcmF0ZSA9IG1heChkcHVfY3N0YXRlLT5uZXdfcGVyZi5jb3JlX2Nsa19yYXRlLAo+
ICAJCQkJCQkJY2xrX3JhdGUpOwo+IEBAIC0zNjYsNyArMzYxLDcgQEAgaW50IGRwdV9jb3JlX3Bl
cmZfY3J0Y191cGRhdGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJb2xkID0gJmRwdV9jcnRj
LT5jdXJfcGVyZjsKPiAgCW5ldyA9ICZkcHVfY3N0YXRlLT5uZXdfcGVyZjsKPiAgCj4gLQlpZiAo
X2RwdV9jb3JlX3BlcmZfY3J0Y19pc19wb3dlcl9vbihjcnRjKSAmJiAhc3RvcF9yZXEpIHsKPiAr
CWlmIChjcnRjLT5lbmFibGVkICYmICFzdG9wX3JlcSkgewo+ICAJCWZvciAoaSA9IDA7IGkgPCBE
UFVfUE9XRVJfSEFORExFX0RCVVNfSURfTUFYOyBpKyspIHsKPiAgCQkJLyoKPiAgCQkJICogY2Fz
ZXMgZm9yIGJ1cyBiYW5kd2lkdGggdXBkYXRlLgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k
cm0vbXNtL2Rpc3AvZHB1MS9kcHVfY3J0Yy5oIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2Rw
dTEvZHB1X2NydGMuaAo+IGluZGV4IDJiZTQzMTIwMzhjOS4uOTBiYjI1NWZhZDNhIDEwMDY0NAo+
IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9jcnRjLmgKPiArKysgYi9k
cml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfY3J0Yy5oCj4gQEAgLTMxMSwxMyArMzEx
LDQgQEAgc3RhdGljIGlubGluZSBlbnVtIGRwdV9jcnRjX2NsaWVudF90eXBlIGRwdV9jcnRjX2dl
dF9jbGllbnRfdHlwZSgKPiAgCXJldHVybiBjcnRjICYmIGNydGMtPnN0YXRlID8gUlRfQ0xJRU5U
IDogTlJUX0NMSUVOVDsKPiAgfQo+ICAKPiAtLyoqCj4gLSAqIGRwdV9jcnRjX2lzX2VuYWJsZWQg
LSBjaGVjayBpZiBkcHUgY3J0YyBpcyBlbmFibGVkIG9yIG5vdAo+IC0gKiBAY3J0YzogUG9pbnRl
ciB0byBjcnRjCj4gLSAqLwo+IC1zdGF0aWMgaW5saW5lIGJvb2wgZHB1X2NydGNfaXNfZW5hYmxl
ZChzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gLXsKPiAtCXJldHVybiBjcnRjID8gY3J0Yy0+ZW5h
YmxlZCA6IGZhbHNlOwo+IC19Cj4gLQo+ICAjZW5kaWYgLyogX0RQVV9DUlRDX0hfICovCj4gLS0g
Cj4gMi4xOC4wCj4gCgotLSAKU2VhbiBQYXVsLCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8g
Q2hyb21pdW0gT1MKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn
Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs
Cg==