From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH 6/8] drm/msm: dpu: Separate crtc assignment from vblank enable Date: Wed, 14 Nov 2018 15:52:47 -0500 Message-ID: <20181114205247.GT154160@art_vandelay> References: <20181113205257.170707-1-sean@poorly.run> <20181113205257.170707-6-sean@poorly.run> <20181114151615.GO154160@art_vandelay> <25b009f90b6513f788fcc6748ae26e63@codeaurora.org> <20181114195704.GV9144@intel.com> <8f94651a5253e323564af5dfa8c242bc@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <8f94651a5253e323564af5dfa8c242bc@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jeykumar Sankaran Cc: Sean Paul , dri-devel@lists.freedesktop.org, Sean Paul , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org List-Id: linux-arm-msm@vger.kernel.org T24gV2VkLCBOb3YgMTQsIDIwMTggYXQgMTI6NDY6MzJQTSAtMDgwMCwgSmV5a3VtYXIgU2Fua2Fy YW4gd3JvdGU6Cj4gT24gMjAxOC0xMS0xNCAxMTo1NywgVmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+ ID4gT24gV2VkLCBOb3YgMTQsIDIwMTggYXQgMTE6NDM6NTFBTSAtMDgwMCwgSmV5a3VtYXIgU2Fu a2FyYW4gd3JvdGU6Cj4gPiA+IE9uIDIwMTgtMTEtMTQgMDc6MTYsIFNlYW4gUGF1bCB3cm90ZToK PiA+ID4gPiBPbiBUdWUsIE5vdiAxMywgMjAxOCBhdCAwNDo0ODoxMlBNIC0wODAwLCBKZXlrdW1h ciBTYW5rYXJhbiB3cm90ZToKPiA+ID4gPj4gT24gMjAxOC0xMS0xMyAxMjo1MiwgU2VhbiBQYXVs IHdyb3RlOgo+ID4gPiA+PiA+IEZyb206IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3Jn Pgo+ID4gPiA+PiA+Cj4gPiA+ID4+ID4gSW5zdGVhZCBvZiBhc3NpZ25pbmcvY2xlYXJpbmcgdGhl IGNydGMgb24gdmJsYW5rIGVuYWJsZS9kaXNhYmxlLCB3ZQo+ID4gPiA+IGNhbgo+ID4gPiA+PiA+ IGp1c3QgYXNzaWduIGFuZCBjbGVhciB0aGUgY3J0YyBvbiBtb2Rlc2V0LiBUaGF0IGFsbG93cyB1 cyB0byBqdXN0Cj4gPiA+ID4gdG9nZ2xlCj4gPiA+ID4+ID4gdGhlIGVuY29kZXIncyB2Ymxhbmsg aW50ZXJydXB0cyBvbiB2YmxhbmtfZW5hYmxlLgo+ID4gPiA+PiA+Cj4gPiA+ID4+ID4gU28gd2h5 IGlzIHRoaXMgaW1wb3J0YW50PyBQcmV2aW91c2x5IHRoZSBkcml2ZXIgd2FzIHVzaW5nIHRoZQo+ ID4gbGVnYWN5Cj4gPiA+ID4+ID4gcG9pbnRlcnMgdG8gYXNzaWduL2NsZWFyIHRoZSBjcnRjLiBM ZWdhY3kgcG9pbnRlcnMgYXJlIGNsZWFyZWQKPiA+IF9hZnRlcl8KPiA+ID4gPj4gV2hpY2ggcG9p bnRlcnMgYXJlIHlvdSByZWZlcnJpbmcgaGVyZSBhcyBsZWdhY3kgcG9pbnRlcnM/IENSVEM/Cj4g PiA+ID4KPiA+ID4gPiBlbmNvZGVyLT5jcnRjIGluIHRoaXMgY2FzZS4gVGhlIGxvb3AgaW4gdmJs YW5rX2VuYWJsZV9ub19sb2NrIHJlbGllcwo+ID4gb24KPiA+ID4gPiBlbmMtPmNydGMgPT0gY3J0 Ywo+ID4gPiA+Cj4gPiA+ID4+ID4gZGlzYWJsaW5nIHRoZSBoYXJkd2FyZSwgc28gdGhlIGxlZ2Fj eSBwb2ludGVyIHdhcyB2YWxpZCBkdXJpbmcKPiA+ID4gPj4gPiB2YmxhbmtfZGlzYWJsZSwgYnV0 IHRoYXQncyBub3Qgc29tZXRoaW5nIHdlIHNob3VsZCByZWx5IG9uLgo+ID4gPiA+PiA+Cj4gPiA+ ID4+ID4gSW5zdGVhZCBvZiByZWx5aW5nIG9uIHRoZSBjb3JlIG9yZGVyaW5nIHRoZSBsZWdhY3kg cG9pbnRlcgo+ID4gYXNzaWdubWVudHMKPiA+ID4gPj4gPiBqdXN0IHNvLCB3ZSdsbCBhc3NpZ24g dGhlIGNydGMgaW4gZHB1X2NydGMgZW5hYmxlL2Rpc2FibGUuIFRoaXMgaXMKPiA+IHRoZQo+ID4g PiA+PiA+IG9ubHkgcGxhY2UgdGhhdCBtYXBwaW5nIGNhbiBjaGFuZ2UsIHNvIHdlJ3JlIGNvdmVy ZWQgdGhlcmUuCj4gPiA+ID4+ID4KPiA+ID4gPj4gPiBXZSdyZSBhbHNvIHRha2luZyBhZHZhbnRh Z2Ugb2YgZHJtX2NydGNfdmJsYW5rX29uL29mZi4gQnkgdXNpbmcKPiA+IHRoaXMsCj4gPiA+ID4g d2UKPiA+ID4gPj4gPiBlbnN1cmUgdGhhdCB2YmxhbmtfZW5hYmxlL2Rpc2FibGUgY2FuIG5ldmVy IGJlIGNhbGxlZCB3aGlsZSB0aGUKPiA+IGNydGMKPiA+ID4gPiBpcwo+ID4gPiA+PiA+IG9mZiAo d2hpY2ggbWVhbnMgdGhlIGFzc2lnbmVkIGNydGMgd2lsbCBhbHdheXMgYmUgdmFsaWQpLiBBcyBz dWNoLAo+ID4gd2UKPiA+ID4gPj4KPiA+ID4gPj4gV2hhdCBhYm91dCB0aGUgZHJtX3ZibGFua19l bmFibGUvZGlzYWJsZSB0cmlnZ2VyZWQgYnkgZHJtX3ZibGFua19nZXQKPiA+ID4gPiB3aGVuCj4g PiA+ID4+IGNydGMKPiA+ID4gPj4gaXMgZGlzYWJsZWQ/IFdoYXQgaXMgdGhlIGV4cGVjdGVkIGJl aGF2aW9yIHRoZXJlPyB0aGUKPiA+IHZibGFua19yZXF1ZXN0ZWQKPiA+ID4gPj4gdmFyaWFibGUg cmVtb3ZlZCBieSB0aGUgbmV4dCBwYXRjaCB3YXMgaW50cm9kdWNlZCB0byBjYWNoZSB0aGUKPiA+ ID4gPj4gcmVxdWVzdC4KPiA+ID4gPgo+ID4gPiA+IFRoYXQgY2FzZSBpcyBjb3ZlcmVkIGJ5IHRo ZSBtb2Rlc2V0IGxvY2tzIGhlbGQgd2hlbiBjYWxsaW5nIGRpc2FibGUoKS4KPiA+ID4gPgo+ID4g PiBJIGFtIHN1cmUgaXQgd2lsbCB0YWtlIGNhcmUgb2YgZHJtX2NydGNfdmJsYW5rX29uL29mZiB0 cmlnZ2VyZWQgd2l0aGluCj4gPiA+IGNydGNfZGlzYWJsZS4KPiA+ID4gTXkgcXVlc3Rpb24gd2Fz IHdoYXQgd2FzIHRoZSBleHBlY3RlZCBiZWhhdmlvdXIgd2hlbgo+ID4gPiBEUk1fSU9DVExfV0FJ VF9WQkxBTksgaXMKPiA+ID4gY2FsbGVkIHdoZW4gY3J0YyBpcyBkaXNhYmxlZD8gdGhlIGlvY3Rs IHdpbGwgdHJ5IHRvIGNhbGwKPiA+ID4gZHJtX3ZibGFua19nZXQKPiA+ID4gYW5kIEkKPiA+ID4g ZG9uJ3Qgc2VlIHRoZSBwYXRjaCBjaGVja2luZyBmb3IgY3J0YyBiZWluZyBlbmFibGVkIGluIHRo ZSBwYXRoLgo+ID4gCj4gPiBkcm1fdmJsYW5rX29mZigpCj4gPiAvLyAuZW5hYmxlX3ZibGFuay8u ZGlzYWJsZV92Ymxhbmsgd2lsbCBuZXZlciBiZSBjYWxsZWQgaGVyZQo+ID4gZHJtX3ZibGFua19v bigpCj4gPiAKPiA+IFNvIGlmIHlvdSB1c2UgZHJtX3ZibGFua19vbi9vZmYganVkaWNpb3VzbHkg eW91IHdpbGwgbmV2ZXIKPiA+IGhhdmUgdG8gZGVhbCB3aXRoIHRoaXMgcGFydGljdWxhciBwcm9i bGVtLgo+ID4gCj4gVGhhbmtzIHZpbGxlIGZvciBjbGFyaWZ5aW5nIHRoYXQuCj4gCj4gV2UgY2Fu IG1ha2Ugc3VyZSB0byBhdm9pZCB0aGF0IHNlcXVlbmNlIGlmIHdlIGhhdmUgY29udHJvbCBvdmVy IGl0LiBJbiBEUFUsCj4gQ1JUQyBjYWxscwo+IGRwdV92Ymxhbmtfb2ZmIGluIGNydGNfZGlzYWJs ZS4gQWZ0ZXIgZGlzYWJsaW5nLCBubyBvbmUgc3RvcHBpbmcKPiB1c2Vyc3BhY2UgY2xpZW50cyB0 byBjYWxsIGludG8gRFJNX0lPQ1RMX1dBSVRfVkJMQU5LIG9uIHRoZSBjcnRjLiBUaGlzIGlvY3Rs Cj4gY2FsbHMgZW5hYmxlX3ZibGFuayB3aGVuIGl0IHNlZXMgdGhlIHZibGFuayBpcyBkaXNhYmxl ZCBbMV0uCgoKVGhhdCdzIHByZXZlbnRlZCBieSB0aGlzIGJpdCBpbiBkcm1fdmJsYW5rLmM6CgoJ LyoKCSAqIFByZXZlbnQgc3Vic2VxdWVudCBkcm1fdmJsYW5rX2dldCgpIGZyb20gcmUtZW5hYmxp bmcKCSAqIHRoZSB2YmxhbmsgaW50ZXJydXB0IGJ5IGJ1bXBpbmcgdGhlIHJlZmNvdW50LgoJICov CglpZiAoIXZibGFuay0+aW5tb2Rlc2V0KSB7CgkJYXRvbWljX2luYygmdmJsYW5rLT5yZWZjb3Vu dCk7CgkJdmJsYW5rLT5pbm1vZGVzZXQgPSAxOwoJfQoKQmFzaWNhbGx5IGl0IHR1cm5zIG9mZiB0 aGUgaHcgYW5kIHRoZW4gdGFrZXMgYSByZWZlcmVuY2Ugc3VjaCB0aGF0CmRybV92YmxhbmtfZ2V0 IHdpbGwgbmV2ZXIgY2FsbCBkcm1fdmJsYW5rX2VuYWJsZS4KClNlYW4KCj4gCj4gU28gZmFyLCB0 aGUgZHB1X2NydGNfdmJsYW5rIHdhcyBmYWlsaW5nIHdoZW4gaXQgZmluZHMgdGhhdCB0aGUgY3J0 YyBpcwo+IGRpc2FibGVkLgo+IFdpdGggdGhpcyBwYXRjaCwgdGhlIGNvbmRpdGlvbiB3YXMgcmVt b3ZlZCwgc28gSSB3YXMgd29uZGVyaW5nIHdoYXQgaXMgdGhlCj4gZXhwZWN0ZWQgYmVoYXZpb3Ig d2l0aCB0aGlzIHBhdGNoLgo+IAo+IFsxXSBodHRwczovL2dpdGxhYi5mcmVlZGVza3RvcC5vcmcv c2VhbnBhdWwvZHB1LXN0YWdpbmcvYmxvYi9mb3ItbmV4dC9kcml2ZXJzL2dwdS9kcm0vZHJtX3Zi bGFuay5jI0w5NTYKPiAKPiBUaGFua3MgYW5kIFJlZ2FyZHMsCj4gSmV5a3VtYXIgUy4KPiA+IC0t Cj4gPiBWaWxsZSBTeXJqw6Rsw6QKPiA+IEludGVsCj4gCj4gLS0gCj4gSmV5a3VtYXIgUwoKLS0g ClNlYW4gUGF1bCwgU29mdHdhcmUgRW5naW5lZXIsIEdvb2dsZSAvIENocm9taXVtIE9TCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=