From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, edubezval@gmail.com,
andy.gross@linaro.org, David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v1] arm64: dts: msm8998: thermal: split address space into two
Date: Thu, 22 Nov 2018 12:23:36 -0800 [thread overview]
Message-ID: <20181122202315.GN1921@tuxbook-pro> (raw)
In-Reply-To: <565873e4dd152df24c86d091327687f4aa3505e2.1542911304.git.amit.kucheria@linaro.org>
On Thu 22 Nov 10:32 PST 2018, Amit Kucheria wrote:
> We added support to split the register address space for
> tsens into TM and SROT regions in 'Commit 5b1283984fa3 ("thermal: tsens:
> Add support to split up register address space into two")'.
>
> Split up the tsens address space for msm8998 since it has a similar
> register layout to other versions of the IP to allow for better code
> sharing.
>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> (Compile-tested only, since I don't have the hardware)
You do have hardware, it's available in our conmux.
Regards,
Bjorn
> arch/arm64/boot/dts/qcom/msm8998.dtsi | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> index 78227cce16db..eb4f6f77969f 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> @@ -577,17 +577,18 @@
> cell-index = <0>;
> };
>
> - tsens0: thermal@10aa000 {
> + tsens0: thermal@10ab000 {
> compatible = "qcom,msm8998-tsens", "qcom,tsens-v2";
> - reg = <0x10aa000 0x2000>;
> -
> + reg = <0x10ab000 0x1000>, /* TM */
> + <0x10aa000 0x1000>; /* SROT */
> #qcom,sensors = <12>;
> #thermal-sensor-cells = <1>;
> };
>
> - tsens1: thermal@10ad000 {
> + tsens1: thermal@10ae000 {
> compatible = "qcom,msm8998-tsens", "qcom,tsens-v2";
> - reg = <0x10ad000 0x2000>;
> + reg = <0x10ae000 0x1000>, /* TM */
> + <0x10ad000 0x1000>; /* SROT */
>
> #qcom,sensors = <8>;
> #thermal-sensor-cells = <1>;
> --
> 2.17.1
>
prev parent reply other threads:[~2018-11-22 20:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1542911304.git.amit.kucheria@linaro.org>
2018-11-22 18:32 ` [PATCH v1] arm64: dts: msm8998: thermal: split address space into two Amit Kucheria
2018-11-22 20:23 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181122202315.GN1921@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=amit.kucheria@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).