From: Christoph Hellwig <hch@infradead.org>
To: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: airlied@linux.ie, robdclark@gmail.com, tfiga@chromium.org,
linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
Jordan Crouse <jcrouse@codeaurora.org>,
Sean Paul <seanpaul@chromium.org>
Subject: Re: [PATCH v2 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*
Date: Tue, 27 Nov 2018 23:39:40 -0800 [thread overview]
Message-ID: <20181128073940.GA13072@infradead.org> (raw)
In-Reply-To: <20181126213710.3084-1-vivek.gautam@codeaurora.org>
> + /*
> + * dma_sync_sg_*() flush the physical pages, so point
> + * sg->dma_address to the physical ones for the right behavior.
> + */
> + for_each_sg(msm_obj->sgt->sgl, s, msm_obj->sgt->nents, i)
> + sg_dma_address(s) = sg_phys(s);
> +
I'm sorry, but this is completely bogus and not acceptable.
The only place that is allowed to initialize sg_dma_address is
dma_map_sg. If the default dma ops don't work for your setup we have
major a problem and need to fix the dma api / iommu integration instead
of hacking around it.
next prev parent reply other threads:[~2018-11-28 7:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 21:37 [PATCH v2 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg* Vivek Gautam
[not found] ` <20181126213710.3084-1-vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-11-28 3:09 ` Tomasz Figa
2018-11-29 9:43 ` Vivek Gautam
2018-11-28 7:39 ` Christoph Hellwig [this message]
[not found] ` <20181128073940.GA13072-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2018-11-28 9:02 ` Vivek Gautam
2018-11-28 12:38 ` Rob Clark
[not found] ` <CAF6AEGuM-R0=KRSmT+bt6SBaZg_ea3A_YFE+xfR_oCH9d9uORA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-11-29 9:44 ` Vivek Gautam
2018-11-28 14:19 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128073940.GA13072@infradead.org \
--to=hch@infradead.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jcrouse@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=seanpaul@chromium.org \
--cc=tfiga@chromium.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).