From: Balakrishna Godavarthi <bgodavar@codeaurora.org>
To: marcel@holtmann.org, johan.hedberg@gmail.com
Cc: mka@chromium.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org,
linux-arm-msm@vger.kernel.org,
Balakrishna Godavarthi <bgodavar@codeaurora.org>
Subject: [PATCH v3 0/4] Bug fixes for Qualcomm BT chip wcn3990
Date: Fri, 30 Nov 2018 20:32:43 +0530 [thread overview]
Message-ID: <20181130150247.26294-1-bgodavar@codeaurora.org> (raw)
The below issues are found in the recent testing.
1. Observed device is not going into off state or not responding.
As wcn3990 require a power pulses to turn on the irrespctive of
igniting regulators, it was observed that power on or power off
pulses are not in sync with respective to chip.
The below patch will help us to wait until byte is pushed on to wires.
* Bluetooth: hci_qca: use wait_until_sent() for power pulses
2. Observed Chip responding when we are in sleep.
This is due to turn on flow control during change baudrate request.
The below patch will only pull the RTS line high instead of turning off
the flow.
* Bluetooth: hci_qca: Pull RTS line high for baudrate change command.
3. Frame reassembly errors splashing on console.
wcn3990 requires will use multiple baudrates during booting stage.
i.e. 2400 bps while sending power off pulse
115200 bps while sending power on pulse
port close
port open
set baudrate to 115200 request the chip version.
during above process, we are seeing some stray bytes coming up
on the UART Rx FIFO it could be due to frequent baudrate change.
This patch will stop the frame reassembly errors.
* Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990
4. Disable IBS state machine and flush Tx buffer
We are disabling IBS and flushing the Tx buffer before turning off the chip.
This is due to IBS state machine is active when we turn off the chip.
This will stop queuing IBS protocol bytes.
* Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer
Changes in v3:
* moved IBS & qca_flush to different patch
* updated comments in code fo Deassert RTS patch
Changes in v2:
* Removed Bluetooth: hci_qca: clear HCI_QUIRK_RESET_ON_CLOSE flag patch
will be sending as separate series.
Balakrishna Godavarthi (4):
Bluetooth: hci_qca: use wait_until_sent() for power pulses
Bluetooth: hci_qca: Deassert RTS while baudrate change command
Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990
Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer
drivers/bluetooth/hci_qca.c | 77 +++++++++++++++++++++----------------
1 file changed, 43 insertions(+), 34 deletions(-)
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next reply other threads:[~2018-11-30 15:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 15:02 Balakrishna Godavarthi [this message]
2018-11-30 15:02 ` [PATCH v3 1/4] Bluetooth: hci_qca: use wait_until_sent() for power pulses Balakrishna Godavarthi
2018-12-05 6:25 ` Johan Hovold
2018-12-06 10:40 ` Balakrishna Godavarthi
2018-12-11 15:42 ` Balakrishna Godavarthi
2018-12-12 16:42 ` Johan Hovold
2018-12-14 12:32 ` Balakrishna Godavarthi
2018-12-14 13:16 ` Johan Hovold
2018-12-14 13:41 ` Balakrishna Godavarthi
2018-11-30 15:02 ` [PATCH v3 2/4] Bluetooth: hci_qca: Deassert RTS while baudrate change command Balakrishna Godavarthi
2018-11-30 15:02 ` [PATCH v3 3/4] Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990 Balakrishna Godavarthi
2018-11-30 15:02 ` [PATCH v3 4/4] Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer Balakrishna Godavarthi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130150247.26294-1-bgodavar@codeaurora.org \
--to=bgodavar@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).