From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH] dmaengine: remove DBGFS_FUNC_DECL() Date: Wed, 5 Dec 2018 21:29:12 +0530 Message-ID: <20181205155912.GP2847@vkoul-mobl> References: <20181130154249.3222-1-tiny.windzz@gmail.com> <20181205082719.GF2847@vkoul-mobl> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Frank Lee Cc: dan.j.williams@intel.com, sudeep.dutt@intel.com, ashutosh.dixit@intel.com, daniel@zonque.org, Haojian Zhuang , robert.jarzmik@free.fr, okaya@kernel.org, Andy Gross , David Brown , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On 05-12-18, 23:49, Frank Lee wrote: > On Wed, Dec 5, 2018 at 4:27 PM Vinod Koul wrote: > > > > On 30-11-18, 10:42, Yangtao Li wrote: > > > We already have the DEFINE_SHOW_ATTRIBUTE,There is no need to define > > > such a macro,so remove DBGFS_FUNC_DECL.Also use macro to simplify some > > > code. > > > > Spaces after full stop and comma please > > > > > > > > Signed-off-by: Yangtao Li > > > --- > > > drivers/dma/amba-pl08x.c | 14 ++------------ > > > drivers/dma/mic_x100_dma.c | 22 +++------------------- > > > drivers/dma/pxa_dma.c | 24 ++++++++++++------------ > > > drivers/dma/qcom/hidma_dbg.c | 33 ++++++--------------------------- > > > > Do you mind splitting it per file. > Hi Vinod: > > Why not apply it once ？The change is not too big. It is not about big or small. A patch should do one thing and touch a single module. It also helps people when they look at changes and backports. -- ~Vinod