* Re: [PATCH] qcom-scm: Include <linux/err.h> header
2018-12-28 19:52 ` Fabio Estevam
@ 2018-12-28 19:56 ` Fabio Estevam
2018-12-28 20:08 ` Fabio Estevam
2018-12-28 20:00 ` Fabio Estevam
2018-12-29 0:27 ` Bjorn Andersson
2 siblings, 1 reply; 15+ messages in thread
From: Fabio Estevam @ 2018-12-28 19:56 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Jonathan Marek, linux-arm-msm, DRI mailing list, Andy Gross,
Shawn Guo, Chris Healy
Hi Bjorn,
On Fri, Dec 28, 2018 at 5:52 PM Fabio Estevam <festevam@gmail.com> wrote:
> By the way, I just ran get_maintainers in this patch and linux-arm-msm
> is not listed.
Would you like to me to submit a patch like this to fix this problem?
diff --git a/MAINTAINERS b/MAINTAINERS
index 7a9804a891fd..e014de05b046 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4797,6 +4797,7 @@ L: freedreno@lists.freedesktop.org
T: git git://people.freedesktop.org/~robclark/linux
S: Maintained
F: drivers/gpu/drm/msm/
+F: include/linux/qcom_scm.h
F: include/uapi/drm/msm_drm.h
F: Documentation/devicetree/bindings/display/msm/
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH] qcom-scm: Include <linux/err.h> header
2018-12-28 19:56 ` Fabio Estevam
@ 2018-12-28 20:08 ` Fabio Estevam
0 siblings, 0 replies; 15+ messages in thread
From: Fabio Estevam @ 2018-12-28 20:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Jonathan Marek, linux-arm-msm, DRI mailing list, Andy Gross,
Shawn Guo, Chris Healy
On Fri, Dec 28, 2018 at 5:56 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Bjorn,
>
> On Fri, Dec 28, 2018 at 5:52 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> > By the way, I just ran get_maintainers in this patch and linux-arm-msm
> > is not listed.
>
> Would you like to me to submit a patch like this to fix this problem?
Just realized that include/linux/qcom_scm.h is used in several
subsystems, so maybe a better location would be under ARM/QUALCOMM
SUPPORT?
diff --git a/MAINTAINERS b/MAINTAINERS
index 7a9804a891fd..77836b9a8ffd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1950,6 +1950,7 @@ F: drivers/tty/serial/msm_serial.c
F: drivers/*/pm8???-*
F: drivers/mfd/ssbi.c
F: drivers/firmware/qcom_scm*
+F: include/linux/qcom_scm.h
T: git git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git
ARM/RADISYS ENP2611 MACHINE SUPPORT
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH] qcom-scm: Include <linux/err.h> header
2018-12-28 19:52 ` Fabio Estevam
2018-12-28 19:56 ` Fabio Estevam
@ 2018-12-28 20:00 ` Fabio Estevam
2018-12-29 0:27 ` Bjorn Andersson
2 siblings, 0 replies; 15+ messages in thread
From: Fabio Estevam @ 2018-12-28 20:00 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Jonathan Marek, linux-arm-msm, DRI mailing list, Andy Gross,
Shawn Guo, Chris Healy
On Fri, Dec 28, 2018 at 5:52 PM Fabio Estevam <festevam@gmail.com> wrote:
> > Andy, please pick up for inclusion in -rc
>
> Yes, it would be really nice if we could get this fix into 4.20-rc1 so
> that imx_v6_v7_defconfig could be built.
Ops, I meant 4.21-rc1 :-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] qcom-scm: Include <linux/err.h> header
2018-12-28 19:52 ` Fabio Estevam
2018-12-28 19:56 ` Fabio Estevam
2018-12-28 20:00 ` Fabio Estevam
@ 2018-12-29 0:27 ` Bjorn Andersson
2018-12-29 12:19 ` Fabio Estevam
2 siblings, 1 reply; 15+ messages in thread
From: Bjorn Andersson @ 2018-12-29 0:27 UTC (permalink / raw)
To: Fabio Estevam
Cc: Jonathan Marek, linux-arm-msm, DRI mailing list, Andy Gross,
Shawn Guo, Chris Healy
On Fri 28 Dec 11:52 PST 2018, Fabio Estevam wrote:
> Hi Bjorn,
>
> On Fri, Dec 28, 2018 at 5:31 PM Bjorn Andersson
> <bjorn.andersson@linaro.org> wrote:
[..]
> > Fabio, please use get_maintainers, so your patches hits the appropriate
> > mailing lists (linux-arm-msm@ in this case)
[..]
> By the way, I just ran get_maintainers in this patch and linux-arm-msm
> is not listed.
>
Sorry about that, I forgot that the header file is not covered by the
MAINTAINERS file.
Your second patch looks good, but I'm hoping we can merge the upcoming
v3 of Amit's patch right after the merge window. It fixes this and a lot
of other pieces where we would like to include linux-arm-msm@:
https://lore.kernel.org/lkml/d153a86748f99526e7790bfc4ef8781a2016fd51.1545126964.git.amit.kucheria@linaro.org/
Regards,
Bjorn
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] qcom-scm: Include <linux/err.h> header
2018-12-29 0:27 ` Bjorn Andersson
@ 2018-12-29 12:19 ` Fabio Estevam
2018-12-29 19:51 ` Andy Gross
0 siblings, 1 reply; 15+ messages in thread
From: Fabio Estevam @ 2018-12-29 12:19 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Jonathan Marek, linux-arm-msm, DRI mailing list, Andy Gross,
Shawn Guo, Chris Healy
Hi Bjorn,
On Fri, Dec 28, 2018 at 10:27 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
> Sorry about that, I forgot that the header file is not covered by the
> MAINTAINERS file.
>
> Your second patch looks good, but I'm hoping we can merge the upcoming
> v3 of Amit's patch right after the merge window. It fixes this and a lot
> of other pieces where we would like to include linux-arm-msm@:
>
> https://lore.kernel.org/lkml/d153a86748f99526e7790bfc4ef8781a2016fd51.1545126964.git.amit.kucheria@linaro.org/
Amit's patch adds the following entry:
+F: include/linux/*/qcom*
but it does not catch include/linux/qcom_scm.h
It also needs
+F: include/linux/qcom*
in order to catch include/linux/qcom-geni-se.h and include/linux/qcom_scm.h
I can add that entry after Amit's patch gets applied.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] qcom-scm: Include <linux/err.h> header
2018-12-29 12:19 ` Fabio Estevam
@ 2018-12-29 19:51 ` Andy Gross
2019-01-14 19:50 ` Amit Kucheria
0 siblings, 1 reply; 15+ messages in thread
From: Andy Gross @ 2018-12-29 19:51 UTC (permalink / raw)
To: Fabio Estevam
Cc: Jonathan Marek, linux-arm-msm, DRI mailing list, Bjorn Andersson,
Shawn Guo, Chris Healy
On Sat, Dec 29, 2018 at 10:19:32AM -0200, Fabio Estevam wrote:
> Hi Bjorn,
>
> On Fri, Dec 28, 2018 at 10:27 PM Bjorn Andersson
> <bjorn.andersson@linaro.org> wrote:
>
> > Sorry about that, I forgot that the header file is not covered by the
> > MAINTAINERS file.
> >
> > Your second patch looks good, but I'm hoping we can merge the upcoming
> > v3 of Amit's patch right after the merge window. It fixes this and a lot
> > of other pieces where we would like to include linux-arm-msm@:
> >
> > https://lore.kernel.org/lkml/d153a86748f99526e7790bfc4ef8781a2016fd51.1545126964.git.amit.kucheria@linaro.org/
>
> Amit's patch adds the following entry:
>
> +F: include/linux/*/qcom*
>
> but it does not catch include/linux/qcom_scm.h
>
> It also needs
>
> +F: include/linux/qcom*
>
> in order to catch include/linux/qcom-geni-se.h and include/linux/qcom_scm.h
>
> I can add that entry after Amit's patch gets applied.
Or I can add it to Amit's. I'll ping him to make sure that's ok.
Thanks,
Andy
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] qcom-scm: Include <linux/err.h> header
2018-12-29 19:51 ` Andy Gross
@ 2019-01-14 19:50 ` Amit Kucheria
2019-01-14 19:53 ` Chris Healy
0 siblings, 1 reply; 15+ messages in thread
From: Amit Kucheria @ 2019-01-14 19:50 UTC (permalink / raw)
To: Andy Gross
Cc: Jonathan Marek, DRI mailing list, Bjorn Andersson, linux-arm-msm,
Shawn Guo, Chris Healy
On Sun, Dec 30, 2018 at 1:21 AM Andy Gross <andy.gross@linaro.org> wrote:
>
> On Sat, Dec 29, 2018 at 10:19:32AM -0200, Fabio Estevam wrote:
> > Hi Bjorn,
> >
> > On Fri, Dec 28, 2018 at 10:27 PM Bjorn Andersson
> > <bjorn.andersson@linaro.org> wrote:
> >
> > > Sorry about that, I forgot that the header file is not covered by the
> > > MAINTAINERS file.
> > >
> > > Your second patch looks good, but I'm hoping we can merge the upcoming
> > > v3 of Amit's patch right after the merge window. It fixes this and a lot
> > > of other pieces where we would like to include linux-arm-msm@:
> > >
> > > https://lore.kernel.org/lkml/d153a86748f99526e7790bfc4ef8781a2016fd51.1545126964.git.amit.kucheria@linaro.org/
> >
> > Amit's patch adds the following entry:
> >
> > +F: include/linux/*/qcom*
> >
> > but it does not catch include/linux/qcom_scm.h
> >
> > It also needs
> >
> > +F: include/linux/qcom*
> >
> > in order to catch include/linux/qcom-geni-se.h and include/linux/qcom_scm.h
> >
> > I can add that entry after Amit's patch gets applied.
>
> Or I can add it to Amit's. I'll ping him to make sure that's ok.
>
I'd forgotten about this patch! Just sent out v3 which is still
missing "F: include/linux/qcom*".
Let me know if you want me to send out v4 with this added.
Regards,
Amit
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] qcom-scm: Include <linux/err.h> header
2019-01-14 19:50 ` Amit Kucheria
@ 2019-01-14 19:53 ` Chris Healy
2019-01-14 20:02 ` Fabio Estevam
0 siblings, 1 reply; 15+ messages in thread
From: Chris Healy @ 2019-01-14 19:53 UTC (permalink / raw)
To: Amit Kucheria
Cc: Jonathan Marek, Shawn Guo, DRI mailing list, Bjorn Andersson,
linux-arm-msm, Andy Gross
Perhaps I am confused but it appears that this patch has already
landed upstream and got included in 5.0-rc2:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/include/linux/qcom_scm.h?h=v5.0-rc2&id=2076607a20bd4dfba699185616cbbbce06d3fa59
On Mon, Jan 14, 2019 at 11:51 AM Amit Kucheria
<amit.kucheria@verdurent.com> wrote:
>
> On Sun, Dec 30, 2018 at 1:21 AM Andy Gross <andy.gross@linaro.org> wrote:
> >
> > On Sat, Dec 29, 2018 at 10:19:32AM -0200, Fabio Estevam wrote:
> > > Hi Bjorn,
> > >
> > > On Fri, Dec 28, 2018 at 10:27 PM Bjorn Andersson
> > > <bjorn.andersson@linaro.org> wrote:
> > >
> > > > Sorry about that, I forgot that the header file is not covered by the
> > > > MAINTAINERS file.
> > > >
> > > > Your second patch looks good, but I'm hoping we can merge the upcoming
> > > > v3 of Amit's patch right after the merge window. It fixes this and a lot
> > > > of other pieces where we would like to include linux-arm-msm@:
> > > >
> > > > https://lore.kernel.org/lkml/d153a86748f99526e7790bfc4ef8781a2016fd51.1545126964.git.amit.kucheria@linaro.org/
> > >
> > > Amit's patch adds the following entry:
> > >
> > > +F: include/linux/*/qcom*
> > >
> > > but it does not catch include/linux/qcom_scm.h
> > >
> > > It also needs
> > >
> > > +F: include/linux/qcom*
> > >
> > > in order to catch include/linux/qcom-geni-se.h and include/linux/qcom_scm.h
> > >
> > > I can add that entry after Amit's patch gets applied.
> >
> > Or I can add it to Amit's. I'll ping him to make sure that's ok.
> >
>
> I'd forgotten about this patch! Just sent out v3 which is still
> missing "F: include/linux/qcom*".
>
> Let me know if you want me to send out v4 with this added.
>
> Regards,
> Amit
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] qcom-scm: Include <linux/err.h> header
2019-01-14 19:53 ` Chris Healy
@ 2019-01-14 20:02 ` Fabio Estevam
2019-01-14 20:09 ` Chris Healy
0 siblings, 1 reply; 15+ messages in thread
From: Fabio Estevam @ 2019-01-14 20:02 UTC (permalink / raw)
To: Chris Healy
Cc: Amit Kucheria, Jonathan Marek, linux-arm-msm, DRI mailing list,
Bjorn Andersson, Andy Gross, Shawn Guo
Hi Chris,
On Mon, Jan 14, 2019 at 5:54 PM Chris Healy <cphealy@gmail.com> wrote:
>
> Perhaps I am confused but it appears that this patch has already
> landed upstream and got included in 5.0-rc2:
The patch that Amit is referring is the following entry in MAINTAINERS file:
+F: include/linux/qcom*
so that the proper lists can be put on Cc on future changes of this file.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] qcom-scm: Include <linux/err.h> header
2019-01-14 20:02 ` Fabio Estevam
@ 2019-01-14 20:09 ` Chris Healy
0 siblings, 0 replies; 15+ messages in thread
From: Chris Healy @ 2019-01-14 20:09 UTC (permalink / raw)
To: Fabio Estevam
Cc: Amit Kucheria, Jonathan Marek, linux-arm-msm, DRI mailing list,
Bjorn Andersson, Andy Gross, Shawn Guo
There we go, I was definitely confused... Tnx
On Mon, Jan 14, 2019 at 12:02 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Chris,
>
> On Mon, Jan 14, 2019 at 5:54 PM Chris Healy <cphealy@gmail.com> wrote:
> >
> > Perhaps I am confused but it appears that this patch has already
> > landed upstream and got included in 5.0-rc2:
>
> The patch that Amit is referring is the following entry in MAINTAINERS file:
>
> +F: include/linux/qcom*
>
> so that the proper lists can be put on Cc on future changes of this file.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 15+ messages in thread