From: Sean Paul <sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
To: Chandan Uddaraju <chandanu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
manasi.d.navare-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
nganji-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
hoegsberg-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [DPU PATCH] drm: add definitions for DP Audio/Video compliance tests
Date: Tue, 22 Jan 2019 14:05:07 -0500 [thread overview]
Message-ID: <20190122190507.GF114153@art_vandelay> (raw)
In-Reply-To: <1546413325-11673-2-git-send-email-chandanu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
On Tue, Jan 01, 2019 at 11:15:25PM -0800, Chandan Uddaraju wrote:
This seems fine to me. Could you please:
- delete the cover letter
- move the cover letter description into the patch commit msg
- strip DPU from the subject prefix
- send it to dri-devel, maintaining the cc's you have here
With that,
Reviewed-by: Sean Paul <sean@poorly.run>
Sean
> Signed-off-by: Chandan Uddaraju <chandanu@codeaurora.org>
> ---
> include/drm/drm_dp_helper.h | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 5736c94..e688e05 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -556,6 +556,8 @@
> # define DP_TEST_LINK_EDID_READ (1 << 2)
> # define DP_TEST_LINK_PHY_TEST_PATTERN (1 << 3) /* DPCD >= 1.1 */
> # define DP_TEST_LINK_FAUX_PATTERN (1 << 4) /* DPCD >= 1.2 */
> +# define DP_TEST_LINK_AUDIO_PATTERN (1 << 5) /* DPCD >= 1.2 */
> +# define DP_TEST_LINK_AUDIO_DISABLED_VIDEO (1 << 6) /* DPCD >= 1.2 */
>
> #define DP_TEST_LINK_RATE 0x219
> # define DP_LINK_RATE_162 (0x6)
> @@ -604,6 +606,7 @@
> # define DP_COLOR_FORMAT_RGB (0 << 1)
> # define DP_COLOR_FORMAT_YCbCr422 (1 << 1)
> # define DP_COLOR_FORMAT_YCbCr444 (2 << 1)
> +# define DP_TEST_DYNAMIC_RANGE_VESA (0 << 3)
> # define DP_TEST_DYNAMIC_RANGE_CEA (1 << 3)
> # define DP_TEST_YCBCR_COEFFICIENTS (1 << 4)
> # define DP_YCBCR_COEFFICIENTS_ITU601 (0 << 4)
> @@ -653,6 +656,16 @@
>
> #define DP_TEST_SINK 0x270
> # define DP_TEST_SINK_START (1 << 0)
> +#define DP_TEST_AUDIO_MODE 0x271
> +#define DP_TEST_AUDIO_PATTERN_TYPE 0x272
> +#define DP_TEST_AUDIO_PERIOD_CH1 0x273
> +#define DP_TEST_AUDIO_PERIOD_CH2 0x274
> +#define DP_TEST_AUDIO_PERIOD_CH3 0x275
> +#define DP_TEST_AUDIO_PERIOD_CH4 0x276
> +#define DP_TEST_AUDIO_PERIOD_CH5 0x277
> +#define DP_TEST_AUDIO_PERIOD_CH6 0x278
> +#define DP_TEST_AUDIO_PERIOD_CH7 0x279
> +#define DP_TEST_AUDIO_PERIOD_CH8 0x27A
>
> #define DP_FEC_STATUS 0x280 /* 1.4 */
> # define DP_FEC_DECODE_EN_DETECTED (1 << 0)
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
> _______________________________________________
> Freedreno mailing list
> Freedreno@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/freedreno
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
next prev parent reply other threads:[~2019-01-22 19:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 7:15 [DPU PATCH] Add additional definitions needed for DP compliance tests Chandan Uddaraju
[not found] ` <1546413325-11673-1-git-send-email-chandanu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2019-01-02 7:15 ` [DPU PATCH] drm: add definitions for DP Audio/Video " Chandan Uddaraju
[not found] ` <1546413325-11673-2-git-send-email-chandanu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2019-01-22 19:05 ` Sean Paul [this message]
2019-01-28 23:02 ` chandanu-sgV2jX0FEOL9JmXXK+q4OQ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122190507.GF114153@art_vandelay \
--to=sean-p7ytbzm4h96eqtr555yldq@public.gmane.org \
--cc=abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=chandanu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=hoegsberg-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=manasi.d.navare-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=nganji-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox