From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/4] drm/msm: Use drm_mode_vrefresh instead of mode->vrefresh Date: Tue, 29 Jan 2019 09:59:40 +0100 Message-ID: <20190129085940.GM3271@phenom.ffwll.local> References: <20190128204306.95076-1-sean@poorly.run> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190128204306.95076-1-sean@poorly.run> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: Sean Paul , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: linux-arm-msm@vger.kernel.org T24gTW9uLCBKYW4gMjgsIDIwMTkgYXQgMDM6NDI6NDhQTSAtMDUwMCwgU2VhbiBQYXVsIHdyb3Rl Ogo+IEZyb206IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+IAo+IFVzZSB0aGUg ZHJtX21vZGVfdnJlZnJlc2ggaGVscGVyIHdoZXJlIHdlIG5lZWQgcmVmcmVzaCByYXRlIGluIGNh c2UKPiB2cmVmcmVzaCBpcyBlbXB0eS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBTZWFuIFBhdWwgPHNl YW5wYXVsQGNocm9taXVtLm9yZz4KCkkgdGhpbmsgYWRkaW5nIGEgdG9kbyB0byByZW1vdmUgdGhl c2UgZmllbGRzIGFuZCBzd2l0Y2ggZXZlcm9uZSBvdmVyIHRvCnRoZSBoZWxwZXJzIHdvdWxkIGJl IHVzZWZ1bC4gUmVjb21wdXRpbmcgaXMgbm90IGdvaW5nIHRvIGh1cnQgdXMgSSB0aGluawppbiBt b2Rlc2V0IGNvZGUgKHRoZSBvbmUgY2FzZSB3aGVyZSB3ZSBkbyBjYXJlIGlzIHZibGFuayBjb25z dGFudHMsIGFuZAp0aG9zZSBhcmUgc29tZXdoZXJlIGVsc2UpLCBhbmQgd291bGQgYXZvaWQgYWxs IHRoZXNlIGJ1Z3MgLi4uCi1EYW5pZWwKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL21zbS9kaXNw L2RwdTEvZHB1X2VuY29kZXIuYyAgICAgICAgICB8IDYgKysrLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry bS9tc20vZGlzcC9kcHUxL2RwdV9lbmNvZGVyX3BoeXNfY21kLmMgfCA1ICsrKy0tCj4gIGRyaXZl cnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9wbGFuZS5jICAgICAgICAgICAgfCAyICstCj4g IGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9tZHA1L21kcDVfY21kX2VuY29kZXIuYyAgICAgfCA0 ICsrLS0KPiAgNCBmaWxlcyBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9lbmNv ZGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5jb2Rlci5jCj4gaW5k ZXggOTQxYWMyNWQyYTAyMy4uZGQ3MWNiNmJhNGY1YyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5jb2Rlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L21zbS9kaXNwL2RwdTEvZHB1X2VuY29kZXIuYwo+IEBAIC01MjIsOCArNTIyLDggQEAgc3RhdGlj IHZvaWQgX2RwdV9lbmNvZGVyX2FkanVzdF9tb2RlKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25u ZWN0b3IsCj4gIAo+ICAJbGlzdF9mb3JfZWFjaF9lbnRyeShjdXJfbW9kZSwgJmNvbm5lY3Rvci0+ bW9kZXMsIGhlYWQpIHsKPiAgCQlpZiAoY3VyX21vZGUtPnZkaXNwbGF5ID09IGFkal9tb2RlLT52 ZGlzcGxheSAmJgo+IC0JCQljdXJfbW9kZS0+aGRpc3BsYXkgPT0gYWRqX21vZGUtPmhkaXNwbGF5 ICYmCj4gLQkJCWN1cl9tb2RlLT52cmVmcmVzaCA9PSBhZGpfbW9kZS0+dnJlZnJlc2gpIHsKPiAr CQkgICAgY3VyX21vZGUtPmhkaXNwbGF5ID09IGFkal9tb2RlLT5oZGlzcGxheSAmJgo+ICsJCSAg ICBkcm1fbW9kZV92cmVmcmVzaChjdXJfbW9kZSkgPT0gZHJtX21vZGVfdnJlZnJlc2goYWRqX21v ZGUpKSB7Cj4gIAkJCWFkal9tb2RlLT5wcml2YXRlID0gY3VyX21vZGUtPnByaXZhdGU7Cj4gIAkJ CWFkal9tb2RlLT5wcml2YXRlX2ZsYWdzIHw9IGN1cl9tb2RlLT5wcml2YXRlX2ZsYWdzOwo+ICAJ CX0KPiBAQCAtMTgwNSw3ICsxODA1LDcgQEAgdm9pZCBkcHVfZW5jb2Rlcl9raWNrb2ZmKHN0cnVj dCBkcm1fZW5jb2RlciAqZHJtX2VuYywgYm9vbCBhc3luYykKPiAgCj4gIAlhdG9taWNfc2V0KCZk cHVfZW5jLT5mcmFtZV9kb25lX3RpbWVvdXQsCj4gIAkJCURQVV9GUkFNRV9ET05FX1RJTUVPVVQg KiAxMDAwIC8KPiAtCQkJZHJtX2VuYy0+Y3J0Yy0+c3RhdGUtPmFkanVzdGVkX21vZGUudnJlZnJl c2gpOwo+ICsJCQlkcm1fbW9kZV92cmVmcmVzaCgmZHJtX2VuYy0+Y3J0Yy0+c3RhdGUtPmFkanVz dGVkX21vZGUpKTsKPiAgCW1vZF90aW1lcigmZHB1X2VuYy0+ZnJhbWVfZG9uZV90aW1lciwgamlm ZmllcyArCj4gIAkJKChhdG9taWNfcmVhZCgmZHB1X2VuYy0+ZnJhbWVfZG9uZV90aW1lb3V0KSAq IEhaKSAvIDEwMDApKTsKPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlz cC9kcHUxL2RwdV9lbmNvZGVyX3BoeXNfY21kLmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3Av ZHB1MS9kcHVfZW5jb2Rlcl9waHlzX2NtZC5jCj4gaW5kZXggOTlhYjVjYTliZWQzYi4uZjIxMTYz MzEzZDYzNSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVf ZW5jb2Rlcl9waHlzX2NtZC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEv ZHB1X2VuY29kZXJfcGh5c19jbWQuYwo+IEBAIC00MDQsNyArNDA0LDggQEAgc3RhdGljIHZvaWQg ZHB1X2VuY29kZXJfcGh5c19jbWRfdGVhcmNoZWNrX2NvbmZpZygKPiAgCQlyZXR1cm47Cj4gIAl9 Cj4gIAo+IC0JdGNfY2ZnLnZzeW5jX2NvdW50ID0gdnN5bmNfaHogLyAobW9kZS0+dnRvdGFsICog bW9kZS0+dnJlZnJlc2gpOwo+ICsJdGNfY2ZnLnZzeW5jX2NvdW50ID0gdnN5bmNfaHogLwo+ICsJ CQkJKG1vZGUtPnZ0b3RhbCAqIGRybV9tb2RlX3ZyZWZyZXNoKG1vZGUpKTsKPiAgCj4gIAkvKiBl bmFibGUgZXh0ZXJuYWwgVEUgYWZ0ZXIga2lja29mZiB0byBhdm9pZCBwcmVtYXR1cmUgYXV0b3Jl ZnJlc2ggKi8KPiAgCXRjX2NmZy5od192c3luY19tb2RlID0gMDsKPiBAQCAtNDI0LDcgKzQyNSw3 IEBAIHN0YXRpYyB2b2lkIGRwdV9lbmNvZGVyX3BoeXNfY21kX3RlYXJjaGVja19jb25maWcoCj4g IAlEUFVfREVCVUdfQ01ERU5DKGNtZF9lbmMsCj4gIAkJInRjICVkIHZzeW5jX2Nsa19zcGVlZF9o eiAldSB2dG90YWwgJXUgdnJlZnJlc2ggJXVcbiIsCj4gIAkJcGh5c19lbmMtPmh3X3BwLT5pZHgg LSBQSU5HUE9OR18wLCB2c3luY19oeiwKPiAtCQltb2RlLT52dG90YWwsIG1vZGUtPnZyZWZyZXNo KTsKPiArCQltb2RlLT52dG90YWwsIGRybV9tb2RlX3ZyZWZyZXNoKG1vZGUpKTsKPiAgCURQVV9E RUJVR19DTURFTkMoY21kX2VuYywKPiAgCQkidGMgJWQgZW5hYmxlICV1IHN0YXJ0X3BvcyAldSBy ZF9wdHJfaXJxICV1XG4iLAo+ICAJCXBoeXNfZW5jLT5od19wcC0+aWR4IC0gUElOR1BPTkdfMCwg dGNfZW5hYmxlLCB0Y19jZmcuc3RhcnRfcG9zLAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vbXNtL2Rpc3AvZHB1MS9kcHVfcGxhbmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9k cHUxL2RwdV9wbGFuZS5jCj4gaW5kZXggYjAxMTgzYjMwOWI5ZS4uZGExZjcyN2Q3NDk1NyAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfcGxhbmUuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9wbGFuZS5jCj4gQEAgLTM4Nyw3 ICszODcsNyBAQCBzdGF0aWMgdm9pZCBfZHB1X3BsYW5lX3NldF9vdF9saW1pdChzdHJ1Y3QgZHJt X3BsYW5lICpwbGFuZSwKPiAgCW90X3BhcmFtcy53aWR0aCA9IGRybV9yZWN0X3dpZHRoKCZwZHB1 LT5waXBlX2NmZy5zcmNfcmVjdCk7Cj4gIAlvdF9wYXJhbXMuaGVpZ2h0ID0gZHJtX3JlY3RfaGVp Z2h0KCZwZHB1LT5waXBlX2NmZy5zcmNfcmVjdCk7Cj4gIAlvdF9wYXJhbXMuaXNfd2ZkID0gIXBk cHUtPmlzX3J0X3BpcGU7Cj4gLQlvdF9wYXJhbXMuZnJhbWVfcmF0ZSA9IGNydGMtPm1vZGUudnJl ZnJlc2g7Cj4gKwlvdF9wYXJhbXMuZnJhbWVfcmF0ZSA9IGRybV9tb2RlX3ZyZWZyZXNoKCZjcnRj LT5tb2RlKTsKPiAgCW90X3BhcmFtcy52YmlmX2lkeCA9IFZCSUZfUlQ7Cj4gIAlvdF9wYXJhbXMu Y2xrX2N0cmwgPSBwZHB1LT5waXBlX2h3LT5jYXAtPmNsa19jdHJsOwo+ICAJb3RfcGFyYW1zLnJk ID0gdHJ1ZTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL21kcDUvbWRw NV9jbWRfZW5jb2Rlci5jIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL21kcDUvbWRwNV9jbWRf ZW5jb2Rlci5jCj4gaW5kZXggYzE5NjJmMjllYzdkNi4uNjM0MWFjMDEwZjdkZSAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvbWRwNS9tZHA1X2NtZF9lbmNvZGVyLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvbWRwNS9tZHA1X2NtZF9lbmNvZGVyLmMKPiBA QCAtNTksMTAgKzU5LDEwIEBAIHN0YXRpYyBpbnQgcGluZ3BvbmdfdGVhcmNoZWNrX3NldHVwKHN0 cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlciwKPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgCX0KPiAg Cj4gLQl0b3RhbF9saW5lc194MTAwID0gbW9kZS0+dnRvdGFsICogbW9kZS0+dnJlZnJlc2g7Cj4g Kwl0b3RhbF9saW5lc194MTAwID0gbW9kZS0+dnRvdGFsICogZHJtX21vZGVfdnJlZnJlc2gobW9k ZSk7Cj4gIAlpZiAoIXRvdGFsX2xpbmVzX3gxMDApIHsKPiAgCQlEUk1fREVWX0VSUk9SKGRldiwg IiVzOiB2dG90YWwoJWQpIG9yIHZyZWZyZXNoKCVkKSBpcyAwXG4iLAo+IC0JCQkJX19mdW5jX18s IG1vZGUtPnZ0b3RhbCwgbW9kZS0+dnJlZnJlc2gpOwo+ICsJCQkgICAgICBfX2Z1bmNfXywgbW9k ZS0+dnRvdGFsLCBkcm1fbW9kZV92cmVmcmVzaChtb2RlKSk7Cj4gIAkJcmV0dXJuIC1FSU5WQUw7 Cj4gIAl9Cj4gIAo+IC0tIAo+IFNlYW4gUGF1bCwgU29mdHdhcmUgRW5naW5lZXIsIEdvb2dsZSAv IENocm9taXVtIE9TCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwg Q29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg==