From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH] net: phy: at803x: disable delay only for RGMII mode
Date: Wed, 13 Feb 2019 14:29:00 +0100
Message-ID: <20190213132900.GA24589@lunn.ch>
References: <20190212141922.12849-1-vkoul@kernel.org>
 <20190213131206.GA460@centauri.lan>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <netdev-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20190213131206.GA460@centauri.lan>
Sender: netdev-owner@vger.kernel.org
To: Niklas Cassel <niklas.cassel@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>, David S Miller <davem@davemloft.net>, linux-arm-msm@vger.kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>, netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>, "Nori, Sekhar" <nsekhar@ti.com>, Peter Ujfalusi <peter.ujfalusi@ti.com>, Marc Gonzalez <marc.w.gonzalez@free.fr>
List-Id: linux-arm-msm@vger.kernel.org

> So we have these modes:
> 
> PHY_INTERFACE_MODE_RGMII: TX and RX delays disabled
> PHY_INTERFACE_MODE_RGMII_ID: TX and RX delays enabled
> PHY_INTERFACE_MODE_RGMII_RXID: RX delay enabled, TX delay disabled
> PHY_INTERFACE_MODE_RGMII_TXID: TX delay enabled, RX delay disabled
> 
> What I don't like with this patch, is that if we specify phy-mode
> PHY_INTERFACE_MODE_RGMII_TXID, this patch will enable TX delay,
> but RX delay will not be explicitly set.

That is not the behaviour we want. It is best to assume the device is
in a random state, and correctly enable/disable all delays as
requested. Only leave the hardware alone if PHY_INTERFACE_MODE_NA is
used.

     Andrew