linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] regulator: core: do not report EPROBE_DEFER as error but as debug
@ 2019-04-17 19:24 Jorge Ramirez-Ortiz
  2019-04-17 19:24 ` Jorge Ramirez-Ortiz
                   ` (5 more replies)
  0 siblings, 6 replies; 14+ messages in thread
From: Jorge Ramirez-Ortiz @ 2019-04-17 19:24 UTC (permalink / raw)
  To: jorge.ramirez-ortiz, lgirdwood, broonie
  Cc: linux-kernel, linux-arm-msm, khasim.mohammed

Temporary failures to get a regulator (EPROBE_DEFER) should be logged
as debug information instead of errors.

Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
---
 drivers/regulator/core.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 186a37675b50..a2725269a94a 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -4342,8 +4342,6 @@ int regulator_bulk_get(struct device *dev, int num_consumers,
 						      consumers[i].supply);
 		if (IS_ERR(consumers[i].consumer)) {
 			ret = PTR_ERR(consumers[i].consumer);
-			dev_err(dev, "Failed to get supply '%s': %d\n",
-				consumers[i].supply, ret);
 			consumers[i].consumer = NULL;
 			goto err;
 		}
@@ -4352,6 +4350,13 @@ int regulator_bulk_get(struct device *dev, int num_consumers,
 	return 0;
 
 err:
+	if (ret != -EPROBE_DEFER)
+		dev_err(dev, "Failed to get supply '%s': %d\n",
+			consumers[i].supply, ret);
+	else
+		dev_dbg(dev, "Failed to get supply '%s', deferring\n",
+			consumers[i].supply);
+
 	while (--i >= 0)
 		regulator_put(consumers[i].consumer);
 
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2019-04-26  9:49 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-17 19:24 [PATCH v2] regulator: core: do not report EPROBE_DEFER as error but as debug Jorge Ramirez-Ortiz
2019-04-17 19:24 ` Jorge Ramirez-Ortiz
2019-04-18 10:26 ` Applied "regulator: core: do not report EPROBE_DEFER as error but as debug" to the regulator tree Mark Brown
2019-04-18 10:26   ` Mark Brown
2019-04-23  9:49   ` Jorge Ramirez
2019-04-23  9:49     ` Jorge Ramirez
2019-04-25 19:24 ` Mark Brown
2019-04-25 19:24   ` Mark Brown
2019-04-25 19:26 ` Mark Brown
2019-04-25 19:26   ` Mark Brown
2019-04-26  9:40 ` Mark Brown
2019-04-26  9:40   ` Mark Brown
2019-04-26  9:44 ` Mark Brown
2019-04-26  9:44   ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).