From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: Add Lenovo Miix 630 Date: Fri, 26 Apr 2019 21:42:45 -0700 Message-ID: <20190427044245.GD3137@builder> References: <20190415160915.16324-1-jeffrey.l.hugo@gmail.com> <20190415161115.16466-1-jeffrey.l.hugo@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190415161115.16466-1-jeffrey.l.hugo@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Jeffrey Hugo Cc: robh+dt@kernel.org, mark.rutland@arm.com, agross@kernel.org, david.brown@linaro.org, lee.jones@linaro.org, dmitry.torokhov@gmail.com, jikos@kernel.org, benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On Mon 15 Apr 09:11 PDT 2019, Jeffrey Hugo wrote: > diff --git a/arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi b/arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi [..] > + thermal-zones { > + battery-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + > + thermal-sensors = <&tsens0 0>; I guess you inherited the battery and skin thermal nodes from my MTP dts. Unfortunately after talking to Amit I think I got these wrong, and they should be &pmi8998_adc 0 and 5 instead. Can you confirm this? > + > + trips { > + battery_crit: trip0 { > + temperature = <60000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + }; Regards, Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44BC9C43218 for ; Sat, 27 Apr 2019 04:42:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0BE71206A3 for ; Sat, 27 Apr 2019 04:42:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="M54Nlan9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726012AbfD0Emu (ORCPT ); Sat, 27 Apr 2019 00:42:50 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:33941 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725966AbfD0Emu (ORCPT ); Sat, 27 Apr 2019 00:42:50 -0400 Received: by mail-pg1-f193.google.com with SMTP id c13so1557260pgt.1 for ; Fri, 26 Apr 2019 21:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WEovO+cO7DKaKRte5LqibCX9cDDJIx6yMyYSCxr4n3M=; b=M54Nlan91fGK1/rczwBvSO0HzrpMZncujIL/aCMk+F2XoYx+e9wpC9AoUJ84EU58M0 elLfAAttMFZnoKLt6GIOr7396htsfaXu6LAivfDmROvbEbryJHdOu0Wy88hbEpNM0qlB 0uJX9DQK64BDC49VKqrc9gFtJR9QBleykKT/3aKdMCqhniKbwkO3EpRBQjDciOJs6+ZI HsfwWD7V8iVHgO9qLdxxdoe181p0gnwyPoii95gMbVGp0/zqdgK8dj+9mx9LHOHc/80k sjZy8aFjO24tqAKwbyiBaMQF5YuaJ5T+/h4PgYVO2KDm5b0ptaM0sx0VhcM+wcrnrVGA 65kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WEovO+cO7DKaKRte5LqibCX9cDDJIx6yMyYSCxr4n3M=; b=fU8FpMCNaFkoocywLKPPO2sVe5q6NTtbh8mCou+JXbLVMYsxlRG2YYYsl/7Bvi037f tzgFoth2P+NvPgMI6gGZfaNMDZ7sCZbzYx2NbKKtAkzxIXx+ieCIDQ7RODpMrD1Ot/Ao 0isOlcva+DOsUWBELyHd9FOXGsVVZFrQTZv+tgnQlXAwusIZg+JfgUDKWOHj+n2CxFCB 0XsPp5dNWkdzbutZ46qmofEdX5UWXRd8lkJdy+RB76DskuY/ok6cGLFHMhIbjQ7vvaDp Rp+1ZT9VKsD22amoi7DA5dmhtRAjGK7ubuqf5ZUy7j4nTr652tWiLqENvnSk+NgoHi0B G/aQ== X-Gm-Message-State: APjAAAXa9ER7Tzm10XfK/d+OY88ZNub4QDioufPXQCzSQUAskXxlnxlc pLurmC6JM2oY0d6IauJtzA4iHw== X-Google-Smtp-Source: APXvYqxolgKhNMVGdcwwE4jPUTzcIHAOrb+hJg4ZYvAyzwxw55UeXlnG1SZt+Eiqbwwt398E6HFfsA== X-Received: by 2002:a65:484a:: with SMTP id i10mr1424766pgs.408.1556340169181; Fri, 26 Apr 2019 21:42:49 -0700 (PDT) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id q33sm9273642pgl.38.2019.04.26.21.42.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Apr 2019 21:42:48 -0700 (PDT) Date: Fri, 26 Apr 2019 21:42:45 -0700 From: Bjorn Andersson To: Jeffrey Hugo Cc: robh+dt@kernel.org, mark.rutland@arm.com, agross@kernel.org, david.brown@linaro.org, lee.jones@linaro.org, dmitry.torokhov@gmail.com, jikos@kernel.org, benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: Add Lenovo Miix 630 Message-ID: <20190427044245.GD3137@builder> References: <20190415160915.16324-1-jeffrey.l.hugo@gmail.com> <20190415161115.16466-1-jeffrey.l.hugo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190415161115.16466-1-jeffrey.l.hugo@gmail.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Message-ID: <20190427044245.ys0pXPv62w0XGp8EqYgp2Odcs8_7CEl7OXdNFchcSuE@z> On Mon 15 Apr 09:11 PDT 2019, Jeffrey Hugo wrote: > diff --git a/arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi b/arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi [..] > + thermal-zones { > + battery-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + > + thermal-sensors = <&tsens0 0>; I guess you inherited the battery and skin thermal nodes from my MTP dts. Unfortunately after talking to Amit I think I got these wrong, and they should be &pmi8998_adc 0 and 5 instead. Can you confirm this? > + > + trips { > + battery_crit: trip0 { > + temperature = <60000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + }; Regards, Bjorn