From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEFE9C43218 for ; Sat, 27 Apr 2019 04:52:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 83E07206A3 for ; Sat, 27 Apr 2019 04:52:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vQYNb9gK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725974AbfD0Evz (ORCPT ); Sat, 27 Apr 2019 00:51:55 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:41014 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725933AbfD0Evz (ORCPT ); Sat, 27 Apr 2019 00:51:55 -0400 Received: by mail-pg1-f193.google.com with SMTP id f6so2534451pgs.8 for ; Fri, 26 Apr 2019 21:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=geA6cGH9WlHlZ6+r9f1MxObUwQsZekexZq6X5/ShuCQ=; b=vQYNb9gK8xZsEEmXAZmZhs5tlSl3flbTafpuprbc6k6Ill+tEMU8jinu45VoKh+p9U wPYAm3TMM9WtQenJYgtD3JCaPQ7SN74coKrHWermczMIIVzEq55mmJqjsj0iohUskqwC A45mAXRTRX2tft/ZjUF8Ie7mzeKDGEc5KBOqw8AhdkHp4hoRggR1oANbBGmeZRriMA/v PM4a3jdYFs8Vnc0UhBcCu/7rPXFUw7RmHydBnWgVna2RNxq/NzJ8xwcvI10jXzTnp1Bt Q2cKc2b3PmfdddIIWvfYn7rZgNOxduMiad0hVXxYNpuBrztCWz0/FnGkDq7s42UZNOC9 K/ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=geA6cGH9WlHlZ6+r9f1MxObUwQsZekexZq6X5/ShuCQ=; b=pqLU1ibJ90zm/GeKgQnx3jsZfwafcEk9he7tHe2LAbkr47krgqYhJlv4i+haScXEih 7YRZmwdloxVhshFO+20ulJcYyJRrj+JD+e53H66iSbJfjKLnUpFci3vYx5uekEe82O3n DWNake+tvJe6kjFB1zYBNi90+grOWHwjBGBRtryOtmdCjBuCnf1I1vx7sU2fEgDysFWq TRkCRe2+RFrzb2X8+XU6TgWw70RRW7qKt3SD69zNZJkFvmDR3BZ0Mic+BoX0qXXbGKoh finiXhcOLSl6LPsC0BdJuKduwAfOBfk1yW6kEIl4+HIAFqgrIfm8jbCjBRf5k0liUCwT eeNg== X-Gm-Message-State: APjAAAVPhOxTJ4mu89oKtzg0u5gaHCgj3z+X27j3ANgQbHFIqAvwaD9C 7fb2Jn8I7nE+M1X+WSDVBfHBiw== X-Google-Smtp-Source: APXvYqx8OyHHLJRKmNB1ciBoD0YYoTcis1T5153Owx8T2M0hc7uWomWYz0y2zGTsItLaXwSsSGsPvw== X-Received: by 2002:a65:6091:: with SMTP id t17mr47039299pgu.328.1556340714744; Fri, 26 Apr 2019 21:51:54 -0700 (PDT) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id w189sm55630182pfw.147.2019.04.26.21.51.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Apr 2019 21:51:53 -0700 (PDT) Date: Fri, 26 Apr 2019 21:51:51 -0700 From: Bjorn Andersson To: Marc Gonzalez Cc: Jeffrey Hugo , Andy Gross , MSM , gpio , Linus Walleij , Rob Herring , Mark Rutland Subject: Re: [PATCH v1] arm64: dts: qcom: msm8998: Add i2c5 pins Message-ID: <20190427045151.GE3137@builder> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu 25 Apr 09:06 PDT 2019, Marc Gonzalez wrote: > Downstream source: > https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/msm8998-pinctrl.dtsi?h=LE.UM.1.3.r3.25#n165 > > Signed-off-by: Marc Gonzalez > --- > arch/arm64/boot/dts/qcom/msm8998-pins.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi b/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi > index 6db70acd38ee..d0a95c70d1e7 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi > @@ -2,6 +2,13 @@ > /* Copyright (c) 2018, The Linux Foundation. All rights reserved. */ > > &tlmm { > + i2c5_default: i2c5_default { You need to reference this node for it to make a difference. Also the drive-strength and bias are board specific, so please move this to your board dts (and reference the node). Regards, Bjorn > + pins = "gpio87", "gpio88"; > + function = "blsp_i2c5"; > + drive-strength = <2>; > + bias-disable; > + }; > + > sdc2_clk_on: sdc2_clk_on { > config { > pins = "sdc2_clk"; > -- > 2.17.1